SREP-325: Ensure osdctl runs make lint - #64935
Conversation
Fix `lint` job for `osdctl`
openshift-ci-robot
added
the
jira/valid-reference
|
@joshbranham: This pull request references SREP-325 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.20.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/label tide/merge-method-squash |
openshift-ci
Bot
added
tide/merge-method-squash
|
[REHEARSALNOTIFIER]
Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals. Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
/pj-rehearse |
|
@joshbranham: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
@joshbranham: This pull request references SREP-325 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.20.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@joshbranham: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/pj-rehearse ack |
|
@joshbranham: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
openshift-ci-robot
added
the
rehearsals-ack
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: joshbranham, rafael-azevedo The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* Update openshift-osdctl-master.yaml Fix `lint` job for `osdctl` * make jobs
* Update openshift-osdctl-master.yaml Fix `lint` job for `osdctl` * make jobs
3 participants
Fix lint job for osdctl, and add format as an actual test target. Depends on openshift/osdctl#748
Rehearsal run showing linting actually ran, and 0 failures https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/test-platform-results/pr-logs/pull/openshift_release/64935/rehearse-64935-pull-ci-openshift-osdctl-master-lint/1922729410796982272/artifacts/test/build-log.txt