Skip to content

CNTRLPLANE-777: Clean up 4.20 AKS e2e naming & cleanup - #66442

Merged
openshift-merge-bot[bot] merged 2 commits into
openshift:masterfrom
bryan-cox:CNTRLPLANE-777
Jun 27, 2025
Merged

CNTRLPLANE-777: Clean up 4.20 AKS e2e naming & cleanup#66442
openshift-merge-bot[bot] merged 2 commits into
openshift:masterfrom
bryan-cox:CNTRLPLANE-777

Conversation

@bryan-cox

@bryan-cox bryan-cox commented Jun 25, 2025

Copy link
Copy Markdown
Member

This PR:

  • renames the 4.20 azure e2e to AKS to prevent future confusion when we add azure e2es for self-managed
  • removes Patryk as a maintainer and reviewer from HyperShift related items

This commit renames the informing test from hypershift-e2e-azure to hypershift-e2e-aks. This test is for managed Azure on HyperShift which uses AKS mgmt clusters. In the near future, we will support self-managed Azure which will need its own tests. We need to clean up the current naming so it's not confusing which test is for which Azure type on HyperShift.
@openshift-ci-robot

openshift-ci-robot commented Jun 25, 2025

Copy link
Copy Markdown
Contributor

@bryan-cox: This pull request references CNTRLPLANE-777 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.20.0" version, but no target version was set.

Details

In response to this:

This PR renames the 4.20 azure e2e to AKS to prevent future confusion when we add azure e2es for self-managed. Also removed Patryk as a maintainer and reviewer from HyperShift related items.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jun 25, 2025
@openshift-ci
openshift-ci Bot requested review from csrwng and enxebre June 25, 2025 13:50
@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jun 25, 2025
@openshift-ci-robot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@bryan-cox: no rehearsable tests are affected by this change

@openshift-ci-robot

openshift-ci-robot commented Jun 25, 2025

Copy link
Copy Markdown
Contributor

@bryan-cox: This pull request references CNTRLPLANE-777 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.20.0" version, but no target version was set.

Details

In response to this:

This PR:

  • renames the 4.20 azure e2e to AKS to prevent future confusion when we add azure e2es for self-managed
  • removes Patryk as a maintainer and reviewer from HyperShift related items.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot

openshift-ci-robot commented Jun 25, 2025

Copy link
Copy Markdown
Contributor

@bryan-cox: This pull request references CNTRLPLANE-777 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.20.0" version, but no target version was set.

Details

In response to this:

This PR:

  • renames the 4.20 azure e2e to AKS to prevent future confusion when we add azure e2es for self-managed
  • removes Patryk as a maintainer and reviewer from HyperShift related items

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@jparrill jparrill left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jun 27, 2025
@openshift-ci

openshift-ci Bot commented Jun 27, 2025

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bryan-cox, deepsm007, jparrill

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 27, 2025
@openshift-ci

openshift-ci Bot commented Jun 27, 2025

Copy link
Copy Markdown
Contributor

@bryan-cox: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot
openshift-merge-bot Bot merged commit 3d816c9 into openshift:master Jun 27, 2025
liweinan pushed a commit to liweinan/release that referenced this pull request Aug 5, 2025
* Rename hypershift-e2e-azure to aks

This commit renames the informing test from hypershift-e2e-azure to hypershift-e2e-aks. This test is for managed Azure on HyperShift which uses AKS mgmt clusters. In the near future, we will support self-managed Azure which will need its own tests. We need to clean up the current naming so it's not confusing which test is for which Azure type on HyperShift.

* Remove Patryk-Stefanski from HyperShift approvers and reviewers
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants