Skip to content

fix: change skip_if_only_changed for terraform-provider-rhcs#77865

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
amandahla:skip-konflux
Apr 16, 2026
Merged

fix: change skip_if_only_changed for terraform-provider-rhcs#77865
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
amandahla:skip-konflux

Conversation

@amandahla
Copy link
Copy Markdown
Contributor

@amandahla amandahla commented Apr 15, 2026

This PR changes configuration for skipping jobs in terraform-provider-rhcs.

The new regex includes .tekton, .github, renovate.json, golang-ci.yml and .ci-operator.yaml

Summary by CodeRabbit

  • Chores
    • Enhanced E2E presubmit test workflows to expand skip conditions for configuration-only changes. Tests will now be bypassed when modifications are limited to CI configuration files, infrastructure directories, and documentation. This optimization reduces unnecessary test execution, improves pipeline efficiency, and allows testing resources to focus on actual code changes while providing faster feedback for non-code updates.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 15, 2026

Walkthrough

Two CI/CD configuration files were updated with modified skip_if_only_changed regex patterns for ROSA E2E presubmit test entries. The patterns now include additional skip-eligible files (.golang-ci.yml, renovate.json, .ci-operator.yaml) and directories (.github, .tekton) alongside existing paths.

Changes

Cohort / File(s) Summary
RHCS Terraform Provider CI/CD Configuration
ci-operator/config/terraform-redhat/terraform-provider-rhcs/terraform-redhat-terraform-provider-rhcs-main__e2e-presubmits.yaml, ci-operator/jobs/terraform-redhat/terraform-provider-rhcs/terraform-redhat-terraform-provider-rhcs-main-presubmits.yaml
Updated skip_if_only_changed regex patterns for four E2E ROSA presubmit test entries to expand skip-eligible files and directories. New patterns include .golang-ci.yml, renovate.json, .ci-operator.yaml, .github, and .tekton alongside existing docs, subsystem, and examples paths.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 10
✅ Passed checks (10 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and specifically describes the main change: updating skip_if_only_changed configuration for terraform-provider-rhcs.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Stable And Deterministic Test Names ✅ Passed PR modifies only CI configuration YAML files with skip_if_only_changed patterns; no Ginkgo test files or dynamic test names are involved.
Test Structure And Quality ✅ Passed The custom check for Ginkgo test code quality is not applicable; PR only modifies CI/CD YAML configuration files without any test code.
Microshift Test Compatibility ✅ Passed This PR modifies only CI configuration YAML files and does not add any new Ginkgo e2e tests.
Single Node Openshift (Sno) Test Compatibility ✅ Passed This PR modifies CI configuration files (YAML) in the ci-operator directory, not Ginkgo test code. The changes update regex patterns for the skip_if_only_changed field to determine when CI jobs should be skipped based on file modifications. Since no new Ginkgo e2e tests are being added to the codebase, the Single Node OpenShift (SNO) Test Compatibility check is not applicable to this PR.
Topology-Aware Scheduling Compatibility ✅ Passed Modified files contain only CI/CD configuration (Prow job definitions and test skip patterns) with no Kubernetes scheduling constraints, pod affinity rules, or topology-incompatible directives.
Ote Binary Stdout Contract ✅ Passed The custom check regarding OTE Binary Stdout Contract is not applicable to this PR as it only modifies YAML configuration files with no Go source code changes.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed This PR does not add any new Ginkgo e2e tests. Changes are limited to CI/CD configuration YAML files updating skip_if_only_changed patterns.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 15, 2026
@openshift-merge-bot
Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@amandahla: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-terraform-redhat-terraform-provider-rhcs-main-e2e-presubmits-rosa-hcp-advanced-critical-high-presubmit terraform-redhat/terraform-provider-rhcs presubmit Ci-operator config changed
pull-ci-terraform-redhat-terraform-provider-rhcs-main-e2e-presubmits-rosa-hcp-private-critical-high-presubmit terraform-redhat/terraform-provider-rhcs presubmit Ci-operator config changed
pull-ci-terraform-redhat-terraform-provider-rhcs-main-e2e-presubmits-rosa-sts-advanced-critical-high-presubmit terraform-redhat/terraform-provider-rhcs presubmit Ci-operator config changed
pull-ci-terraform-redhat-terraform-provider-rhcs-main-e2e-presubmits-rosa-sts-private-critical-high-presubmit terraform-redhat/terraform-provider-rhcs presubmit Ci-operator config changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In
`@ci-operator/config/terraform-redhat/terraform-provider-rhcs/terraform-redhat-terraform-provider-rhcs-main__e2e-presubmits.yaml`:
- Line 22: The skip_if_only_changed regex currently uses alternation like
^(?:docs|\.github|\.tekton|subsystem|examples) which can overmatch prefixes
(e.g., docs-api); update each occurrence of the skip_if_only_changed pattern to
enforce directory boundaries by appending a group that requires either a slash
or end-of-string (e.g., change the alternation to
^(?:docs|\.github|\.tekton|subsystem|examples)(?:/|$)) so only those exact
directories (or their subpaths) are matched; update all instances referenced by
the diff (the skip_if_only_changed entries) accordingly.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 91e42362-65e3-4c2a-9986-f9b6454b2e3a

📥 Commits

Reviewing files that changed from the base of the PR and between 6765879 and 13db57d.

📒 Files selected for processing (2)
  • ci-operator/config/terraform-redhat/terraform-provider-rhcs/terraform-redhat-terraform-provider-rhcs-main__e2e-presubmits.yaml
  • ci-operator/jobs/terraform-redhat/terraform-provider-rhcs/terraform-redhat-terraform-provider-rhcs-main-presubmits.yaml

@amandahla
Copy link
Copy Markdown
Contributor Author

/pj-rehearse ack

@openshift-merge-bot
Copy link
Copy Markdown
Contributor

@amandahla: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-merge-bot openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Apr 15, 2026
@marcolan018
Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Apr 15, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Apr 15, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: amandahla, marcolan018

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Apr 15, 2026

@amandahla: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot Bot merged commit d9e4c7c into openshift:main Apr 16, 2026
16 checks passed
HarshwardhanPatil07 pushed a commit to HarshwardhanPatil07/release that referenced this pull request Apr 23, 2026
Prucek pushed a commit to Prucek/release that referenced this pull request Apr 29, 2026
BATMAN-JD pushed a commit to BATMAN-JD/release that referenced this pull request May 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants