Skip to content

OCM-24531 | ci: skip .tekton-only ROSA presubmits#79678

Open
olucasfreitas wants to merge 1 commit into
openshift:mainfrom
olucasfreitas:OCM-24531
Open

OCM-24531 | ci: skip .tekton-only ROSA presubmits#79678
olucasfreitas wants to merge 1 commit into
openshift:mainfrom
olucasfreitas:OCM-24531

Conversation

@olucasfreitas
Copy link
Copy Markdown
Contributor

@olucasfreitas olucasfreitas commented May 25, 2026

Summary

  • Skip ROSA presubmit jobs when a PR only changes .tekton or closely related automation-only files
  • Apply the skip guard to the ROSA CLI source/test presubmits plus the image-building presubmits generated from release config
  • Regenerate the generated ROSA presubmit job file so the release repo stays consistent

Why

The ROSA CLI Renovate/Konflux config now auto-merges .tekton updates (openshift/rosa#3244), but the current openshift/release config still runs ROSA presubmits like build, commits, lint, test, coverage, and image presubmits even when a PR only changes automation files. This mirrors the provider-side optimization done in openshift/release#77865, adapted to the actual ROSA presubmit surface.

Related Issues and PRs

Files Changed

  • ci-operator/config/openshift/rosa/openshift-rosa-master.yaml - add skip_if_only_changed to lint, build, test, commits, coverage
  • ci-operator/config/openshift/rosa/openshift-rosa-master__e2e-presubmits.yaml - add skip_if_only_changed to e2e image build
  • ci-operator/config/openshift/rosa/openshift-rosa-master__images.yaml - add skip_if_only_changed to image build
  • ci-operator/config/openshift/rosa/openshift-rosa-master__images-release.yaml - add skip_if_only_changed to release image build
  • ci-operator/jobs/openshift/rosa/openshift-rosa-master-presubmits.yaml - regenerated via make jobs

Validation

  • make jobs succeeded
  • Reviewed generated diff
  • Skip regex: ^(LICENSE|OWNERS|README\.md|\.gitignore|renovate\.json|\.ci-operator\.yaml)$|^(?:docs|\.github|\.tekton)(?:/|$)

Summary by CodeRabbit

This PR adds skip guards to the ROSA (Red Hat OpenShift on AWS) CI job configuration in the openshift/release repository. The changes prevent ROSA presubmit jobs from running unnecessarily when a PR only modifies automation-related files.

What's changing

Five ROSA presubmit jobs (lint, build, test, commits, and coverage) now include a skip_if_only_changed condition that skips execution when the PR only touches:

  • Top-level repository metadata files: LICENSE, OWNERS, README.md, .gitignore, renovate.json, .ci-operator.yaml
  • Automation directories: .tekton/, .github/, or docs/

Practical impact

This prevents CI from spinning up expensive job runs when contributors are updating automation files, documentation, or configuration that doesn't affect the actual ROSA build or test logic. This aligns with equivalent automation in the openshift/rosa repository itself (which auto-merges such changes) and follows a precedent set by other provider configurations.

Files modified

The changes span the ROSA job configuration files in ci-operator/config/openshift/rosa/:

  • openshift-rosa-master.yaml — adds skip conditions to the main presubmit tests
  • openshift-rosa-master__e2e-presubmits.yaml — adds skip to e2e image build
  • openshift-rosa-master__images.yaml — adds skip to image build
  • openshift-rosa-master__images-release.yaml — adds skip to release image build
  • openshift-rosa-master-presubmits.yaml — regenerated via make jobs to sync the generated Prow job definitions

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 25, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 00622336-b0f9-4b51-b5f6-baf070324c8f

📥 Commits

Reviewing files that changed from the base of the PR and between fbb648f and af726ac.

⛔ Files ignored due to path filters (1)
  • ci-operator/jobs/openshift/rosa/openshift-rosa-master-presubmits.yaml is excluded by !ci-operator/jobs/**
📒 Files selected for processing (1)
  • ci-operator/config/openshift/rosa/openshift-rosa-master.yaml

Walkthrough

This PR adds skip conditions to five Prow test jobs in the OpenShift ROSA master configuration. Each job now skips execution when the changeset only touches non-code files (LICENSE, OWNERS, README.md, .gitignore, renovate.json, .ci-operator.yaml) or paths under docs/, .github/, or .tekton/. Job commands and containers remain unchanged.

Changes

ROSA Prow job skip conditions

Layer / File(s) Summary
Add skip_if_only_changed to Prow jobs
ci-operator/config/openshift/rosa/openshift-rosa-master.yaml
Five jobs (lint, build, test, commits, coverage) each add a skip_if_only_changed condition using a shared regex pattern that skips execution for documentation, infrastructure, and metadata-only changes.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Suggested labels

lgtm, rehearsals-ack, jira/valid-reference

Suggested reviewers

  • ravitri
  • bmeng
  • gdbranco
🚥 Pre-merge checks | ✅ 12
✅ Passed checks (12 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'OCM-24531 | ci: skip .tekton-only ROSA presubmits' directly and clearly summarizes the main change: adding skip conditions to ROSA presubmit jobs for .tekton-only changes.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed PR contains only CI/CD configuration changes (Prow job YAML files), not Ginkgo test code. The check is not applicable as no test definitions are modified.
Test Structure And Quality ✅ Passed PR only modifies CI configuration YAML files, not Ginkgo test code. The custom check for test structure is not applicable to CI configuration changes.
Microshift Test Compatibility ✅ Passed This PR modifies CI/CD configuration YAML files in the openshift/release repository, not Ginkgo test code. No new e2e tests are added, so the MicroShift test compatibility check does not apply.
Single Node Openshift (Sno) Test Compatibility ✅ Passed PR adds only CI/Prow job configuration changes with skip_if_only_changed conditions; no new Ginkgo e2e tests added requiring SNO compatibility review.
Topology-Aware Scheduling Compatibility ✅ Passed This PR modifies CI/CD configuration files (ci-operator configs and Prow job definitions) only, not deployment manifests or operator code. No scheduling constraints are introduced.
Ote Binary Stdout Contract ✅ Passed PR modifies only YAML CI configuration files, not Go code. OTE Binary Stdout Contract applies only to Go code violations; check is not applicable.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed PR contains no new Ginkgo e2e tests; changes are only to Prow job configuration files (YAML) that add skip conditions to existing CI jobs. The custom check is not applicable.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 25, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: olucasfreitas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 25, 2026
@openshift-ci openshift-ci Bot requested review from amandahla and marcolan018 May 25, 2026 15:27
@openshift-merge-bot
Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@olucasfreitas: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-rosa-master-build openshift/rosa presubmit Ci-operator config changed
pull-ci-openshift-rosa-master-commits openshift/rosa presubmit Ci-operator config changed
pull-ci-openshift-rosa-master-coverage openshift/rosa presubmit Ci-operator config changed
pull-ci-openshift-rosa-master-lint openshift/rosa presubmit Ci-operator config changed
pull-ci-openshift-rosa-master-test openshift/rosa presubmit Ci-operator config changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 25, 2026

@olucasfreitas: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@olucasfreitas
Copy link
Copy Markdown
Contributor Author

@amandahla please review this when you can, low priority

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant