OCM-24531 | ci: skip .tekton-only ROSA presubmits#79678
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Enterprise Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
WalkthroughThis PR adds skip conditions to five Prow test jobs in the OpenShift ROSA master configuration. Each job now skips execution when the changeset only touches non-code files (LICENSE, OWNERS, README.md, .gitignore, renovate.json, .ci-operator.yaml) or paths under docs/, .github/, or .tekton/. Job commands and containers remain unchanged. ChangesROSA Prow job skip conditions
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 12✅ Passed checks (12 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: olucasfreitas The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
[REHEARSALNOTIFIER]
Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
@olucasfreitas: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
@amandahla please review this when you can, low priority |
Summary
.tektonor closely related automation-only filesWhy
The ROSA CLI Renovate/Konflux config now auto-merges
.tektonupdates (openshift/rosa#3244), but the currentopenshift/releaseconfig still runs ROSA presubmits likebuild,commits,lint,test,coverage, and image presubmits even when a PR only changes automation files. This mirrors the provider-side optimization done in openshift/release#77865, adapted to the actual ROSA presubmit surface.Related Issues and PRs
Files Changed
ci-operator/config/openshift/rosa/openshift-rosa-master.yaml- addskip_if_only_changedto lint, build, test, commits, coverageci-operator/config/openshift/rosa/openshift-rosa-master__e2e-presubmits.yaml- addskip_if_only_changedto e2e image buildci-operator/config/openshift/rosa/openshift-rosa-master__images.yaml- addskip_if_only_changedto image buildci-operator/config/openshift/rosa/openshift-rosa-master__images-release.yaml- addskip_if_only_changedto release image buildci-operator/jobs/openshift/rosa/openshift-rosa-master-presubmits.yaml- regenerated viamake jobsValidation
make jobssucceeded^(LICENSE|OWNERS|README\.md|\.gitignore|renovate\.json|\.ci-operator\.yaml)$|^(?:docs|\.github|\.tekton)(?:/|$)Summary by CodeRabbit
This PR adds skip guards to the ROSA (Red Hat OpenShift on AWS) CI job configuration in the openshift/release repository. The changes prevent ROSA presubmit jobs from running unnecessarily when a PR only modifies automation-related files.
What's changing
Five ROSA presubmit jobs (
lint,build,test,commits, andcoverage) now include askip_if_only_changedcondition that skips execution when the PR only touches:LICENSE,OWNERS,README.md,.gitignore,renovate.json,.ci-operator.yaml.tekton/,.github/, ordocs/Practical impact
This prevents CI from spinning up expensive job runs when contributors are updating automation files, documentation, or configuration that doesn't affect the actual ROSA build or test logic. This aligns with equivalent automation in the openshift/rosa repository itself (which auto-merges such changes) and follows a precedent set by other provider configurations.
Files modified
The changes span the ROSA job configuration files in
ci-operator/config/openshift/rosa/:openshift-rosa-master.yaml— adds skip conditions to the main presubmit testsopenshift-rosa-master__e2e-presubmits.yaml— adds skip to e2e image buildopenshift-rosa-master__images.yaml— adds skip to image buildopenshift-rosa-master__images-release.yaml— adds skip to release image buildopenshift-rosa-master-presubmits.yaml— regenerated viamake jobsto sync the generated Prow job definitions