NO-ISSUE: Degraded TNF lane should be ran against CONFORMANCE tests#78017
NO-ISSUE: Degraded TNF lane should be ran against CONFORMANCE tests#78017Neilhamza wants to merge 2 commits intoopenshift:mainfrom
Conversation
Signed-off-by: nhamza <nhamza@redhat.com>
openshift-ci-robot
added
the
jira/valid-reference
|
@Neilhamza: This pull request explicitly references no jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
WalkthroughRemoved the workflow-level Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~5 minutes 🚥 Pre-merge checks | ✅ 10✅ Passed checks (10 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
/pj-rehearse periodic-ci-openshift-release-main-nightly-4.22-e2e-metal-ovn-two-node-fencing-degraded |
|
@Neilhamza: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse periodic-ci-openshift-release-main-nightly-4.21-e2e-metal-ovn-two-node-fencing-degraded |
|
@Neilhamza: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse periodic-ci-openshift-release-main-nightly-4.23-e2e-metal-ovn-two-node-fencing-degraded |
|
@Neilhamza: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse periodic-ci-openshift-release-main-nightly-4.22-e2e-metal-ovn-two-node-fencing-ipv6-degraded |
|
@Neilhamza: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse periodic-ci-openshift-release-main-nightly-4.22-e2e-metal-ovn-two-node-fencing-dualstack-degraded |
|
@Neilhamza: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
@Neilhamza: job(s): periodic-ci-openshift-release-main-nightly-4.21-e2e-metal-ovn-two-node-fencing-degraded either don't exist or were not found to be affected, and cannot be rehearsed |
Signed-off-by: nhamza <nhamza@redhat.com>
|
/pj-rehearse periodic-ci-openshift-release-main-nightly-4.22-e2e-metal-ovn-two-node-fencing-degraded |
|
@Neilhamza: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse periodic-ci-openshift-release-main-nightly-4.23-e2e-metal-ovn-two-node-fencing-degraded |
|
@Neilhamza: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse periodic-ci-openshift-release-main-nightly-4.22-e2e-metal-ovn-two-node-fencing-ipv6-degraded |
|
@Neilhamza: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse periodic-ci-openshift-release-main-nightly-4.22-e2e-metal-ovn-two-node-fencing-dualstack-degraded |
|
@Neilhamza: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
[REHEARSALNOTIFIER]
Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In
`@ci-operator/step-registry/baremetalds/two-node/fencing/degraded/baremetalds-two-node-fencing-degraded-workflow.yaml`:
- Line 104: The skip regex contains an unnecessary escape before "cluster" in
the token "\|\cluster-version-operator"; locate the string used for skipping
(the regex containing "Prometheus .* ... OOM score adjustment ...
\|\cluster-version-operator") and remove the stray backslash so it becomes
"\|cluster-version-operator", ensuring the alternation is correct and portable.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: e4ef6c7f-16b2-4aff-a57b-0867bb441a46
📒 Files selected for processing (1)
ci-operator/step-registry/baremetalds/two-node/fencing/degraded/baremetalds-two-node-fencing-degraded-workflow.yaml
| must-gather run the must-gather command with own name space\|\[sig-instrumentation] | ||
| Prometheus .* should start and expose a secured proxy and unsecured metrics\|\[Disruptive\]\|OOM score adjustment set to -997 | ||
| TEST_SUITE: openshift/two-node | ||
| Prometheus .* should start and expose a secured proxy and unsecured metrics\|\[Disruptive\]\|OOM score adjustment set to -997\|\cluster-version-operator should have correct runlevel and scc |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
cd ci-operator/step-registry/baremetalds/two-node/fencing/degraded && \
head -n 110 baremetalds-two-node-fencing-degraded-workflow.yaml | tail -n 20Repository: openshift/release
Length of output: 1992
🏁 Script executed:
# Find references to this file and how the pattern is processed
rg -l "baremetalds-two-node-fencing-degraded" --max-count=5Repository: openshift/release
Length of output: 537
🏁 Script executed:
# Search for similar test skip patterns to understand the regex convention
rg '\\\|\[' --type yaml -A 1 -B 1 | head -40Repository: openshift/release
Length of output: 43
🏁 Script executed:
# Check the full test skip pattern section to understand context
sed -n '90,110p' ci-operator/step-registry/baremetalds/two-node/fencing/degraded/baremetalds-two-node-fencing-degraded-workflow.yamlRepository: openshift/release
Length of output: 1805
🏁 Script executed:
# Search for other instances of backslash-letter sequences in the file
rg '\\\[a-z]' ci-operator/step-registry/baremetalds/two-node/fencing/degraded/baremetalds-two-node-fencing-degraded-workflow.yamlRepository: openshift/release
Length of output: 43
🏁 Script executed:
# Search for backslash-c pattern more directly
rg '\\c' ci-operator/step-registry/baremetalds/two-node/fencing/degraded/baremetalds-two-node-fencing-degraded-workflow.yamlRepository: openshift/release
Length of output: 258
🏁 Script executed:
# Also check for the specific line with the issue to confirm the exact content
rg 'cluster-version-operator' ci-operator/step-registry/baremetalds/two-node/fencing/degraded/baremetalds-two-node-fencing-degraded-workflow.yamlRepository: openshift/release
Length of output: 258
Remove the unnecessary backslash before cluster in the skip regex.
Line 104 contains \|\cluster-version-operator, where the backslash before cluster is a stray escape that serves no purpose in regex alternation. Change to \|cluster-version-operator for better clarity and portability.
Proposed fix
- Prometheus .* should start and expose a secured proxy and unsecured metrics\|\[Disruptive\]\|OOM score adjustment set to -997\|\cluster-version-operator should have correct runlevel and scc
+ Prometheus .* should start and expose a secured proxy and unsecured metrics\|\[Disruptive\]\|OOM score adjustment set to -997\|cluster-version-operator should have correct runlevel and scc📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| Prometheus .* should start and expose a secured proxy and unsecured metrics\|\[Disruptive\]\|OOM score adjustment set to -997\|\cluster-version-operator should have correct runlevel and scc | |
| Prometheus .* should start and expose a secured proxy and unsecured metrics\|\[Disruptive\]\|OOM score adjustment set to -997\|cluster-version-operator should have correct runlevel and scc |
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In
`@ci-operator/step-registry/baremetalds/two-node/fencing/degraded/baremetalds-two-node-fencing-degraded-workflow.yaml`
at line 104, The skip regex contains an unnecessary escape before "cluster" in
the token "\|\cluster-version-operator"; locate the string used for skipping
(the regex containing "Prometheus .* ... OOM score adjustment ...
\|\cluster-version-operator") and remove the stray backslash so it becomes
"\|cluster-version-operator", ensuring the alternation is correct and portable.
jaypoulz
left a comment
jaypoulz
left a comment
There was a problem hiding this comment.
/lgtm
Let's make sure the -tn- degraded lanes still run the two-node suite, but otherwise looks good to me
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jaypoulz, Neilhamza The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
|
@Neilhamza: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
3 participants
the modified workflow should target conformance (default) test suite and not two-node suite
Summary by CodeRabbit
Chores
Documentation