Skip to content

NO-ISSUE: Degraded TNF lane should be ran against CONFORMANCE tests #78017

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Neilhamza wants to merge 2 commits into
base: main
Choose a base branch
from
+2 −3
Open

NO-ISSUE: Degraded TNF lane should be ran against CONFORMANCE tests #78017

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d315f1c
remove two-node Suite
Neilhamza Apr 20, 2026
6a64c37
add another test skip
Neilhamza Apr 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions ...baremetalds/two-node/fencing/degraded/baremetalds-two-node-fencing-degraded-workflow.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,8 +101,7 @@ workflow:
when running the oc adm must-gather command timeout\|\[sig-cli\] oc adm must-gather
must-gather support since and since-time flags timeout\|\[sig-cli\] oc adm
must-gather run the must-gather command with own name space\|\[sig-instrumentation]
Prometheus .* should start and expose a secured proxy and unsecured metrics\|\[Disruptive\]\|OOM score adjustment set to -997
TEST_SUITE: openshift/two-node
Prometheus .* should start and expose a secured proxy and unsecured metrics\|\[Disruptive\]\|OOM score adjustment set to -997\|\cluster-version-operator should have correct runlevel and scc
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot Apr 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

🧩 Analysis chain

🏁 Script executed:

cd ci-operator/step-registry/baremetalds/two-node/fencing/degraded && \
head -n 110 baremetalds-two-node-fencing-degraded-workflow.yaml | tail -n 20

Repository: openshift/release

Length of output: 1992

🏁 Script executed:

# Find references to this file and how the pattern is processed
rg -l "baremetalds-two-node-fencing-degraded" --max-count=5

Repository: openshift/release

Length of output: 537

🏁 Script executed:

# Search for similar test skip patterns to understand the regex convention
rg '\\\|\[' --type yaml -A 1 -B 1 | head -40

Repository: openshift/release

Length of output: 43

🏁 Script executed:

# Check the full test skip pattern section to understand context
sed -n '90,110p' ci-operator/step-registry/baremetalds/two-node/fencing/degraded/baremetalds-two-node-fencing-degraded-workflow.yaml

Repository: openshift/release

Length of output: 1805

🏁 Script executed:

# Search for other instances of backslash-letter sequences in the file
rg '\\\[a-z]' ci-operator/step-registry/baremetalds/two-node/fencing/degraded/baremetalds-two-node-fencing-degraded-workflow.yaml

Repository: openshift/release

Length of output: 43

🏁 Script executed:

# Search for backslash-c pattern more directly
rg '\\c' ci-operator/step-registry/baremetalds/two-node/fencing/degraded/baremetalds-two-node-fencing-degraded-workflow.yaml

Repository: openshift/release

Length of output: 258

🏁 Script executed:

# Also check for the specific line with the issue to confirm the exact content
rg 'cluster-version-operator' ci-operator/step-registry/baremetalds/two-node/fencing/degraded/baremetalds-two-node-fencing-degraded-workflow.yaml

Repository: openshift/release

Length of output: 258

Remove the unnecessary backslash before cluster in the skip regex.

Line 104 contains \|\cluster-version-operator, where the backslash before cluster is a stray escape that serves no purpose in regex alternation. Change to \|cluster-version-operator for better clarity and portability.

Proposed fix 
-        Prometheus .* should start and expose a secured proxy and unsecured metrics\|\[Disruptive\]\|OOM score adjustment set to -997\|\cluster-version-operator should have correct runlevel and scc
+        Prometheus .* should start and expose a secured proxy and unsecured metrics\|\[Disruptive\]\|OOM score adjustment set to -997\|cluster-version-operator should have correct runlevel and scc
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
Prometheus .* should start and expose a secured proxy and unsecured metrics\|\[Disruptive\]\|OOM score adjustment set to -997\|\cluster-version-operator should have correct runlevel and scc
Prometheus .* should start and expose a secured proxy and unsecured metrics\|\[Disruptive\]\|OOM score adjustment set to -997\|cluster-version-operator should have correct runlevel and scc
🤖 Prompt for AI Agents 
Verify each finding against the current code and only fix it if needed.

In
`@ci-operator/step-registry/baremetalds/two-node/fencing/degraded/baremetalds-two-node-fencing-degraded-workflow.yaml`
at line 104, The skip regex contains an unnecessary escape before "cluster" in
the token "\|\cluster-version-operator"; locate the string used for skipping
(the regex containing "Prometheus .* ... OOM score adjustment ...
\|\cluster-version-operator") and remove the stray backslash so it becomes
"\|cluster-version-operator", ensuring the alternation is correct and portable.

ENABLE_HYPERVISOR_SSH_CONFIG: "true"
documentation: |-
This workflow executes a Two Node OpenShift with Fencing (TNF) cluster installation with degraded fencing.
This workflow executes a Degraded (one node intentionally down) Two Node OpenShift with Fencing (TNF) cluster installation and running across unskipped CONFORMANCE tests.