Skip to content

onboarding stolostron/multicluster-mesh-addon#78463

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
mkolesnik:ocm-add-multicluster-mesh-addon
May 20, 2026
Merged

onboarding stolostron/multicluster-mesh-addon#78463
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
mkolesnik:ocm-add-multicluster-mesh-addon

Conversation

@mkolesnik
Copy link
Copy Markdown
Contributor

@mkolesnik mkolesnik commented Apr 28, 2026

Add CI configuration for multicluster-mesh-addon with verify, unit, integration, linting, and SonarCloud tests.

Summary by CodeRabbit

  • Chores
    • Added repository ownership entries defining reviewers and approvers.
    • Added CI configuration enabling build, verify, unit/integration tests, linting, and SonarCloud scans for main branch.
    • Added Prow plugin config and repo-specific Tide setting to control approvals, LGTM behavior, DCO enforcement, and rebase merges.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 28, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 6a324921-ea0c-4b0f-b8b9-cab99c67fc3d

📥 Commits

Reviewing files that changed from the base of the PR and between 0f647c0 and 044e973.

📒 Files selected for processing (2)
  • ci-operator/config/stolostron/multicluster-mesh-addon/OWNERS
  • ci-operator/config/stolostron/multicluster-mesh-addon/stolostron-multicluster-mesh-addon-main.yaml
🚧 Files skipped from review as they are similar to previous changes (2)
  • ci-operator/config/stolostron/multicluster-mesh-addon/OWNERS
  • ci-operator/config/stolostron/multicluster-mesh-addon/stolostron-multicluster-mesh-addon-main.yaml

Walkthrough

Adds CI pipeline and Prow repository governance for stolostron/multicluster-mesh-addon: owner lists, ci-operator job for main branch with build/test/lint/SonarCloud steps, and Prow plugin and Tide merge settings.

Changes

Cohort / File(s) Summary
OWNERS files
ci-operator/config/stolostron/multicluster-mesh-addon/OWNERS, core-services/prow/02_config/stolostron/multicluster-mesh-addon/OWNERS
Adds repository owner metadata listing the same reviewers and approvers.
CI pipeline (ci-operator)
ci-operator/config/stolostron/multicluster-mesh-addon/stolostron-multicluster-mesh-addon-main.yaml
Introduces a new ci-operator job for main: Go 1.25 build, verify, unit/integration tests, golangci-lint, SonarCloud pre/post-submit steps, resource requests/limits, and skip_if_only_changed rules.
Prow config snippets
core-services/prow/02_config/stolostron/multicluster-mesh-addon/_pluginconfig.yaml, core-services/prow/02_config/stolostron/multicluster-mesh-addon/_prowconfig.yaml
Adds plugin config (approve with require_self_approval: false, lgtm review_acts_as_lgtm: true, enables dco) and sets Tide merge method to rebase for the repo.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

🚥 Pre-merge checks | ✅ 12
✅ Passed checks (12 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main objective: onboarding a new repository (stolostron/multicluster-mesh-addon) with CI configuration and supporting files.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed The custom check for 'Stable and Deterministic Test Names' is not applicable to this PR. The PR exclusively adds CI/CD operational configuration files (OWNERS files, Prow configurations, and CI operator YAML) for the stolostron/multicluster-mesh-addon repository. None of the modified files contain Ginkgo test definitions.
Test Structure And Quality ✅ Passed This PR contains only CI/CD configuration files (YAML and OWNERS files) for onboarding the multicluster-mesh-addon project. No Ginkgo test code or test implementation files are present in the changes.
Microshift Test Compatibility ✅ Passed This PR does not add any Ginkgo e2e test code. The files added are purely configuration files: CI operator YAML configuration, Prow job definitions, Prow plugin configuration, and OWNERS files. None contain Ginkgo test definitions.
Single Node Openshift (Sno) Test Compatibility ✅ Passed Pull request only adds CI configuration files and OWNERS files, not Ginkgo e2e test code.
Topology-Aware Scheduling Compatibility ✅ Passed PR adds CI/CD configuration and governance files without deployment manifests, operator code, or controllers; does not fall within custom check scope.
Ote Binary Stdout Contract ✅ Passed PR adds only CI/CD configuration files to openshift/release; no source code or executable code present, so OTE Binary Stdout Contract check is not applicable.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed PR adds CI/CD configuration files only; no Ginkgo e2e test code with IPv4 assumptions or external connectivity issues present.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
Review rate limit: 0/1 reviews remaining, refill in 60 minutes.

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci Bot requested review from MacdonEm and smithbw88 April 28, 2026 10:26
@openshift-ci openshift-ci Bot added the do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. label Apr 28, 2026
@mkolesnik mkolesnik force-pushed the ocm-add-multicluster-mesh-addon branch 2 times, most recently from 044e973 to 129a90d Compare April 30, 2026 09:41
Add CI configuration for multicluster-mesh-addon with verify, unit,
integration, linting, and SonarCloud tests.

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
@mkolesnik mkolesnik force-pushed the ocm-add-multicluster-mesh-addon branch from 129a90d to a8142a7 Compare May 10, 2026 07:39
@openshift-ci openshift-ci Bot removed the do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. label May 10, 2026
@openshift-merge-bot
Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@mkolesnik: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-stolostron-multicluster-mesh-addon-main-golangci-lint stolostron/multicluster-mesh-addon presubmit Presubmit changed
pull-ci-stolostron-multicluster-mesh-addon-main-integration stolostron/multicluster-mesh-addon presubmit Presubmit changed
pull-ci-stolostron-multicluster-mesh-addon-main-sonar-pre-submit stolostron/multicluster-mesh-addon presubmit Presubmit changed
pull-ci-stolostron-multicluster-mesh-addon-main-unit stolostron/multicluster-mesh-addon presubmit Presubmit changed
pull-ci-stolostron-multicluster-mesh-addon-main-verify stolostron/multicluster-mesh-addon presubmit Presubmit changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label May 19, 2026
Copy link
Copy Markdown

@smithbw88 smithbw88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 19, 2026
Copy link
Copy Markdown
Contributor

@mark-nc mark-nc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Copy Markdown

@MacdonEm MacdonEm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 19, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gparvin, MacdonEm, mark-nc, mkolesnik, smithbw88

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mkolesnik
Copy link
Copy Markdown
Contributor Author

/pj-rehearse skip

@openshift-merge-bot
Copy link
Copy Markdown
Contributor

@mkolesnik: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-merge-bot openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label May 20, 2026
@openshift-merge-bot
Copy link
Copy Markdown
Contributor

@mkolesnik: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 20, 2026

@mkolesnik: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot Bot merged commit 49ee15c into openshift:main May 20, 2026
20 checks passed
wgahnagl pushed a commit to wgahnagl/release that referenced this pull request May 20, 2026
Add CI configuration for multicluster-mesh-addon with verify, unit,
integration, linting, and SonarCloud tests.

Co-authored-by: Claude Sonnet 4.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants