Skip to content

multicluster-mesh-addon: Mark pre submit sonar job as optional for now#79510

Merged
openshift-merge-bot[bot] merged 2 commits into
openshift:mainfrom
FilipB:optional-sonar
May 20, 2026
Merged

multicluster-mesh-addon: Mark pre submit sonar job as optional for now#79510
openshift-merge-bot[bot] merged 2 commits into
openshift:mainfrom
FilipB:optional-sonar

Conversation

@FilipB
Copy link
Copy Markdown
Contributor

@FilipB FilipB commented May 20, 2026

TODO: stolostron/multicluster-mesh-addon#78

Summary

This PR updates the OpenShift CI configuration for the stolostron/multicluster-mesh-addon repository to make the sonar pre-submit code-quality test non-blocking by marking the sonar-pre-submit test as optional.

Changes Made

  • The CI test entry for the pre-submit SonarCloud analysis (sonar-pre-submit) in ci-operator config for stolostron/multicluster-mesh-addon now includes optional: true. The post-submit SonarCloud scan (sonar-post-submit) remains a postsubmit job and is unchanged.

Practical Impact

  • Pre-submit SonarCloud failures will no longer block PR merges; PR authors can merge even if the sonar pre-submit check fails.
  • Post-merge scanning still runs to detect issues on main.
  • This acts as a temporary workaround while the linked upstream issue is addressed.

File Modified

  • ci-operator/config/stolostron/multicluster-mesh-addon/stolostron-multicluster-mesh-addon-main.yaml

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 20, 2026
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 20, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: b103d6c4-ec88-4675-aa6c-d44b1a467760

📥 Commits

Reviewing files that changed from the base of the PR and between 618d976 and 6b5c17d.

📒 Files selected for processing (1)
  • ci-operator/config/stolostron/multicluster-mesh-addon/stolostron-multicluster-mesh-addon-main.yaml

Walkthrough

A single line in the multicluster-mesh-addon CI configuration is updated to mark the sonar-pre-submit test step as optional, enabling the CI harness to skip this step when needed.

Changes

CI Configuration

Layer / File(s) Summary
Make sonar-pre-submit optional
ci-operator/config/stolostron/multicluster-mesh-addon/stolostron-multicluster-mesh-addon-main.yaml
The sonar-pre-submit test step is updated to include optional: true, allowing the CI harness to conditionally skip this step.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

  • openshift/release#78463: Directly related CI configuration change for the same stolostron-multicluster-mesh-addon-main.yaml SonarCloud pre-submit prow harness setup.

Suggested reviewers

  • smithbw88
🚥 Pre-merge checks | ✅ 12
✅ Passed checks (12 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: marking a sonar pre-submit job as optional in the multicluster-mesh-addon CI configuration.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed PR modifies only a CI configuration file (YAML), not Ginkgo test code. No test names or test titles are changed, making the check not applicable.
Test Structure And Quality ✅ Passed PR only modifies CI config YAML (adding optional: true to sonar-pre-submit), not Ginkgo test code. Custom check for test structure is not applicable to this change.
Microshift Test Compatibility ✅ Passed PR is not applicable to this check: it only modifies CI configuration (marking sonar-pre-submit as optional), not Ginkgo e2e test code.
Single Node Openshift (Sno) Test Compatibility ✅ Passed No new Ginkgo e2e tests added. This PR only modifies CI YAML config to mark sonar-pre-submit as optional. The check does not apply.
Topology-Aware Scheduling Compatibility ✅ Passed PR modifies only a CI operator configuration file to mark a test optional. No deployment manifests, operator code, or controllers are introduced.
Ote Binary Stdout Contract ✅ Passed PR only modifies CI config YAML to mark sonar test optional; no Go code changes that could violate OTE stdout contract.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed This PR only modifies CI configuration YAML files (ci-operator configs and Prow jobs), not test code. No new Ginkgo e2e tests are added, so the check does not apply.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci Bot requested review from mkolesnik and sridhargaddam May 20, 2026 09:02
@FilipB
Copy link
Copy Markdown
Contributor Author

FilipB commented May 20, 2026

/pj-rehearse ack

@openshift-merge-bot
Copy link
Copy Markdown
Contributor

@FilipB: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-merge-bot openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label May 20, 2026
@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label May 20, 2026
@FilipB
Copy link
Copy Markdown
Contributor Author

FilipB commented May 20, 2026

/retest

@openshift-ci openshift-ci Bot removed the lgtm Indicates that a PR is ready to be merged. label May 20, 2026
@openshift-merge-bot openshift-merge-bot Bot removed the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label May 20, 2026
@openshift-merge-bot
Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@FilipB: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-stolostron-multicluster-mesh-addon-main-sonar-pre-submit stolostron/multicluster-mesh-addon presubmit Ci-operator config changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@FilipB
Copy link
Copy Markdown
Contributor Author

FilipB commented May 20, 2026

/pj-rehearse ack

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label May 20, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 20, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: FilipB, sridhargaddam

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot
Copy link
Copy Markdown
Contributor

@FilipB: your /pj-rehearse request was not processed because the request waited in queue for longer than 5 minutes. Please retry in a few minutes.

@mkolesnik
Copy link
Copy Markdown
Contributor

/pj-rehearse ack

@openshift-merge-bot
Copy link
Copy Markdown
Contributor

@mkolesnik: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-merge-bot openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label May 20, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 20, 2026

@FilipB: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot Bot merged commit 70f74fc into openshift:main May 20, 2026
16 checks passed
@FilipB FilipB deleted the optional-sonar branch May 20, 2026 11:25
wgahnagl pushed a commit to wgahnagl/release that referenced this pull request May 20, 2026
openshift#79510)

* multicluster-mesh-addon: Mark pre submit sonar job as optional for now

TODO: stolostron/multicluster-mesh-addon#78

* Run make ci-operator-config
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants