Skip to content

WINC-1456: updates go version to 1.25 for windows-exporter master#79728

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
wgahnagl:WINC-1456
May 27, 2026
Merged

WINC-1456: updates go version to 1.25 for windows-exporter master#79728
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
wgahnagl:WINC-1456

Conversation

@wgahnagl
Copy link
Copy Markdown
Contributor

@wgahnagl wgahnagl commented May 26, 2026

This changes the master to windows-exporter 4.22 and upgrades to golang 1.25

Summary by CodeRabbit

This PR updates the OpenShift CI build configuration for the prometheus-community-windows_exporter repository's master branch to use Go 1.25 and the corresponding OCp 5.0 builder images.

What changed in practical terms:

  • CI build base image reference switched to ocp namespace, base name "5.0".
  • Builder image moved from the prior golang 1.24 / OpenShift 4.21 line to ocp_builder_rhel-9-golang-1.25-openshift-5.0 (tag: rhel-9-golang-1.25-openshift-5.0).
  • build_root.image_stream_tag updated to use the new builder tag (rhel-9-golang-1.25-openshift-5.0).
  • The test/build steps remain focused on building the Windows exporter (using promu, GOOS=windows), but will now run in the Go 1.25 / RHEL-9 builder environment.

Scope: Affects only the OpenShift CI configuration for the prometheus-community-windows_exporter master job so subsequent CI builds will use Go 1.25 and the updated ocp/5.0 builder images.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 26, 2026
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented May 26, 2026

@wgahnagl: This pull request references WINC-1456 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target either version "5.0." or "openshift-5.0.", but it targets "WMCO 10.19.0" instead.

Details

In response to this:

This changes the master to windows-exporter 4.22 and upgrades to golang 1.25

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 26, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: a0168825-dd6f-4104-bce2-f203599433df

📥 Commits

Reviewing files that changed from the base of the PR and between d8ca66a and fa1d640.

📒 Files selected for processing (1)
  • ci-operator/config/openshift/prometheus-community-windows_exporter/openshift-prometheus-community-windows_exporter-master.yaml

Walkthrough

Updates the OpenShift CI job for the Windows exporter: set base image stream name: "5.0", change builder to ocp_builder_rhel-9-golang-1.25-openshift-5.0, and align build_root.image_stream_tag to the new rhel-9 golang-1.25 tag.

Changes

OpenShift Windows exporter CI config

Layer / File(s) Summary
Builder and base image tag update
ci-operator/config/openshift/prometheus-community-windows_exporter/openshift-prometheus-community-windows_exporter-master.yaml
Changed base image stream name to 5.0, replaced builder image stream/tag from ocp_builder_rhel-9-golang-1.24-openshift-4.21 to ocp_builder_rhel-9-golang-1.25-openshift-5.0, and updated build_root.image_stream_tag accordingly.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested labels

lgtm, rehearsals-ack

Suggested reviewers

  • eranco74
🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately reflects the main change in the PR, which updates the Go version from 1.24 to 1.25 for the windows-exporter master branch configuration.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed PR modifies only OpenShift CI configuration YAML files, not Ginkgo tests. Repository contains no Ginkgo test code; check is not applicable.
Test Structure And Quality ✅ Passed PR contains configuration files and Go utilities only; no Ginkgo test code is present to review against the test quality requirements.
Microshift Test Compatibility ✅ Passed PR does not add any Ginkgo e2e tests; it only modifies CI build configuration YAML files to update Go version from 1.24 to 1.25 for windows-exporter.
Single Node Openshift (Sno) Test Compatibility ✅ Passed This PR modifies only OpenShift CI build configuration (YAML file) to update Go version and image streams; it does not add any new Ginkgo e2e tests, so SNO compatibility check is not applicable.
Topology-Aware Scheduling Compatibility ✅ Passed This PR modifies a CI-operator build configuration file, not a deployment manifest, operator code, or controller. It contains no scheduling constraints and is therefore not subject to this check.
Ote Binary Stdout Contract ✅ Passed PR only modifies CI/CD YAML configuration file for golang version upgrade; no code changes, no process-level stdout writes, OTE binary check not applicable.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed PR only modifies a CI build configuration YAML file to update Go version from 1.24 to 1.25. No new Ginkgo e2e tests are added, so the check is not applicable.
No-Weak-Crypto ✅ Passed PR adds only OpenShift CI configuration YAML files. No source code, weak crypto (MD5/SHA1/DES/RC4/3DES/Blowfish/ECB), custom crypto, or insecure comparisons detected.
Container-Privileges ✅ Passed File is an OpenShift CI build config with no container privilege settings (privileged, hostPID/Network/IPC, SYS_ADMIN, allowPrivilegeEscalation, root execution).
No-Sensitive-Data-In-Logs ✅ Passed File contains no logging statements, sensitive data, passwords, tokens, API keys, PII, or internal hostnames. Commands use public GitHub URLs only.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci Bot requested review from jrvaldes and sebsoto May 26, 2026 19:33
@wgahnagl
Copy link
Copy Markdown
Contributor Author

/retest-required

@wgahnagl
Copy link
Copy Markdown
Contributor Author

/pj-rehearse

@openshift-merge-bot
Copy link
Copy Markdown
Contributor

@wgahnagl: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

base_images:
base:
name: "4.21"
name: "4.22"
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

master is no longer tracking 4.22, it is tracking 5.0

@openshift-merge-bot
Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@wgahnagl: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-prometheus-community-windows_exporter-master-build openshift/prometheus-community-windows_exporter presubmit Ci-operator config changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

2 similar comments
@openshift-merge-bot
Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@wgahnagl: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-prometheus-community-windows_exporter-master-build openshift/prometheus-community-windows_exporter presubmit Ci-operator config changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-merge-bot
Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@wgahnagl: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-prometheus-community-windows_exporter-master-build openshift/prometheus-community-windows_exporter presubmit Ci-operator config changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@jrvaldes
Copy link
Copy Markdown
Contributor

This changes the master to windows-exporter 4.22 and upgrades to golang 1.25

@wgahnagl PR description needs an update

@jrvaldes
Copy link
Copy Markdown
Contributor

/pj-rehearse auto-ack

@openshift-merge-bot
Copy link
Copy Markdown
Contributor

@jrvaldes: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-merge-bot openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label May 27, 2026
@jrvaldes
Copy link
Copy Markdown
Contributor

/retest

@jrvaldes
Copy link
Copy Markdown
Contributor

/approve

@jrvaldes
Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label May 27, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 27, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jrvaldes, wgahnagl

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 27, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jrvaldes, wgahnagl

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 27, 2026
@openshift-merge-bot
Copy link
Copy Markdown
Contributor

@openshift-ci[bot]: your /pj-rehearse request was not processed because the request waited in queue for longer than 5 minutes. Please retry in a few minutes.

@jrvaldes
Copy link
Copy Markdown
Contributor

/retest-required

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 27, 2026

@wgahnagl: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot Bot merged commit c440dca into openshift:main May 27, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants