WINC-1456: updates go version to 1.25 for windows-exporter master#79728
Conversation
|
@wgahnagl: This pull request references WINC-1456 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target either version "5.0." or "openshift-5.0.", but it targets "WMCO 10.19.0" instead. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
WalkthroughUpdates the OpenShift CI job for the Windows exporter: set ChangesOpenShift Windows exporter CI config
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
/retest-required |
|
/pj-rehearse |
|
@wgahnagl: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
| base_images: | ||
| base: | ||
| name: "4.21" | ||
| name: "4.22" |
There was a problem hiding this comment.
master is no longer tracking 4.22, it is tracking 5.0
|
[REHEARSALNOTIFIER]
Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
2 similar comments
|
[REHEARSALNOTIFIER]
Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
[REHEARSALNOTIFIER]
Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
@wgahnagl PR description needs an update |
|
/pj-rehearse auto-ack |
|
@jrvaldes: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/retest |
|
/approve |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jrvaldes, wgahnagl The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
1 similar comment
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jrvaldes, wgahnagl The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@openshift-ci[bot]: your |
|
/retest-required |
|
@wgahnagl: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
This changes the master to windows-exporter 4.22 and upgrades to golang 1.25
Summary by CodeRabbit
This PR updates the OpenShift CI build configuration for the prometheus-community-windows_exporter repository's master branch to use Go 1.25 and the corresponding OCp 5.0 builder images.
What changed in practical terms:
Scope: Affects only the OpenShift CI configuration for the prometheus-community-windows_exporter master job so subsequent CI builds will use Go 1.25 and the updated ocp/5.0 builder images.