Skip to content

OSAC-360: Update Go version in osac-project installer config#79754

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
adriengentil:patch-9
May 27, 2026
Merged

OSAC-360: Update Go version in osac-project installer config#79754
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
adriengentil:patch-9

Conversation

@adriengentil
Copy link
Copy Markdown
Contributor

@adriengentil adriengentil commented May 27, 2026

Summary by CodeRabbit

This PR updates the Go compiler version used in the OSAC Installer's CI pipeline. Specifically, it modifies the osac-project-osac-installer CI configuration to use a newer OpenShift build root image: the builder image is upgraded from Go 1.25 with OpenShift 4.21 (rhel-9-release-golang-1.25-openshift-4.21) to Go 1.26 with OpenShift 5.0 (rhel-9-release-golang-1.26-openshift-5.0).

This change affects the build environment for all OSAC Installer CI jobs (presubmits, postsubmits, and periodics), ensuring the project builds and tests against the newer Go version and OpenShift runtime.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 27, 2026
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented May 27, 2026

@adriengentil: This pull request references OSAC-360 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "5.0.0" version, but no target version was set.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 27, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: ad360090-6674-4629-a723-cf3466ff22a4

📥 Commits

Reviewing files that changed from the base of the PR and between a3a41a9 and b73da73.

📒 Files selected for processing (1)
  • ci-operator/config/osac-project/osac-installer/osac-project-osac-installer-main.yaml

Walkthrough

This pull request updates the OpenShift CI operator build configuration for the osac-installer project, changing the build_root image stream tag from the Go 1.25/OpenShift 4.21 builder to the Go 1.26/OpenShift 5.0 builder in the main branch pipeline configuration.

Changes

Build Image Configuration Update

Layer / File(s) Summary
build_root image version upgrade
ci-operator/config/osac-project/osac-installer/osac-project-osac-installer-main.yaml
The build_root image stream tag is updated to use the RHEL 9 + Go 1.26 + OpenShift 5.0 builder image, replacing the previous Go 1.25 + OpenShift 4.21 tag on line 21.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

  • openshift/release#79736: Updates the same rhel-9-release-golang-1.26-openshift-5.0 builder image tag for a different build configuration.
  • openshift/release#79717: Upgrades the same Go 1.25/OCP 4.21 to Go 1.26/OCP 5.0 builder image in a different installer configuration YAML.

Suggested labels

lgtm, rehearsals-ack

Suggested reviewers

  • jkhelil
  • avinal
🚥 Pre-merge checks | ✅ 12
✅ Passed checks (12 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and specifically describes the main change: updating the Go version in the osac-project installer configuration, which matches the file modification shown in the raw summary.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed This PR modifies only CI configuration YAML (updating build_root image tags), not Ginkgo test code. The test name stability check is not applicable.
Test Structure And Quality ✅ Passed PR modifies only a CI configuration YAML file and adds no Ginkgo test code; the check for Ginkgo test quality is not applicable to this PR.
Microshift Test Compatibility ✅ Passed PR only updates CI operator build config (Go/OpenShift version), no Ginkgo e2e tests added; MicroShift compatibility check not applicable.
Single Node Openshift (Sno) Test Compatibility ✅ Passed No new Ginkgo e2e tests are added. PR only updates build config YAML, changing Go build image tag. SNO compatibility check not applicable.
Topology-Aware Scheduling Compatibility ✅ Passed PR modifies only a CI build configuration file (build_root image tag update), not deployment manifests, operators, or controllers. No scheduling constraints are introduced.
Ote Binary Stdout Contract ✅ Passed PR changes only a YAML CI configuration file (updating a build image tag), not application code. The OTE Binary Stdout Contract check is inapplicable to configuration-only changes.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed PR only modifies a CI build configuration YAML file (updating Go version), not Ginkgo e2e tests. Check is not applicable.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 27, 2026
@adriengentil
Copy link
Copy Markdown
Contributor Author

/cc @omer-vishlitzky

@adriengentil
Copy link
Copy Markdown
Contributor Author

/pj-rehearse

@openshift-merge-bot
Copy link
Copy Markdown
Contributor

@adriengentil: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-merge-bot
Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@adriengentil: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-osac-project-osac-installer-main-e2e-vmaas osac-project/osac-installer presubmit Ci-operator config changed
pull-ci-osac-project-osac-installer-main-images osac-project/osac-installer presubmit Ci-operator config changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@omer-vishlitzky
Copy link
Copy Markdown
Contributor

/lgtm
/approve

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label May 27, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 27, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adriengentil, omer-vishlitzky

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@adriengentil
Copy link
Copy Markdown
Contributor Author

/pj-rehearse ack

@openshift-merge-bot
Copy link
Copy Markdown
Contributor

@adriengentil: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-merge-bot openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label May 27, 2026
@openshift-merge-bot openshift-merge-bot Bot merged commit 33e14bd into openshift:main May 27, 2026
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants