WINC-1938: [wmco] Add tls scanner job#79785
Conversation
|
@mansikulkarni96: This pull request references WINC-1938 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "5.0.0" version, but no target version was set. DetailsIn response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci-robot
added
the
jira/valid-reference
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
WalkthroughAdds a ChangesCI Configuration: base image + test job
🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs:
Suggested labels: Suggested reviewers:
Important Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional. ❌ Failed checks (1 error)
✅ Passed checks (14 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
openshift-ci
Bot
added
the
approved
|
/pj-rehearse pull-ci-openshift-windows-machine-config-operator-master-tls-scanner |
|
@mansikulkarni96: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
Actionable comments posted: 0 |
mansikulkarni96
force-pushed
the
tls_scanner
branch
from
b8bbb82 to
61952c0
Compare
|
/pj-rehearse pull-ci-openshift-windows-machine-config-operator-master-tls-scanner |
|
@mansikulkarni96: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@ci-operator/config/openshift/windows-machine-config-operator/openshift-windows-machine-config-operator-master.yaml`:
- Around line 392-404: This change adds a new optional test job (as:
tls-scanner) with refs openshift-windows-install-wmco and tls-scanner-run and
workflow ipi-aws-ovn-hybrid; run make update from the repository root to
regenerate the ProwJob specs under ci-operator/jobs/, commit the updated
generated YAMLs so the new tls-scanner job is reflected in the prow job outputs.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: 96757000-c87a-4fcb-9ae4-6a668519f562
⛔ Files ignored due to path filters (1)
ci-operator/jobs/openshift/windows-machine-config-operator/openshift-windows-machine-config-operator-master-presubmits.yamlis excluded by!ci-operator/jobs/**
📒 Files selected for processing (1)
ci-operator/config/openshift/windows-machine-config-operator/openshift-windows-machine-config-operator-master.yaml
|
/pj-rehearse pull-ci-openshift-windows-machine-config-operator-master-tls-scanner |
|
@mansikulkarni96: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
[REHEARSALNOTIFIER]
Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
/test ci/prow/yamllint |
|
/test yamllint |
|
in the job logs seeing |
|
@mansikulkarni96 seems the private key secret is missing; see logs |
|
@jrvaldes thanks I ll see to fix that. Not sure if its required though as the operator was installed. |
understood, thanks for the explanation. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jrvaldes, mansikulkarni96 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/pj-rehearse ack |
|
@jrvaldes: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
openshift-merge-bot
Bot
added
the
rehearsals-ack
|
@mansikulkarni96: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
3 participants
Summary by CodeRabbit
This PR updates the OpenShift CI configuration in openshift/release for the Windows Machine Config Operator (WMCO) by adding a TLS scanner job and a corresponding base image used by that job.
What changed in practical terms:
Impact: