Skip to content

Mirror minio image to ci jobs#79807

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
gangwgr:add-ci-image
May 28, 2026
Merged

Mirror minio image to ci jobs#79807
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
gangwgr:add-ci-image

Conversation

@gangwgr
Copy link
Copy Markdown
Contributor

@gangwgr gangwgr commented May 28, 2026

Mirror minio image to ci jobs

Summary by CodeRabbit

This PR adds CI operator configuration for the OpenShift cluster-image-registry-operator project. It creates a new configuration file that defines how CI tests should be executed for the main development branch.

Key Changes:

  • Creates a new CI configuration file (openshift-cluster-image-registry-operator-main.yaml) that establishes the build and test pipeline for the cluster-image-registry-operator
  • Introduces three base images: hypershift-operator, hypershift-tests, and a newly added minio image from the openshifttest namespace (with latest tag)
  • Configures the minio image as a dependency for CI jobs, enabling its use across various test workflows
  • Defines a full test matrix including unit tests and multiple e2e test workflows (AWS OVN, AWS operator, GCP, Azure, etc.)

Context:
The PR is mirroring the minio image into the CI infrastructure, making it available as a dependency for CI jobs. This is a foundational change that sets up the testing framework for the cluster-image-registry-operator on the main branch. The PR remains in draft status pending review.

@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 28, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 28, 2026

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 28, 2026

Walkthrough

A single YAML configuration addition defines a new minio base image entry under the existing hypershift-tests section, specifying the image name, namespace as openshifttest, and tag as latest.

Changes

Minio base image configuration

Layer / File(s) Summary
Minio base image definition
ci-operator/config/openshift/cluster-image-registry-operator/openshift-cluster-image-registry-operator-main.yaml
Adds base_images.hypershift-tests.minio with image name minio, namespace openshifttest, and tag latest.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Title check ✅ Passed The title 'Mirror minio image to ci jobs' accurately describes the main change: adding a minio base-image definition to the CI operator config for use in CI jobs.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed PR adds only CI configuration file with static test job names (unit, e2e-aws-ovn, etc.); no Ginkgo tests with dynamic test names (It(), Describe(), etc.) are present.
Test Structure And Quality ✅ Passed PR contains only YAML CI configuration changes, not Ginkgo test code. Custom check for Ginkgo test quality is not applicable to this configuration-only pull request.
Microshift Test Compatibility ✅ Passed PR adds only a CI configuration entry for minio base image, no Ginkgo e2e tests were added, so MicroShift compatibility check does not apply.
Single Node Openshift (Sno) Test Compatibility ✅ Passed PR only modifies CI configuration YAML files and does not add Ginkgo e2e tests. SNO compatibility check applies only to new test code, not CI configs.
Topology-Aware Scheduling Compatibility ✅ Passed Change adds minio base image to CI config—no scheduling constraints, pod specs, or deployments. Topology-aware check does not apply.
Ote Binary Stdout Contract ✅ Passed PR only modifies YAML CI configuration files; no source code changes exist, so OTE Binary Stdout Contract check cannot apply.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed This PR modifies a YAML configuration file (openshift-cluster-image-registry-operator-main.yaml) to add a minio base image definition. No Ginkgo e2e test code (It(), Describe(), etc.) was added.
No-Weak-Crypto ✅ Passed PR adds only YAML configuration for a container image reference; no cryptographic code, weak crypto usage, or secret handling logic present.
Container-Privileges ✅ Passed The PR adds a minio base image reference to a ci-operator config. No privileged, hostPID, hostNetwork, hostIPC, SYS_ADMIN, allowPrivilegeEscalation, or root-running settings detected in the file.
No-Sensitive-Data-In-Logs ✅ Passed No logging statements or sensitive data found. The PR only adds CI base image configuration with standard non-sensitive values: minio image name, openshifttest namespace, latest tag.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@gangwgr gangwgr changed the title Add ci image Mirror minio image to ci jobs May 28, 2026
@gangwgr gangwgr marked this pull request as ready for review May 28, 2026 08:55
@openshift-ci openshift-ci Bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels May 28, 2026
@openshift-ci openshift-ci Bot requested review from ardaguclu and bertinatto May 28, 2026 08:55
@openshift-merge-bot
Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@gangwgr: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-origin-main-e2e-agnostic-ovn-cmd openshift/origin presubmit Presubmit changed
pull-ci-openshift-origin-main-e2e-aws-tls-observed-config openshift/origin presubmit Presubmit changed
pull-ci-openshift-origin-main-e2e-azure openshift/origin presubmit Presubmit changed
pull-ci-openshift-origin-main-e2e-azure-ovn-etcd-scaling openshift/origin presubmit Presubmit changed
pull-ci-openshift-origin-main-e2e-azure-ovn-upgrade openshift/origin presubmit Presubmit changed
pull-ci-openshift-origin-main-e2e-hypershift-conformance openshift/origin presubmit Presubmit changed
pull-ci-openshift-origin-main-e2e-metal-ovn-single-node-live-iso openshift/origin presubmit Presubmit changed
pull-ci-openshift-origin-main-e2e-metal-ovn-single-node-with-worker-live-iso openshift/origin presubmit Presubmit changed
pull-ci-openshift-origin-main-e2e-openstack-dualstack-v6primary openshift/origin presubmit Presubmit changed
pull-ci-openshift-origin-main-go-verify-deps openshift/origin presubmit Presubmit changed
pull-ci-openshift-origin-main-images openshift/origin presubmit Presubmit changed
pull-ci-openshift-origin-main-lint openshift/origin presubmit Presubmit changed
pull-ci-openshift-origin-main-okd-scos-images openshift/origin presubmit Presubmit changed
pull-ci-openshift-origin-main-unit openshift/origin presubmit Presubmit changed
pull-ci-openshift-origin-main-verify openshift/origin presubmit Presubmit changed
pull-ci-openshift-origin-main-verify-deps openshift/origin presubmit Presubmit changed
pull-ci-openshift-origin-main-verify-image-manifest-lists openshift/origin presubmit Presubmit changed
pull-ci-openshift-origin-release-4.22-e2e-agnostic-ovn-cmd openshift/origin presubmit Presubmit changed
pull-ci-openshift-origin-release-4.22-e2e-aws-tls-observed-config openshift/origin presubmit Presubmit changed
pull-ci-openshift-origin-release-4.22-e2e-azure openshift/origin presubmit Presubmit changed
pull-ci-openshift-origin-release-4.22-e2e-azure-ovn-etcd-scaling openshift/origin presubmit Presubmit changed
pull-ci-openshift-origin-release-4.22-e2e-azure-ovn-upgrade openshift/origin presubmit Presubmit changed
pull-ci-openshift-origin-release-4.22-e2e-gcp-csi openshift/origin presubmit Presubmit changed
pull-ci-openshift-origin-release-4.22-e2e-gcp-disruptive openshift/origin presubmit Presubmit changed
pull-ci-openshift-origin-release-4.22-e2e-gcp-fips-serial-1of2 openshift/origin presubmit Presubmit changed

A total of 71 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs.

A full list of affected jobs can be found here
Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-merge-bot
Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@gangwgr: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-cluster-image-registry-operator-main-e2e-aws-operator openshift/cluster-image-registry-operator presubmit Ci-operator config changed
pull-ci-openshift-cluster-image-registry-operator-main-e2e-aws-operator-parallel-ote openshift/cluster-image-registry-operator presubmit Ci-operator config changed
pull-ci-openshift-cluster-image-registry-operator-main-e2e-aws-operator-serial-ote openshift/cluster-image-registry-operator presubmit Ci-operator config changed
pull-ci-openshift-cluster-image-registry-operator-main-e2e-aws-ovn openshift/cluster-image-registry-operator presubmit Ci-operator config changed
pull-ci-openshift-cluster-image-registry-operator-main-e2e-aws-ovn-image-registry openshift/cluster-image-registry-operator presubmit Ci-operator config changed
pull-ci-openshift-cluster-image-registry-operator-main-e2e-aws-ovn-upgrade openshift/cluster-image-registry-operator presubmit Ci-operator config changed
pull-ci-openshift-cluster-image-registry-operator-main-e2e-azure-manual-oidc openshift/cluster-image-registry-operator presubmit Ci-operator config changed
pull-ci-openshift-cluster-image-registry-operator-main-e2e-azure-operator openshift/cluster-image-registry-operator presubmit Ci-operator config changed
pull-ci-openshift-cluster-image-registry-operator-main-e2e-azure-ovn openshift/cluster-image-registry-operator presubmit Ci-operator config changed
pull-ci-openshift-cluster-image-registry-operator-main-e2e-gcp-operator openshift/cluster-image-registry-operator presubmit Ci-operator config changed
pull-ci-openshift-cluster-image-registry-operator-main-e2e-gcp-ovn openshift/cluster-image-registry-operator presubmit Ci-operator config changed
pull-ci-openshift-cluster-image-registry-operator-main-e2e-hypershift openshift/cluster-image-registry-operator presubmit Ci-operator config changed
pull-ci-openshift-cluster-image-registry-operator-main-e2e-hypershift-conformance openshift/cluster-image-registry-operator presubmit Ci-operator config changed
pull-ci-openshift-cluster-image-registry-operator-main-e2e-openstack openshift/cluster-image-registry-operator presubmit Ci-operator config changed
pull-ci-openshift-cluster-image-registry-operator-main-e2e-vsphere openshift/cluster-image-registry-operator presubmit Ci-operator config changed
pull-ci-openshift-cluster-image-registry-operator-main-e2e-vsphere-operator openshift/cluster-image-registry-operator presubmit Ci-operator config changed
pull-ci-openshift-cluster-image-registry-operator-main-hypershift-e2e-aks openshift/cluster-image-registry-operator presubmit Ci-operator config changed
pull-ci-openshift-cluster-image-registry-operator-main-images openshift/cluster-image-registry-operator presubmit Ci-operator config changed
pull-ci-openshift-cluster-image-registry-operator-main-okd-scos-e2e-aws-ovn openshift/cluster-image-registry-operator presubmit Ci-operator config changed
pull-ci-openshift-cluster-image-registry-operator-main-okd-scos-images openshift/cluster-image-registry-operator presubmit Ci-operator config changed
pull-ci-openshift-cluster-image-registry-operator-main-unit openshift/cluster-image-registry-operator presubmit Ci-operator config changed
pull-ci-openshift-cluster-image-registry-operator-main-verify openshift/cluster-image-registry-operator presubmit Ci-operator config changed
pull-ci-openshift-cluster-image-registry-operator-main-verify-deps openshift/cluster-image-registry-operator presubmit Ci-operator config changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 28, 2026

@gangwgr: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@gangwgr
Copy link
Copy Markdown
Contributor Author

gangwgr commented May 28, 2026

/pj-rehearse ack

@openshift-merge-bot
Copy link
Copy Markdown
Contributor

@gangwgr: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-merge-bot openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label May 28, 2026
@ropatil010
Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label May 28, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 28, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gangwgr, ropatil010

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot Bot merged commit 83e7930 into openshift:main May 28, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants