Increase CAMO lint memory limit to 6Gi#79791
Conversation
The golangci-lint step OOMs at 4Gi after recent dependency updates expanded the module graph (go-openapi/swag split into 11 sub-modules). The container is killed during module downloading before linting starts. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
WalkthroughThis change adds a ChangesLint job resource configuration
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
openshift-ci
Bot
added
the
approved
|
[REHEARSALNOTIFIER]
Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals. Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🧹 Nitpick comments (1)
ci-operator/config/openshift/configure-alertmanager-operator/openshift-configure-alertmanager-operator-master.yaml (1)
17-19: 💤 Low valueConsider increasing the memory request to better match expected usage.
The memory request is set to 200Mi while the limit is 6Gi (a 30× gap). If the lint job consistently requires close to 6Gi (as evidenced by OOM failures at 4Gi), the request should probably be higher to ensure proper scheduling and avoid node resource contention.
A memory request closer to expected baseline usage (e.g., 2Gi-4Gi) would help the Kubernetes scheduler place the pod on nodes with sufficient available memory and prevent resource contention issues.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@ci-operator/config/openshift/configure-alertmanager-operator/openshift-configure-alertmanager-operator-master.yaml` around lines 17 - 19, Update the resources block so the memory request (requests.memory) better reflects observed baseline usage instead of 200Mi; set requests.memory to a value in the 2Gi–4Gi range (e.g., 4Gi if OOMs occurred near 4Gi) while keeping it <= limits.memory (currently 6Gi), and run the job to validate scheduling and pod stability; adjust further based on observed memory usage.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In
`@ci-operator/config/openshift/configure-alertmanager-operator/openshift-configure-alertmanager-operator-master.yaml`:
- Around line 17-19: Update the resources block so the memory request
(requests.memory) better reflects observed baseline usage instead of 200Mi; set
requests.memory to a value in the 2Gi–4Gi range (e.g., 4Gi if OOMs occurred near
4Gi) while keeping it <= limits.memory (currently 6Gi), and run the job to
validate scheduling and pod stability; adjust further based on observed memory
usage.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: e24b71ce-6d64-4083-b88e-68d42262a4dd
📒 Files selected for processing (1)
ci-operator/config/openshift/configure-alertmanager-operator/openshift-configure-alertmanager-operator-master.yaml
|
@nephomaniac: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/pj-rehearse ack |
|
@ritmun: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
openshift-merge-bot
Bot
added
the
rehearsals-ack
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: clcollins, nephomaniac The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
3 participants
Summary
Evidence
Test plan
🤖 Generated with Claude Code
Summary by CodeRabbit
This PR increases the memory limit for the lint step in the
configure-alertmanager-operator(CAMO) CI pipeline from 4Gi to 6Gi.Context
The golangci-lint step was failing with OOMKilled (exit code 137) during the Go module downloading phase. Recent dependency updates expanded the module graph—specifically, the
go-openapi/swagpackage was split into 11 sub-modules—causing the linting process to exhaust the 4Gi memory allocation before linting could even begin.Changes
The CI configuration for
openshift/configure-alertmanager-operator-master.yamlnow includes a resource override for thelinttest step:Other pipeline steps (test, coverage, validate, e2e-binary-build) continue using the default 4Gi memory limit.
Test Plan
Once this change merges, CAMO PR
#530's lint step should pass without hitting the OOMKilled error.