Revert "OSAC-360: Update Go version in osac-project installer config"#79839
Conversation
…penshift#79754)" This reverts commit 33e14bd.
openshift-ci-robot
added
the
jira/valid-reference
|
@omer-vishlitzky: This pull request references OSAC-360 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "5.0.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
WalkthroughThis PR updates the CI operator configuration for the osac-installer project by changing the ChangesBuild root image update
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
[REHEARSALNOTIFIER]
Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals. Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
ci-operator/config/osac-project/osac-installer/osac-project-osac-installer-main.yaml (1)
17-21: Document the justification for reverting the Go version.This PR reverts from Go 1.26/OpenShift 5.0 to Go 1.25/OpenShift 4.21 without explaining the reason. The Jira comment indicates OSAC-360 lacks a valid target version for the target branch.
Before merging, document:
- Why the revert is necessary (e.g., compatibility issue, build failure, dependency constraints)
- Whether any code changes dependent on Go 1.26 features need to be reverted
- The planned migration path forward, if any
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@ci-operator/config/osac-project/osac-installer/osac-project-osac-installer-main.yaml` around lines 17 - 21, Update documentation to justify reverting the Go/OpenShift tag: add a brief rationale in the PR description and a YAML comment adjacent to build_root -> image_stream_tag -> tag explaining why we moved from tag "rhel-9-release-golang-1.26-openshift-5.0" back to "rhel-9-release-golang-1.25-openshift-4.21" (e.g., compatibility/build/dependency issue), confirm whether any code using Go 1.26 features was reverted (or list files/functions that need changes), and state the planned migration path and timeline (link to OSAC-360/JIRA). Ensure the comment references the tag field name and the OSAC-360 ticket ID for traceability.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@ci-operator/config/osac-project/osac-installer/osac-project-osac-installer-main.yaml`:
- Line 21: Update the OpenShift target in the CI config so the builder tag and
release candidate match: set build_root.image_stream_tag.tag to the same
OpenShift version as releases.latest.candidate.version (or vice‑versa) to avoid
mismatched builder/runtime images, and confirm the image_stream tag
release:rhel-9-release-golang-1.25-openshift-4.21 actually exists in the
openshift namespace before using it; also add a concise PR justification for
this revert that explicitly states the intended target OpenShift version
referenced by OSAC-360 and whether the change is bumping the builder or the
candidate release.
---
Nitpick comments:
In
`@ci-operator/config/osac-project/osac-installer/osac-project-osac-installer-main.yaml`:
- Around line 17-21: Update documentation to justify reverting the Go/OpenShift
tag: add a brief rationale in the PR description and a YAML comment adjacent to
build_root -> image_stream_tag -> tag explaining why we moved from tag
"rhel-9-release-golang-1.26-openshift-5.0" back to
"rhel-9-release-golang-1.25-openshift-4.21" (e.g.,
compatibility/build/dependency issue), confirm whether any code using Go 1.26
features was reverted (or list files/functions that need changes), and state the
planned migration path and timeline (link to OSAC-360/JIRA). Ensure the comment
references the tag field name and the OSAC-360 ticket ID for traceability.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: 66908c45-6c57-4b01-9814-62df2f4c65a3
📒 Files selected for processing (1)
ci-operator/config/osac-project/osac-installer/osac-project-osac-installer-main.yaml
| name: release | ||
| namespace: openshift | ||
| tag: rhel-9-release-golang-1.26-openshift-5.0 | ||
| tag: rhel-9-release-golang-1.25-openshift-4.21 |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Description: Verify that the builder image stream tag exists in the cluster
# Check if the image stream tag exists in the openshift namespace
oc get imagestreamtag release:rhel-9-release-golang-1.25-openshift-4.21 -n openshift --ignore-not-found 2>&1 || echo "Tag verification requires cluster access"
# Alternative: Search for similar tags in CI config to validate naming pattern
rg -n "rhel-9-release-golang-1\.25-openshift-4\.21" --type yamlRepository: openshift/release
Length of output: 50374
🏁 Script executed:
#!/bin/bash
set -euo pipefail
FILE="ci-operator/config/osac-project/osac-installer/osac-project-osac-installer-main.yaml"
wc -l "$FILE"
echo "---- lines 1-90 ----"
nl -ba "$FILE" | sed -n '1,90p'Repository: openshift/release
Length of output: 231
🏁 Script executed:
#!/bin/bash
set -euo pipefail
FILE="ci-operator/config/osac-project/osac-installer/osac-project-osac-installer-main.yaml"
echo "---- file (show key sections) ----"
echo
echo "== build_root section (lines 1-40) =="
cat -n "$FILE" | sed -n '1,40p'
echo
echo "== releases section (lines 40-90) =="
cat -n "$FILE" | sed -n '40,90p'Repository: openshift/release
Length of output: 2526
Align OpenShift version targets (and confirm builder tag availability) for OSAC installer
build_root.image_stream_tag.tagisrhel-9-release-golang-1.25-openshift-4.21(line 21), butreleases.latest.candidate.versionis4.20(lines 54-60); align these OpenShift versions to avoid mismatched builder/runtime images.- Ensure
release:rhel-9-release-golang-1.25-openshift-4.21exists in theopenshiftnamespace before relying on this builder tag. - Add PR justification for the revert and clarify the intended target version referenced by OSAC-360.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In
`@ci-operator/config/osac-project/osac-installer/osac-project-osac-installer-main.yaml`
at line 21, Update the OpenShift target in the CI config so the builder tag and
release candidate match: set build_root.image_stream_tag.tag to the same
OpenShift version as releases.latest.candidate.version (or vice‑versa) to avoid
mismatched builder/runtime images, and confirm the image_stream tag
release:rhel-9-release-golang-1.25-openshift-4.21 actually exists in the
openshift namespace before using it; also add a concise PR justification for
this revert that explicitly states the intended target OpenShift version
referenced by OSAC-360 and whether the change is bumping the builder or the
candidate release.
|
@omer-vishlitzky: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/pj-rehearse ack |
1 similar comment
|
/pj-rehearse ack |
|
@omer-vishlitzky: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
openshift-merge-bot
Bot
added
the
rehearsals-ack
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: akshaynadkarni, omer-vishlitzky The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
3 participants
Reverts #79754
Summary by CodeRabbit
This PR reverts the Go version upgrade that was applied to the osac-project installer's CI operator configuration. Specifically, it downgrades the
build_rootimage stream tag in the CI operator configuration for the osac-installer component from the Golang 1.26 / OpenShift 5.0 variant back to the Golang 1.25 / OpenShift 4.21 variant. This single-line change in the CI operator configuration will affect the build environment used for building the osac-installer component, reverting the Go runtime version from 1.26 to 1.25.