Skip to content

chore: use go 1.26 + ocp 5.0 runner#79899

Open
yftacherzog wants to merge 1 commit into
openshift:mainfrom
yftacherzog:openshift-5-runner
Open

chore: use go 1.26 + ocp 5.0 runner#79899
yftacherzog wants to merge 1 commit into
openshift:mainfrom
yftacherzog:openshift-5-runner

Conversation

@yftacherzog
Copy link
Copy Markdown
Contributor

@yftacherzog yftacherzog commented May 31, 2026

We don't have go 1.26 in ocp 4 runner, so use 5.0.

Assisted-by: Cursor

Summary by CodeRabbit

This pull request updates the Konflux CI build configuration to use Go 1.26 with OpenShift 5.0 runners, upgrading from the previous Go 1.25 with OpenShift 4.21 setup. The change is necessary because Go 1.26 is not available in the OCP 4 runner environment.

Changes made:
Three Konflux CI configuration files were updated:

  • konflux-ci-konflux-ci-main.yaml
  • konflux-ci-konflux-ci-main__ocp420-arm64.yaml
  • konflux-ci-konflux-ci-main__ocp420.yaml

In each file, both the base_images.e2e-test-runner.tag and build_root.image_stream_tag.tag were updated from rhel-9-release-golang-1.25-openshift-4.21 to rhel-9-release-golang-1.26-openshift-5.0.

Impact:
This upgrades the CI/CD infrastructure for Konflux CI's build and test execution environment, ensuring compatibility with Go 1.26 while moving to the latest OpenShift 5.0 runtime.

We don't have go 1.26 in ocp 4 runner, so use 5.0.

Assisted-by: Cursor
Signed-off-by: Yftach Herzog <yherzog@redhat.com>
@yftacherzog
Copy link
Copy Markdown
Contributor Author

/pj-rehearse

@openshift-merge-bot
Copy link
Copy Markdown
Contributor

@yftacherzog: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 31, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: fffeca37-c6da-4f1c-becb-336ff571711b

📥 Commits

Reviewing files that changed from the base of the PR and between 9626cc0 and 822d700.

📒 Files selected for processing (3)
  • ci-operator/config/konflux-ci/konflux-ci/konflux-ci-konflux-ci-main.yaml
  • ci-operator/config/konflux-ci/konflux-ci/konflux-ci-konflux-ci-main__ocp420-arm64.yaml
  • ci-operator/config/konflux-ci/konflux-ci/konflux-ci-konflux-ci-main__ocp420.yaml

Walkthrough

Three Konflux CI configuration files are updated to use Go 1.26 and OpenShift 5.0 builder images. Both the e2e test runner base image and build root image stream tags are changed from the Go 1.25 / OpenShift 4.21 variant to the Go 1.26 / OpenShift 5.0 variant across the main branch and two platform-specific configurations.

Changes

Konflux CI Build Image Tag Update

Layer / File(s) Summary
Build image tag updates across Konflux CI variants
ci-operator/config/konflux-ci/konflux-ci/konflux-ci-konflux-ci-main.yaml, ci-operator/config/konflux-ci/konflux-ci/konflux-ci-konflux-ci-main__ocp420-arm64.yaml, ci-operator/config/konflux-ci/konflux-ci/konflux-ci-konflux-ci-main__ocp420.yaml
Both base_images.e2e-test-runner.tag and build_root.image_stream_tag.tag changed from rhel-9-release-golang-1.25-openshift-4.21 to rhel-9-release-golang-1.26-openshift-5.0 in the main configuration and platform-specific variants.

Possibly related PRs

  • openshift/release#79736: Directly related update of the same OpenShift/RHEL Go builder image tag in Konflux CI and govulncheck configurations.
  • openshift/release#79754: Directly connected configuration update to the same Go 1.26 / OpenShift 5.0 builder image stream tag across Konflux base images and build root.
  • openshift/release#79717: Related OpenShift builder image stream tag update from Go 1.25 / OCP 4.21 to Go 1.26 / OCP 5.0 variants.

Suggested labels

lgtm, rehearsals-ack

Suggested reviewers

  • jkhelil
  • avinal
  • bradmwilliams

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: updating to Go 1.26 and OCP 5.0 runner, which matches the core changes across all three configuration files.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed PR modifies CI config YAMLs and test utility tools without using Ginkgo framework; no Ginkgo test names to validate.
Test Structure And Quality ✅ Passed The PR does not contain any Ginkgo test code modifications. The custom check for Ginkgo test structure and quality is not applicable, so the check passes by default.
Microshift Test Compatibility ✅ Passed No new Ginkgo e2e tests are added in this PR; only CI configuration files are updated. The check is inapplicable.
Single Node Openshift (Sno) Test Compatibility ✅ Passed PR modifies only YAML CI configuration files with image tag updates. No new Ginkgo e2e tests (It, Describe, Context, When) are added, so SNO compatibility check does not apply.
Topology-Aware Scheduling Compatibility ✅ Passed PR modifies only CI-operator configuration files with image tag updates. No deployment manifests, operator code, controllers, or pod scheduling constraints are introduced or modified.
Ote Binary Stdout Contract ✅ Passed PR only modifies YAML configuration files updating build image tags; contains no source code changes that could violate the OTE Binary Stdout Contract check requirements.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed PR contains only CI configuration updates (YAML image tag changes), not new Ginkgo e2e test code; IPv6/disconnected network check is not applicable.
No-Weak-Crypto ✅ Passed PR only updates CI configuration image tags for Go 1.26 + OCP 5.0; no cryptographic code or weak crypto patterns are introduced.
Container-Privileges ✅ Passed No privileged container settings (privileged: true, hostPID, hostNetwork, hostIPC, SYS_ADMIN, allowPrivilegeEscalation, runAsRoot) found in any of the three YAML files changed in this PR.
No-Sensitive-Data-In-Logs ✅ Passed YAML configuration files contain no logging code or sensitive data exposure. Only reference to "logs" is in a Slack report template linking to CI logs.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci Bot requested review from gbenhaim and hmariset May 31, 2026 17:15
@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 31, 2026
@openshift-merge-bot
Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@yftacherzog: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-konflux-ci-konflux-ci-main-konflux-e2e-v420-arm64-optional konflux-ci/konflux-ci presubmit Ci-operator config changed
pull-ci-konflux-ci-konflux-ci-main-konflux-e2e-v420-optional konflux-ci/konflux-ci presubmit Ci-operator config changed
periodic-ci-konflux-ci-konflux-ci-main-ocp420-arm64-konflux-e2e-v420-arm64 N/A periodic Ci-operator config changed
periodic-ci-konflux-ci-konflux-ci-main-ocp420-konflux-e2e-v420 N/A periodic Ci-operator config changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 31, 2026

@yftacherzog: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@gbenhaim
Copy link
Copy Markdown
Member

gbenhaim commented Jun 1, 2026

/approve
/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jun 1, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jun 1, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gbenhaim, yftacherzog

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants