Enable PR-based testing for openshift-pipelines/performance#81184
Conversation
This change allows performance test jobs to validate changes before merging: - Presubmit jobs (triggered from performance repo PRs) now test the PR's code - Rehearse jobs (testing CI config changes) continue using main branch - Periodic and postsubmit jobs continue using main branch Implementation uses the industry-standard pattern (JOB_TYPE check) matching: - redhat-performance/backstage-performance - redhat-appstudio/load-test - konflux-ci/install-konflux Benefits: - Validate performance test changes before merge - Reduce iteration cycles (no need for multiple PRs) - Maintain stability for CI config testing (rehearse jobs) Technical details: - Check JOB_TYPE == "presubmit" to identify PR testing jobs - Exclude rehearse jobs with JOB_NAME pattern check - Always clone main first, then conditionally switch to PR branch - Use FETCH_HEAD for clean checkout of PR code
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (2)
WalkthroughTwo CI pipeline command scripts ( ChangesPR Branch Checkout for Presubmit Jobs
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
[REHEARSALNOTIFIER]
A total of 168 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs. A full list of affected jobs can be found here Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
/lgtm |
|
@siddardh-ra: you cannot LGTM your own PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/ok-to-test |
openshift-ci
Bot
added
the
ok-to-test
|
@siddardh-ra: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jhutar, siddardh-ra The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
|
/pj-rehearse ack |
|
@siddardh-ra: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
openshift-merge-bot
Bot
added
the
rehearsals-ack
…t#81184) This change allows performance test jobs to validate changes before merging: - Presubmit jobs (triggered from performance repo PRs) now test the PR's code - Rehearse jobs (testing CI config changes) continue using main branch - Periodic and postsubmit jobs continue using main branch Implementation uses the industry-standard pattern (JOB_TYPE check) matching: - redhat-performance/backstage-performance - redhat-appstudio/load-test - konflux-ci/install-konflux Benefits: - Validate performance test changes before merge - Reduce iteration cycles (no need for multiple PRs) - Maintain stability for CI config testing (rehearse jobs) Technical details: - Check JOB_TYPE == "presubmit" to identify PR testing jobs - Exclude rehearse jobs with JOB_NAME pattern check - Always clone main first, then conditionally switch to PR branch - Use FETCH_HEAD for clean checkout of PR code
…t#81184) This change allows performance test jobs to validate changes before merging: - Presubmit jobs (triggered from performance repo PRs) now test the PR's code - Rehearse jobs (testing CI config changes) continue using main branch - Periodic and postsubmit jobs continue using main branch Implementation uses the industry-standard pattern (JOB_TYPE check) matching: - redhat-performance/backstage-performance - redhat-appstudio/load-test - konflux-ci/install-konflux Benefits: - Validate performance test changes before merge - Reduce iteration cycles (no need for multiple PRs) - Maintain stability for CI config testing (rehearse jobs) Technical details: - Check JOB_TYPE == "presubmit" to identify PR testing jobs - Exclude rehearse jobs with JOB_NAME pattern check - Always clone main first, then conditionally switch to PR branch - Use FETCH_HEAD for clean checkout of PR code
…t#81184) This change allows performance test jobs to validate changes before merging: - Presubmit jobs (triggered from performance repo PRs) now test the PR's code - Rehearse jobs (testing CI config changes) continue using main branch - Periodic and postsubmit jobs continue using main branch Implementation uses the industry-standard pattern (JOB_TYPE check) matching: - redhat-performance/backstage-performance - redhat-appstudio/load-test - konflux-ci/install-konflux Benefits: - Validate performance test changes before merge - Reduce iteration cycles (no need for multiple PRs) - Maintain stability for CI config testing (rehearse jobs) Technical details: - Check JOB_TYPE == "presubmit" to identify PR testing jobs - Exclude rehearse jobs with JOB_NAME pattern check - Always clone main first, then conditionally switch to PR branch - Use FETCH_HEAD for clean checkout of PR code
2 participants
This change allows performance test jobs to validate changes before merging:
Implementation uses the industry-standard pattern (JOB_TYPE check) matching:
Benefits:
Technical details:
Summary by CodeRabbit
This PR updates the OpenShift Pipelines performance CI steps so presubmit jobs for the
openshift-pipelines/performancerepository test the actual pull request changes instead of always usingmain.In practice:
mainfirst, then fetch and checkout the PR head commit usingFETCH_HEAD.main, so CI configuration validation behavior stays stable.main.This lets performance changes be validated before merge without affecting the existing CI rehearsal and scheduled job flows.