fix(prow): mark terraform-provider-rhcs contexts as required-if-present

[amandahla]

Summary

Fix Tide configuration conflict for terraform-redhat/terraform-provider-rhcs where conditional presubmit contexts were treated as both required and required-if-present.

Type of change

fix (prow)

Related

None

Changes

• Add tide.context_options override in _config.yaml for terraform-redhat/terraform-provider-rhcs on main.
• Mark eight CI contexts as required-if-present-contexts so Tide only requires them when the corresponding conditional presubmit jobs run.

Breaking changes

No.

Testing / validation

• make prow-config completed successfully.
• make checkconfig no longer reports the supplemental config merge error for tide.context_options; local run still hits an unrelated stat ... invalid argument environment warning.

Made with Cursor

Summary by CodeRabbit

This change updates Tide configuration for terraform-redhat/terraform-provider-rhcs in the OpenShift release CI config so merge requirements match how its conditional presubmit jobs are gated.

Practically, it:

• adds a tide.context_options override for the terraform-redhat org
• applies a main branch rule for terraform-provider-rhcs
• marks the relevant CI contexts as required-if-present-contexts, preventing Tide from treating them as unconditional required checks when the matching conditional jobs are not run

This resolves the branch-protection/Tide conflict for that repository without introducing breaking changes.

[coderabbitai]

Warning

Review limit reached

@amandahla, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 21 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 29cafc3e-9299-4646-a95b-5188c6eb4e50

📥 Commits

Reviewing files that changed from the base of the PR and between e570e15 and 093b0f0.

📒 Files selected for processing (1)

• core-services/prow/02_config/terraform-redhat/terraform-provider-rhcs/_prowconfig.yaml

Walkthrough

Extends tide.context_options in the Prow config to add the terraform-redhat org with a terraform-provider-rhcs repo rule for the main branch, listing several ci/prow/* contexts under required-if-present-contexts.

Tide context_options gating

Layer / File(s)	Summary
Tide required-if-present-contexts for terraform-provider-rhcs core-services/prow/02_config/_config.yaml	Adds terraform-redhat org under tide.context_options with terraform-provider-rhcs repo rules for the main branch, enumerating multiple ci/prow/* contexts that Tide must gate on if present.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

• openshift/release#80263: Extends the same tide.context_options configuration with required-if-present-contexts for another repo (openshift/rosa) using the same pattern.

Suggested labels

lgtm, approved

Suggested reviewers

• danilo-gemoli

🚥 Pre-merge checks | ✅ 15

✅ Passed checks (15 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and concisely describes the main Prow/Tide configuration change.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	PR only updates prow YAML for terraform-provider-rhcs; no Ginkgo test files or test titles were changed, so there’s no dynamic-name risk.
Test Structure And Quality	✅ Passed	PR only updates prow config YAML for terraform-provider-rhcs; no Ginkgo test code was changed, so this test-structure review is not applicable.
Microshift Test Compatibility	✅ Passed	PR only changes prow Tide config for terraform-provider-rhcs; no new Ginkgo tests or MicroShift-unsupported APIs/features were added.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	PASS: The PR only changes Prow/Tide YAML; no Ginkgo e2e tests or cluster-assumption code were added, so SNO compatibility is not applicable.
Topology-Aware Scheduling Compatibility	✅ Passed	The change only edits Prow Tide config for terraform-redhat/terraform-provider-rhcs; no deployment manifests, operator code, or controllers are touched.
Ote Binary Stdout Contract	✅ Passed	PR only changes prow YAML config; no main/init/TestMain/suite code or stdout writes were added.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	Only a Prow YAML config changed; no new Ginkgo e2e tests were added, so the IPv6/disconnected test check is not applicable.
No-Weak-Crypto	✅ Passed	The PR only adds Tide YAML for terraform-provider-rhcs; no weak-crypto APIs, custom crypto, or secret/token comparisons appear in the added lines.
Container-Privileges	✅ Passed	The PR only updates Prow Tide config; the added block lists contexts and contains no privileged, hostPID/Network/IPC, allowPrivilegeEscalation, SYS_ADMIN, or root settings.
No-Sensitive-Data-In-Logs	✅ Passed	The PR only adds Tide context config for terraform-provider-rhcs; the new stanza contains no logging, secrets, or PII.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[openshift-merge-bot]

[REHEARSALNOTIFIER]
@amandahla: no rehearsable tests are affected by this change

Note: If this PR includes changes to step registry files (ci-operator/step-registry/) and you expected jobs to be found, try rebasing your PR onto the base branch. This helps pj-rehearse accurately detect changes when the base branch has moved forward.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

[jerichokeyne]

/lgtm
/approve

[hector-vido]

/lgtm

[hector-vido]

/approve

[amandahla]

/check-required-labels

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: amandahla, deepsm007, hector-vido, jerichokeyne

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• core-services/prow/02_config/OWNERS [deepsm007,hector-vido]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@amandahla: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[openshift-ci]

@amandahla: Updated the following 2 configmaps:

• config configmap in namespace ci at cluster app.ci using the following files:
  • key config.yaml using file core-services/prow/02_config/_config.yaml
  • key core-services-prow-02_config-terraform-redhat-terraform-provider-rhcs-_prowconfig.yaml using file core-services/prow/02_config/terraform-redhat/terraform-provider-rhcs/_prowconfig.yaml
• config configmap in namespace ci at cluster core-ci using the following files:
  • key config.yaml using file core-services/prow/02_config/_config.yaml
  • key core-services-prow-02_config-terraform-redhat-terraform-provider-rhcs-_prowconfig.yaml using file core-services/prow/02_config/terraform-redhat/terraform-provider-rhcs/_prowconfig.yaml

Details

In response to this:

Summary

Fix Tide configuration conflict for terraform-redhat/terraform-provider-rhcs where conditional presubmit contexts were treated as both required and required-if-present.

Type of change

fix (prow)

Related

None

Changes

• Add tide.context_options override in _config.yaml for terraform-redhat/terraform-provider-rhcs on main.
• Mark eight CI contexts as required-if-present-contexts so Tide only requires them when the corresponding conditional presubmit jobs run.

Breaking changes

No.

Testing / validation

• make prow-config completed successfully.
• make checkconfig no longer reports the supplemental config merge error for tide.context_options; local run still hits an unrelated stat ... invalid argument environment warning.

Made with Cursor

Summary by CodeRabbit

This change updates Tide configuration for terraform-redhat/terraform-provider-rhcs in the OpenShift release CI config so merge requirements match how its conditional presubmit jobs are gated.

Practically, it:

• adds a tide.context_options override for the terraform-redhat org
• applies a main branch rule for terraform-provider-rhcs
• marks the relevant CI contexts as required-if-present-contexts, preventing Tide from treating them as unconditional required checks when the matching conditional jobs are not run

This resolves the branch-protection/Tide conflict for that repository without introducing breaking changes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.