Skip to content

Add floresroger to GCP HCP step-registry and CI OWNERS#81220

Merged
openshift-merge-bot[bot] merged 2 commits into
openshift:mainfrom
patjlm:rfloresj
Jul 7, 2026
Merged

Add floresroger to GCP HCP step-registry and CI OWNERS#81220
openshift-merge-bot[bot] merged 2 commits into
openshift:mainfrom
patjlm:rfloresj

Conversation

@patjlm

@patjlm patjlm commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Add GitHub user floresroger (Red Hat: rfloresj) as approver and reviewer in GCP HCP step-registry OWNERS files and CI image OWNERS
  • Same permissions as existing team members (jimdaga, patjlm)

Tracking

Test plan

  • Verify floresroger is member of openshift GitHub org
  • Confirm OWNERS changes are picked up by Prow after merge

🤖 Generated with Claude Code

Summary by CodeRabbit

Added GitHub user floresroger (rfloresj) as both an approver and reviewer across the GCP HyperShift/HCP step-registry OWNERS scope in ci-operator/step-registry/hypershift/gcp/, including the create, destroy, control-plane-setup, and hosted-cluster-setup directories (and their generated *.metadata.json owner references). Also updated clusters/app.ci/supplemental-ci-images/hcm-gcp/OWNERS to grant the same approver/reviewer permissions for the HCM GCP supplemental CI image path—aligning access with existing maintainers so Prow can recognize the new reviewers/approvers after merge.

GCP-866

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 176d960b-f9fa-4348-8feb-ce5874517181

📥 Commits

Reviewing files that changed from the base of the PR and between 8aa3e41 and 6d5b640.

📒 Files selected for processing (9)
  • ci-operator/step-registry/hypershift/gcp/control-plane-setup/OWNERS
  • ci-operator/step-registry/hypershift/gcp/control-plane-setup/hypershift-gcp-control-plane-setup-ref.metadata.json
  • ci-operator/step-registry/hypershift/gcp/create/OWNERS
  • ci-operator/step-registry/hypershift/gcp/destroy/OWNERS
  • ci-operator/step-registry/hypershift/gcp/gke/deprovision/hypershift-gcp-gke-deprovision-ref.metadata.json
  • ci-operator/step-registry/hypershift/gcp/gke/prerequisites/hypershift-gcp-gke-prerequisites-ref.metadata.json
  • ci-operator/step-registry/hypershift/gcp/gke/provision/hypershift-gcp-gke-provision-ref.metadata.json
  • ci-operator/step-registry/hypershift/gcp/hosted-cluster-setup/OWNERS
  • ci-operator/step-registry/hypershift/gcp/hosted-cluster-setup/hypershift-gcp-hosted-cluster-setup-ref.metadata.json
✅ Files skipped from review due to trivial changes (4)
  • ci-operator/step-registry/hypershift/gcp/gke/deprovision/hypershift-gcp-gke-deprovision-ref.metadata.json
  • ci-operator/step-registry/hypershift/gcp/hosted-cluster-setup/OWNERS
  • ci-operator/step-registry/hypershift/gcp/hosted-cluster-setup/hypershift-gcp-hosted-cluster-setup-ref.metadata.json
  • ci-operator/step-registry/hypershift/gcp/control-plane-setup/OWNERS

Walkthrough

floresroger is added to approver and reviewer ownership lists across hypershift GCP step-registry OWNERS files, related metadata JSON files, and one supplemental CI image OWNERS file.

Changes

Ownership updates

Layer / File(s) Summary
Step-registry ownership entries
ci-operator/step-registry/hypershift/gcp/OWNERS, ci-operator/step-registry/hypershift/gcp/create/OWNERS, ci-operator/step-registry/hypershift/gcp/destroy/OWNERS, ci-operator/step-registry/hypershift/gcp/gke/OWNERS, ci-operator/step-registry/hypershift/gcp/gke/deprovision/OWNERS, ci-operator/step-registry/hypershift/gcp/gke/e2e-v2/OWNERS, ci-operator/step-registry/hypershift/gcp/gke/prerequisites/OWNERS, ci-operator/step-registry/hypershift/gcp/gke/provision/OWNERS, ci-operator/step-registry/hypershift/gcp/wif-auth/OWNERS, ci-operator/step-registry/hypershift/gcp/control-plane-setup/OWNERS, ci-operator/step-registry/hypershift/gcp/hosted-cluster-setup/OWNERS
floresroger is added to both approvers and reviewers in the hypershift GCP OWNERS files.
Step-registry metadata owners
ci-operator/step-registry/hypershift/gcp/create/hypershift-gcp-create-chain.metadata.json, ci-operator/step-registry/hypershift/gcp/destroy/hypershift-gcp-destroy-chain.metadata.json, ci-operator/step-registry/hypershift/gcp/gke/e2e-v2/hypershift-gcp-gke-e2e-v2-workflow.metadata.json, ci-operator/step-registry/hypershift/gcp/wif-auth/hypershift-gcp-wif-auth-ref.metadata.json, ci-operator/step-registry/hypershift/gcp/control-plane-setup/hypershift-gcp-control-plane-setup-ref.metadata.json, ci-operator/step-registry/hypershift/gcp/gke/deprovision/hypershift-gcp-gke-deprovision-ref.metadata.json, ci-operator/step-registry/hypershift/gcp/gke/prerequisites/hypershift-gcp-gke-prerequisites-ref.metadata.json, ci-operator/step-registry/hypershift/gcp/gke/provision/hypershift-gcp-gke-provision-ref.metadata.json, ci-operator/step-registry/hypershift/gcp/hosted-cluster-setup/hypershift-gcp-hosted-cluster-setup-ref.metadata.json
floresroger is added to owners.approvers and owners.reviewers in the referenced step-registry metadata.
Supplemental image ownership entries
clusters/app.ci/supplemental-ci-images/hcm-gcp/OWNERS
floresroger is added to both approvers and reviewers in the supplemental CI image OWNERS file.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Suggested labels: lgtm

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: adding floresroger to GCP HCP step-registry and CI OWNERS files.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed PR only updates OWNERS and metadata JSON entries; no Ginkgo test files or test titles were added or changed, so no unstable names are introduced.
Test Structure And Quality ✅ Passed PR only changes OWNERS and metadata files; no Ginkgo tests or test logic are modified, so this check is not applicable.
Microshift Test Compatibility ✅ Passed PR only changes OWNERS and step-registry metadata files; no Ginkgo e2e tests or MicroShift-unsupported APIs/features were added.
Single Node Openshift (Sno) Test Compatibility ✅ Passed The PR only changes OWNERS and step-registry metadata files; no new Ginkgo/e2e tests were added, so the SNO compatibility check is not applicable.
Topology-Aware Scheduling Compatibility ✅ Passed Only OWNERS and step-registry metadata files changed; no deployment manifests, operators, or controllers were modified.
Ote Binary Stdout Contract ✅ Passed Only OWNERS and metadata JSON files changed; no process-level code or stdout writes were introduced.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed No Ginkgo/e2e test code was added; the PR only changes OWNERS and metadata files.
No-Weak-Crypto ✅ Passed PASS: The full PR diff only updates OWNERS/metadata entries for floresroger; no weak-crypto terms, custom crypto, or secret comparisons appear.
Container-Privileges ✅ Passed Changed files are only OWNERS and ci-operator metadata JSON; no container/K8s manifests or privileged settings were added.
No-Sensitive-Data-In-Logs ✅ Passed The diff only adds floresroger to OWNERS/metadata lists; no logs or sensitive fields (passwords, tokens, PII, hostnames) are present.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@cristianoveiga

Copy link
Copy Markdown
Contributor

/lgtm

@patjlm

patjlm commented Jun 30, 2026

Copy link
Copy Markdown
Contributor Author

/approve

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 30, 2026
@cristianoveiga

Copy link
Copy Markdown
Contributor

/pj-rehearse ack

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@cristianoveiga: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-merge-bot openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jun 30, 2026
@cristianoveiga

Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jun 30, 2026
@patjlm

patjlm commented Jul 2, 2026

Copy link
Copy Markdown
Contributor Author

/retest

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

/retest-required

Remaining retests: 0 against base HEAD c25b193 and 2 for PR HEAD 8aa3e41 in total

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

/retest-required

Remaining retests: 0 against base HEAD 0b7a0cc and 1 for PR HEAD 8aa3e41 in total

@patjlm

patjlm commented Jul 2, 2026

Copy link
Copy Markdown
Contributor Author

/retest-required

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

/retest-required

Remaining retests: 0 against base HEAD 6d12dd2 and 0 for PR HEAD 8aa3e41 in total

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

/hold

Revision 8aa3e41 was retested 3 times: holding

@openshift-ci openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 2, 2026
The create, destroy, control-plane-setup, and hosted-cluster-setup
subdirectories had their own OWNERS files that were not updated.
Regenerated metadata to match.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@openshift-ci openshift-ci Bot added do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. and removed lgtm Indicates that a PR is ready to be merged. labels Jul 3, 2026
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@patjlm: no rehearsable tests are affected by this change

Note: If this PR includes changes to step registry files (ci-operator/step-registry/) and you expected jobs to be found, try rebasing your PR onto the base branch. This helps pj-rehearse accurately detect changes when the base branch has moved forward.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@patjlm

patjlm commented Jul 7, 2026

Copy link
Copy Markdown
Contributor Author

/retest

1 similar comment
@patjlm

patjlm commented Jul 7, 2026

Copy link
Copy Markdown
Contributor Author

/retest

@patjlm

patjlm commented Jul 7, 2026

Copy link
Copy Markdown
Contributor Author

/unhold

@openshift-ci openshift-ci Bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 7, 2026
@patjlm

patjlm commented Jul 7, 2026

Copy link
Copy Markdown
Contributor Author

/verify-owners

@cblecker

cblecker commented Jul 7, 2026

Copy link
Copy Markdown
Member

/lgtm

@openshift-ci openshift-ci Bot removed the do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. label Jul 7, 2026
@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jul 7, 2026
@openshift-ci

openshift-ci Bot commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cblecker, cristianoveiga, patjlm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci

openshift-ci Bot commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

@patjlm: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot
openshift-merge-bot Bot merged commit d12bd41 into openshift:main Jul 7, 2026
12 checks passed
SachinNinganure pushed a commit to SachinNinganure/release that referenced this pull request Jul 20, 2026
* Add floresroger to GCP HCP step-registry and CI OWNERS

GCP-866

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* Add floresroger to remaining GCP HCP step-registry OWNERS

The create, destroy, control-plane-setup, and hosted-cluster-setup
subdirectories had their own OWNERS files that were not updated.
Regenerated metadata to match.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants