Make kueue-operator upgrade presubmit jobs optional#81490
Conversation
Set always_run: false on all upgrade e2e tests across release-1.3 and release-1.4 variant configs so they only run when explicitly triggered via /test. These tests spin up AWS clusters and are expensive to run on every PR to the release branches. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
@sohankunkerkar: GitHub didn't allow me to request PR reviews from the following users: openshift/kueue. Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
openshift-ci
Bot
added
the
approved
|
Caution Review failedAn error occurred during the review process. Please try again later. WalkthroughThis PR adds Changesalways_run: false additions
Estimated code review effort: 1 (Trivial) | ~5 minutes Suggested labels: ✨ Finishing Touches🧪 Generate unit tests (beta)
Warning Tools execution failed with the following error: Failed to run tools: 13 INTERNAL: Received RST_STREAM with code 2 (Internal server error) Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
This PR reduces default CI load for openshift/kueue-operator release branches by making the AWS-backed upgrade presubmit jobs opt-in (manual /test …) instead of running on every PR to release-1.3 and release-1.4.
Changes:
- Set
always_run: falseon upgrade presubmit jobs in the Prow job definitions for release-1.3 and release-1.4. - Mark the corresponding upgrade test entries in the
ci-operatorvariant configs withalways_run: false(while keeping themoptional: true).
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| ci-operator/jobs/openshift/kueue-operator/openshift-kueue-operator-release-1.4-presubmits.yaml | Makes release-1.4 upgrade presubmits opt-in by setting always_run: false. |
| ci-operator/jobs/openshift/kueue-operator/openshift-kueue-operator-release-1.3-presubmits.yaml | Makes release-1.3 upgrade presubmits opt-in by setting always_run: false. |
| ci-operator/config/openshift/kueue-operator/openshift-kueue-operator-release-1.4__upgrade-from-4.22.yaml | Sets the upgrade test entry to always_run: false for the 4.22 variant. |
| ci-operator/config/openshift/kueue-operator/openshift-kueue-operator-release-1.4__upgrade-from-4.21.yaml | Sets both upgrade test entries to always_run: false for the 4.21 variant. |
| ci-operator/config/openshift/kueue-operator/openshift-kueue-operator-release-1.4__upgrade-from-4.20.yaml | Sets both upgrade test entries to always_run: false for the 4.20 variant. |
| ci-operator/config/openshift/kueue-operator/openshift-kueue-operator-release-1.4__upgrade-from-4.19.yaml | Sets both upgrade test entries to always_run: false for the 4.19 variant. |
| ci-operator/config/openshift/kueue-operator/openshift-kueue-operator-release-1.4__upgrade-from-4.18.yaml | Sets both upgrade test entries to always_run: false for the 4.18 variant. |
| ci-operator/config/openshift/kueue-operator/openshift-kueue-operator-release-1.3__upgrade-from-4.20.yaml | Sets the upgrade test entry to always_run: false for the 4.20 variant. |
| ci-operator/config/openshift/kueue-operator/openshift-kueue-operator-release-1.3__upgrade-from-4.19.yaml | Sets the upgrade test entry to always_run: false for the 4.19 variant. |
| ci-operator/config/openshift/kueue-operator/openshift-kueue-operator-release-1.3__upgrade-from-4.18.yaml | Sets the upgrade test entry to always_run: false for the 4.18 variant. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
[REHEARSALNOTIFIER]
Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals. Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
/pj-rehearse ack |
|
@sohankunkerkar: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
openshift-merge-bot
Bot
added
the
rehearsals-ack
|
@sohankunkerkar: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kannon92, sohankunkerkar The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Summary
always_run: falseon all 12 upgrade e2e tests across 8 variant configs (release-1.3 and release-1.4)/test <name>when neededTest plan
/test upgrade-from-4.XX-.../cc @openshift/kueue
🤖 Generated with Claude Code
Summary by CodeRabbit
This PR updates the OpenShift CI configuration for the
openshift/kueue-operatorrelease branches so several upgrade-focused presubmit jobs no longer run automatically on every pull request.In practical terms, the affected AWS-backed upgrade e2e and operator upgrade tests for
release-1.3andrelease-1.4are now markedalways_run: false, making them optional by default while still allowing manual execution with/testwhen needed. This reduces unnecessary CI load and avoids running expensive cluster-based upgrade checks on every PR to those branches.