CONSOLE-5422: Add TechPreview e2e CI jobs for openshift/console - #81559
Conversation
perdasilva
changed the title
|
/hold for console ccsig review of the idea in the first place XD |
openshift-ci-robot
added
the
jira/valid-reference
|
@perdasilva: This pull request explicitly references no jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
Bot
added
the
do-not-merge/hold
WalkthroughThis PR adds two optional TechPreview GCP IPI console e2e jobs: ChangesConsole TechPreview e2e jobs
Estimated code review effort: 1 (Trivial) | ~3 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
@perdasilva: |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@ci-operator/config/openshift/console/openshift-console-main.yaml`:
- Around line 134-160: The e2e-gcp-console-techpreview job is still
auto-triggering on non-doc changes because its skip_if_only_changed filter only
exempts docs and ignores the manual-only intent. Update the job definition for
e2e-gcp-console-techpreview in the console config so it does not auto-run unless
explicitly invoked, removing or changing the skip_if_only_changed path filter
accordingly while keeping the rest of the job setup intact.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: d2c96baf-1ecf-4587-949c-379fa7b99947
⛔ Files ignored due to path filters (1)
ci-operator/jobs/openshift/console/openshift-console-main-presubmits.yamlis excluded by!ci-operator/jobs/**
📒 Files selected for processing (1)
ci-operator/config/openshift/console/openshift-console-main.yaml
|
/assign @fsgreco |
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
fsgreco
left a comment
fsgreco
left a comment
There was a problem hiding this comment.
maybe this solves also the problem pointed out by coderabbit
507598f to
4893baa
Compare
perdasilva
changed the title
|
@perdasilva: This pull request references CONSOLE-5422 which is a valid jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/unhold |
openshift-ci
Bot
removed
the
do-not-merge/hold
4893baa to
804a4ce
Compare
|
/pj-rehearse |
|
@perdasilva: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/retest |
|
/pj-rehearse |
|
@perdasilva: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse |
|
@perdasilva: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse |
|
@perdasilva: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
Add e2e-gcp-console-techpreview and e2e-playwright-techpreview presubmit jobs that provision clusters with the TechPreviewNoUpgrade feature set. Both jobs are optional and can be triggered manually via /test commands on PRs. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Per G. da Silva <pegoncal@redhat.com>
cd23af1 to
7b6a4be
Compare
|
[REHEARSALNOTIFIER]
Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fsgreco, perdasilva, TheRealJon The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
|
/pj-rehearse |
|
@TheRealJon: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
@perdasilva: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/pj-rehearse ack |
|
@perdasilva: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
openshift-merge-bot
Bot
added
the
rehearsals-ack
Add e2e-gcp-console-techpreview and e2e-playwright-techpreview presubmit jobs that provision clusters with the TechPreviewNoUpgrade feature set. Both jobs are optional and can be triggered manually via /test commands on PRs. Signed-off-by: Per G. da Silva <pegoncal@redhat.com> Co-authored-by: Per G. da Silva <pegoncal@redhat.com> Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Add e2e-gcp-console-techpreview and e2e-playwright-techpreview presubmit jobs that provision clusters with the TechPreviewNoUpgrade feature set. Both jobs are optional and can be triggered manually via /test commands on PRs. Signed-off-by: Per G. da Silva <pegoncal@redhat.com> Co-authored-by: Per G. da Silva <pegoncal@redhat.com> Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
4 participants
Summary
e2e-gcp-console-techpreviewpresubmit job that runs Cypress e2e tests against a GCP cluster provisioned with theTechPreviewNoUpgradefeature sete2e-playwright-techpreviewpresubmit job that runs Playwright e2e tests against a GCP cluster provisioned with theTechPreviewNoUpgradefeature set/test e2e-gcp-console-techpreviewand/test e2e-playwright-techpreviewDetails
These jobs mirror the existing
e2e-gcp-consoleande2e-playwrightjobs respectively, with the addition ofFEATURE_SET: TechPreviewNoUpgradein the step environment. This causes the IPI installer to enable the TechPreview feature gate on the cluster, which the console auto-detects via the cluster'sFeatureGateresource.Test plan
ci-operator-prowgencheck passes/test e2e-gcp-console-techpreviewon an openshift/console PR/test e2e-playwright-techpreviewon an openshift/console PRSummary by CodeRabbit
This PR updates the
openshift/releaseCI (ci-operator/prowgen config foropenshift/console) to add two optional, manually triggered TechPreview e2e jobs that run against a GCP IPI cluster withFEATURE_SET: TechPreviewNoUpgrade:e2e-gcp-console-techpreview(Cypress): runs./test-prow-e2e.shusing the existingopenshift-org-gcpcluster profile andconsole-plugin-demodependency, sourcing tests fromsrc.e2e-playwright-techpreview(Playwright): runs./test-prow-playwright-e2e.shusing the existingopenshift-org-gcpcluster profile andconsole-plugin-demodependency, sourcing tests fromconsole-playwright-runner.Both jobs mirror the existing
e2e-gcp-console/e2e-playwrightjobs’ configuration/behavior, and can be triggered on PRs via:/test e2e-gcp-console-techpreview/test e2e-playwright-techpreview