Skip to content

Add Prow periodic for OSDFM stage basic periodic tests - #81563

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
anfranci14:ROSAENG-60428-osdfm-periodic-ci-tests-stage-migration
Jul 29, 2026
Merged

Add Prow periodic for OSDFM stage basic periodic tests#81563
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
anfranci14:ROSAENG-60428-osdfm-periodic-ci-tests-stage-migration

Conversation

@anfranci14

@anfranci14 anfranci14 commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

Migrate OSDFM stage periodic CI from Jenkins (osdfm-periodic-ci-tests-stage) to Prow by adding a new ocm-fvt-osdfm-staging ci-operator variant.

Prow

Setting Value
Prow job periodic-ci-openshift-online-rosa-e2e-main-ocm-fvt-osdfm-staging-ocm-fvt-periodic-osdfm-basic-periodic-stage
ci-operator target ocm-fvt-periodic-osdfm-basic-periodic-stage
Variant ocm-fvt-osdfm-staging
Cron 0 9 * * 1 (aligned with app-interface)
Step ref rosa-e2e-ocm-fvt-longrunning (12h step timeout)
Test timeout 10h0m0s
Env OCM_FVT_JOB_NAME=osdfm-basic-periodic-stage, OCM_FVT_OCM_ENV=stage, OCM_FVT_SERVICE=osdfm

Uses rosa-e2e-ocm-fvt-longrunning (from ROSAENG-60420) so the step is not killed at the shared 5h rosa-e2e-ocm-fvt limit while Ginkgo allows up to 10h.

Files changed

  • ci-operator/config/openshift-online/rosa-e2e/openshift-online-rosa-e2e-main__ocm-fvt-osdfm-staging.yaml — new variant config
  • ci-operator/jobs/openshift-online/rosa-e2e/openshift-online-rosa-e2e-main-periodics.yaml — generated periodic job (make update)

Summary by CodeRabbit

This PR migrates the openshift-online/rosa-e2e OSDFM staging periodic CI job from Jenkins to Prow by adding a new ocm-fvt-osdfm-staging ci-operator variant and generating the corresponding periodic Prow job.

Concretely, it introduces ci-operator/config/openshift-online/rosa-e2e/openshift-online-rosa-e2e-main__ocm-fvt-osdfm-staging.yaml defining a weekly cron job (0 9 * * 1) that runs the rosa-e2e-ocm-fvt-longrunning step with a 12-hour step timeout and a 10-hour test timeout. The job targets the stage environment (OCM_FVT_OCM_ENV=stage), sets the OSDFM service (OCM_FVT_SERVICE=osdfm), and passes the job name (OCM_FVT_JOB_NAME=osdfm-basic-periodic-stage), enabling nested-podman for execution. The generated periodic jobs metadata is updated for branch main in openshift-online/rosa-e2e under the new variant.

CI rehearsal/testing notes: two pj-rehearse runs for the new periodic job passed; gdbranco posted /lgtm, /approve, and /pj-rehearse ack, then later posted /approve cancel. anfranci14 subsequently posted /pj-rehearse reject.

@coderabbitai

coderabbitai Bot commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: c34ba953-2785-4840-90bd-7e5d2670d4d3

📥 Commits

Reviewing files that changed from the base of the PR and between 95b19eb and 7bb8f4e.

⛔ Files ignored due to path filters (1)
  • ci-operator/jobs/openshift-online/rosa-e2e/openshift-online-rosa-e2e-main-periodics.yaml is excluded by !ci-operator/jobs/**
📒 Files selected for processing (1)
  • ci-operator/config/openshift-online/rosa-e2e/openshift-online-rosa-e2e-main__ocm-fvt-osdfm-staging.yaml
🚧 Files skipped from review as they are similar to previous changes (1)
  • ci-operator/config/openshift-online/rosa-e2e/openshift-online-rosa-e2e-main__ocm-fvt-osdfm-staging.yaml

Walkthrough

Adds a ROSA E2E CI Operator configuration for an OCM FVT staging job with image, release, resource, scheduling, environment, timeout, source ref, and metadata settings.

Changes

ROSA E2E OCM FVT Staging Job

Layer / File(s) Summary
Job image, release, and resource configuration
ci-operator/config/openshift-online/rosa-e2e/openshift-online-rosa-e2e-main__ocm-fvt-osdfm-staging.yaml
Defines the nested-podman base image, builder image stream tag, OCP 4.22 nightly candidate, and wildcard resource limits and requests.
Scheduled OCM FVT execution
ci-operator/config/openshift-online/rosa-e2e/openshift-online-rosa-e2e-main__ocm-fvt-osdfm-staging.yaml
Adds the weekly OSDFM staging test with stage environment variables, disabled Jira reporting, the long-running ref, a 10-hour timeout, and generated metadata.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Possibly related PRs

Suggested labels: approved, rehearsals-ack

Suggested reviewers: dustman9000, tiwillia

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: adding a Prow periodic job for OSDFM stage basic periodic tests.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed No Ginkgo test titles were added or changed; the PR only adds static ci-operator job/config names, all deterministic.
Test Structure And Quality ✅ Passed The commit only adds ci-operator YAML config files; no Ginkgo test code or test blocks were changed, so this check is not applicable.
Microshift Test Compatibility ✅ Passed Only ci-operator YAML/job wiring changed; no new in-repo Ginkgo test code or MicroShift-relevant API usage was added, so the check is not applicable.
Single Node Openshift (Sno) Test Compatibility ✅ Passed PR only adds ci-operator YAML/periodic job config; no new Ginkgo test code or SNO-sensitive assumptions were introduced, so the check is not applicable.
Topology-Aware Scheduling Compatibility ✅ Passed The PR only adds ci-operator job/config YAML; the new job stanza has no nodeSelector, affinity, tolerations, spread constraints, or replica logic.
Ote Binary Stdout Contract ✅ Passed PR changes only ci-operator YAML; no main/TestMain/suite code or stdout writes were added.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed PASS: PR only adds ci-operator YAML and a generated periodic job; no new Ginkgo test code or IPv4/public-host assumptions were introduced.
No-Weak-Crypto ✅ Passed Changed files are YAML job configs only; targeted scans found no MD5/SHA1/DES/RC4/3DES/Blowfish/ECB or custom crypto usage.
Container-Privileges ✅ Passed The new variant and generated periodic job contain no privileged, hostPID/Network/IPC, allowPrivilegeEscalation, or SYS_ADMIN settings.
No-Sensitive-Data-In-Logs ✅ Passed Only CI YAML was added; no logging statements or literal secrets, tokens, PII, or internal hostnames appear in the touched files.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@openshift-ci
openshift-ci Bot requested review from dustman9000 and tiwillia July 7, 2026 14:34
@anfranci14

Copy link
Copy Markdown
Contributor Author

/pj-rehearse periodic-ci-openshift-online-rosa-e2e-main-ocm-fvt-osdfm-staging-ocm-fvt-periodic-osdfm-basic-periodic-stage

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@anfranci14: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@anfranci14

Copy link
Copy Markdown
Contributor Author

rehearsal 1 passed

@anfranci14

Copy link
Copy Markdown
Contributor Author

/pj-rehearse periodic-ci-openshift-online-rosa-e2e-main-ocm-fvt-osdfm-staging-ocm-fvt-periodic-osdfm-basic-periodic-stage

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@anfranci14: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@anfranci14

Copy link
Copy Markdown
Contributor Author

second rehearsal passed

@gdbranco

gdbranco commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

/lgtm

/approve

/pj-rehearse ack

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@gdbranco: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-merge-bot openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jul 8, 2026
@openshift-ci openshift-ci Bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 8, 2026
@gdbranco

gdbranco commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

/approve cancel

@openshift-ci openshift-ci Bot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 8, 2026
@anfranci14

Copy link
Copy Markdown
Contributor Author

/pj-rehearse reject

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@anfranci14: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-merge-bot openshift-merge-bot Bot removed the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jul 8, 2026
@anfranci14
anfranci14 force-pushed the ROSAENG-60428-osdfm-periodic-ci-tests-stage-migration branch from c2ad3a8 to d01f91f Compare July 9, 2026 16:06
@openshift-ci openshift-ci Bot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed lgtm Indicates that a PR is ready to be merged. labels Jul 9, 2026
@anfranci14
anfranci14 force-pushed the ROSAENG-60428-osdfm-periodic-ci-tests-stage-migration branch from d01f91f to 95b19eb Compare July 27, 2026 16:23
@openshift-ci openshift-ci Bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 27, 2026
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@anfranci14, pj-rehearse: unable to determine affected jobs. This could be due to a branch that needs to be rebased. ERROR:

could not load configuration from candidate revision of release repo: failed to load Prow configuration from release repo: [invalid periodic job : name: must match regex "^[A-Za-z0-9-._]+$", at least one of cron, interval, or minimum_interval must be set in periodic ]
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@anfranci14
anfranci14 force-pushed the ROSAENG-60428-osdfm-periodic-ci-tests-stage-migration branch from 95b19eb to 7bb8f4e Compare July 27, 2026 16:44
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@anfranci14: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
periodic-ci-openshift-online-rosa-e2e-main-ocm-fvt-osdfm-staging-ocm-fvt-periodic-osdfm-basic-periodic-stage N/A periodic Periodic changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@dustman9000

Copy link
Copy Markdown
Member

/approve

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 27, 2026
@anfranci14

Copy link
Copy Markdown
Contributor Author

/hold

@openshift-ci openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 27, 2026
@jfrazierRedHat

Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jul 27, 2026
@openshift-ci

openshift-ci Bot commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: anfranci14, dustman9000, jfrazierRedHat

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@anfranci14

Copy link
Copy Markdown
Contributor Author

/pj-rehearse periodic-ci-openshift-online-rosa-e2e-main-ocm-fvt-osdfm-staging-ocm-fvt-periodic-osdfm-basic-periodic-stage

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@anfranci14: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@anfranci14

anfranci14 commented Jul 28, 2026

Copy link
Copy Markdown
Contributor Author

#81563 (comment)
This rehearsal failed not due to test bug/ OSDFM bug , but slowness of AAO reported here : https://redhat-internal.slack.com/archives/C0A8S4L99C2/p1785257414419359

Will try a rerun after Prod rollout

@anfranci14

Copy link
Copy Markdown
Contributor Author

/pj-rehearse periodic-ci-openshift-online-rosa-e2e-main-ocm-fvt-osdfm-staging-ocm-fvt-periodic-osdfm-basic-periodic-stage

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@anfranci14: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@anfranci14

Copy link
Copy Markdown
Contributor Author

rehearsal passed

@anfranci14

Copy link
Copy Markdown
Contributor Author

/pj-rehearse ack

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@anfranci14: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-merge-bot openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jul 29, 2026
@anfranci14

Copy link
Copy Markdown
Contributor Author

/unhold

@openshift-ci openshift-ci Bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 29, 2026
@openshift-ci

openshift-ci Bot commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

@anfranci14: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot
openshift-merge-bot Bot merged commit da8fd20 into openshift:main Jul 29, 2026
17 checks passed
enxebre pushed a commit to enxebre/release that referenced this pull request Jul 29, 2026
dustman9000 added a commit to openshift-online/rosa-e2e that referenced this pull request Jul 29, 2026
New OCM FVT OSDFM STG category tracking the OSDFM basic periodic
staging job migrated to Prow in openshift/release#81563.
amogh-redhat pushed a commit to amogh-redhat/release that referenced this pull request Aug 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants