Skip to content

CLID-681: oc-mirror: add periodic m2m e2e tests#81608

Open
r4f4 wants to merge 1 commit into
openshift:mainfrom
r4f4:oc-mirror-e2e-m2m-disconnected
Open

CLID-681: oc-mirror: add periodic m2m e2e tests#81608
r4f4 wants to merge 1 commit into
openshift:mainfrom
r4f4:oc-mirror-e2e-m2m-disconnected

Conversation

@r4f4

@r4f4 r4f4 commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

These tests are needed for the oc-mirror's test matrix.

Summary by CodeRabbit

Adds periodic oc-mirror CI coverage for machine-to-machine disconnected E2E testing across the oc-mirror repo’s main and release branches. These new generated CI configs define weekly scheduled jobs that exercise oc-mirror with the openshift-e2e-aws-disconnected workflow, using ENABLE_IDMS and repo-sourced release images to support the oc-mirror test matrix for current and upcoming OpenShift releases.

@coderabbitai

coderabbitai Bot commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 284bea46-7ac7-4bf2-8f60-090518aa7d4b

📥 Commits

Reviewing files that changed from the base of the PR and between 25b94ee and c62a652.

⛔ Files ignored due to path filters (4)
  • ci-operator/jobs/openshift/oc-mirror/openshift-oc-mirror-main-periodics.yaml is excluded by !ci-operator/jobs/**
  • ci-operator/jobs/openshift/oc-mirror/openshift-oc-mirror-release-4.21-periodics.yaml is excluded by !ci-operator/jobs/**
  • ci-operator/jobs/openshift/oc-mirror/openshift-oc-mirror-release-4.22-periodics.yaml is excluded by !ci-operator/jobs/**
  • ci-operator/jobs/openshift/oc-mirror/openshift-oc-mirror-release-4.23-periodics.yaml is excluded by !ci-operator/jobs/**
📒 Files selected for processing (4)
  • ci-operator/config/openshift/oc-mirror/openshift-oc-mirror-main__periodics.yaml
  • ci-operator/config/openshift/oc-mirror/openshift-oc-mirror-release-4.21__periodics.yaml
  • ci-operator/config/openshift/oc-mirror/openshift-oc-mirror-release-4.22__periodics.yaml
  • ci-operator/config/openshift/oc-mirror/openshift-oc-mirror-release-4.23__periodics.yaml

Walkthrough

This PR adds four new OpenShift oc-mirror periodic CI configuration files (main, release-4.21, release-4.22, release-4.23). Each defines build_root, disabled promotion targets, nightly release candidates, default resource limits/requests, a new scheduled e2e-aws-m2m-disconnected test workflow, and generated metadata.

Changes

oc-mirror periodic CI configurations

Layer / File(s) Summary
Main branch periodic config
ci-operator/config/openshift/oc-mirror/openshift-oc-mirror-main__periodics.yaml
Adds build_root, disabled promotion, nightly OCP 5.0 initial/latest candidates, default resource limits/requests, weekly e2e-aws-m2m-disconnected test with ENABLE_IDMS/MIRROR_BIN env vars, and generated metadata.
Release-4.21 periodic config
ci-operator/config/openshift/oc-mirror/openshift-oc-mirror-release-4.21__periodics.yaml
Adds build_root, disabled 4.21 promotion target, nightly 4.21 candidates, resource defaults, e2e-aws-m2m-disconnected test, and metadata.
Release-4.22 periodic config
ci-operator/config/openshift/oc-mirror/openshift-oc-mirror-release-4.22__periodics.yaml
Adds build_root, disabled 4.22 promotion target, nightly 4.22 candidates, resource defaults, e2e-aws-m2m-disconnected test, and metadata.
Release-4.23 periodic config
ci-operator/config/openshift/oc-mirror/openshift-oc-mirror-release-4.23__periodics.yaml
Adds build_root, disabled 4.23 promotion target, nightly 4.23 candidates, resource defaults, e2e-aws-m2m-disconnected test, and metadata.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Suggested labels: lgtm, approved

Suggested reviewers: AlexNPavel, stbenjam

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly matches the main change: adding periodic machine-to-machine e2e tests for oc-mirror.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed The patch only adds CI periodic YAML; no Ginkgo It/Describe/Context/When titles or dynamic test-name strings were introduced.
Test Structure And Quality ✅ Passed PASS: PR only adds ci-operator periodic config and generated job YAML; there is no Ginkgo test code to review, so the checklist is not applicable.
Microshift Test Compatibility ✅ Passed Only generated CI/job YAML changed; no new Ginkgo test code or MicroShift-sensitive API use was added.
Single Node Openshift (Sno) Test Compatibility ✅ Passed Only ci-operator periodic configs were added; they invoke an existing workflow and add no new Ginkgo tests to assess for SNO assumptions.
Topology-Aware Scheduling Compatibility ✅ Passed The patch only adds ci-operator periodic YAMLs; no deployment manifests, replicas, node selectors, affinity, or topology spread constraints are introduced.
Ote Binary Stdout Contract ✅ Passed Only ci-operator YAML/job config was added; no source code or process-level stdout writes were changed.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed PR only adds periodic CI/job YAML; no new Ginkgo test code or network logic was introduced, so the IPv6/disconnected check is not applicable.
No-Weak-Crypto ✅ Passed Changed YAML only adds periodic CI config; no MD5/SHA1/DES/RC4/3DES/Blowfish/ECB, custom crypto, or secret comparisons found.
Container-Privileges ✅ Passed No added oc-mirror periodic config sets privileged, hostPID/Network/IPC, SYS_ADMIN, runAsRoot, or allowPrivilegeEscalation.
No-Sensitive-Data-In-Logs ✅ Passed The added YAML only defines CI test config and metadata; no logging code, secrets, tokens, PII, or hostnames were introduced.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@openshift-ci

openshift-ci Bot commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: r4f4

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
openshift-ci Bot requested review from adolfo-ab and dorzel July 8, 2026 12:46
@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 8, 2026
@r4f4

r4f4 commented Jul 8, 2026

Copy link
Copy Markdown
Contributor Author

/retitle CLID-681: oc-mirror: add periodic m2m e2e tests

@openshift-ci openshift-ci Bot changed the title oc-mirror: add periodic m2m e2e tests CLID-681: oc-mirror: add periodic m2m e2e tests Jul 8, 2026
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 8, 2026
@openshift-ci-robot

openshift-ci-robot commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

@r4f4: This pull request references CLID-681 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set.

Details

In response to this:

These tests are needed for the oc-mirror's test matrix.

Summary by CodeRabbit

Adds periodic oc-mirror CI coverage for machine-to-machine disconnected E2E testing across the oc-mirror repo’s main and release branches. These new generated CI configs define weekly scheduled jobs that exercise oc-mirror with the openshift-e2e-aws-disconnected workflow, using ENABLE_IDMS and repo-sourced release images to support the oc-mirror test matrix for current and upcoming OpenShift releases.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@r4f4
r4f4 force-pushed the oc-mirror-e2e-m2m-disconnected branch from c62a652 to 18caf0e Compare July 8, 2026 12:58
@r4f4

r4f4 commented Jul 8, 2026

Copy link
Copy Markdown
Contributor Author

/pj-rehearse periodic-ci-openshift-oc-mirror-main-periodics-e2e-aws-m2m-disconnected

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@r4f4: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@r4f4

r4f4 commented Jul 9, 2026

Copy link
Copy Markdown
Contributor Author

/pj-rehearse periodic-ci-openshift-oc-mirror-main-periodics-e2e-aws-m2m-disconnected

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@r4f4: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

These tests are needed for the oc-mirror's test matrix.
@r4f4
r4f4 force-pushed the oc-mirror-e2e-m2m-disconnected branch from 18caf0e to f859b11 Compare July 9, 2026 13:57
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@r4f4: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
periodic-ci-openshift-oc-mirror-release-4.22-periodics-e2e-aws-m2m-disconnected N/A periodic Periodic changed
periodic-ci-openshift-oc-mirror-release-4.23-periodics-e2e-aws-m2m-disconnected N/A periodic Periodic changed
periodic-ci-openshift-oc-mirror-main-periodics-e2e-aws-m2m-disconnected N/A periodic Periodic changed
periodic-ci-openshift-oc-mirror-release-4.21-periodics-e2e-aws-m2m-disconnected N/A periodic Periodic changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@r4f4

r4f4 commented Jul 9, 2026

Copy link
Copy Markdown
Contributor Author

/pj-rehearse periodic-ci-openshift-oc-mirror-main-periodics-e2e-aws-m2m-disconnected

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@r4f4: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@r4f4

r4f4 commented Jul 10, 2026

Copy link
Copy Markdown
Contributor Author

/pj-rehearse periodic-ci-openshift-oc-mirror-release-4.22-periodics-e2e-aws-m2m-disconnected

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@r4f4: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@r4f4

r4f4 commented Jul 10, 2026

Copy link
Copy Markdown
Contributor Author

/pj-rehearse periodic-ci-openshift-oc-mirror-release-4.22-periodics-e2e-aws-m2m-disconnected

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@r4f4: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@r4f4

r4f4 commented Jul 13, 2026

Copy link
Copy Markdown
Contributor Author

/pj-rehearse periodic-ci-openshift-oc-mirror-release-4.22-periodics-e2e-aws-m2m-disconnected

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@r4f4: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@r4f4

r4f4 commented Jul 14, 2026

Copy link
Copy Markdown
Contributor Author

/pj-rehearse periodic-ci-openshift-oc-mirror-release-4.22-periodics-e2e-aws-m2m-disconnected

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@r4f4: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci

openshift-ci Bot commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

@r4f4: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/periodic-ci-openshift-oc-mirror-main-periodics-e2e-aws-m2m-disconnected f859b11 link unknown /pj-rehearse periodic-ci-openshift-oc-mirror-main-periodics-e2e-aws-m2m-disconnected
ci/rehearse/periodic-ci-openshift-oc-mirror-release-4.22-periodics-e2e-aws-m2m-disconnected f859b11 link unknown /pj-rehearse periodic-ci-openshift-oc-mirror-release-4.22-periodics-e2e-aws-m2m-disconnected

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@r4f4

r4f4 commented Jul 17, 2026

Copy link
Copy Markdown
Contributor Author

/pj-rehearse periodic-ci-openshift-oc-mirror-release-4.22-periodics-e2e-aws-m2m-disconnected

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@r4f4: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants