OCPBUGS-98102: Update Azure install-config for DualStack - #81697
Conversation
When DualStack is enabled, make the IPv6 machine network's address prefix to be the recommended /56 in the install-config customization step.
|
@sadasu: This pull request references Jira Issue OCPBUGS-98102, which is valid. 3 validation(s) were run on this bug
The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (6)
✅ Files skipped from review due to trivial changes (3)
WalkthroughAzure dual-stack networking now uses an IPv6 ChangesAzure configuration updates
Estimated code review effort: 1 (Trivial) | ~2 minutes Suggested labels: 🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
/approve |
|
/pj-rehearse |
|
@rna-afk: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/test e2e-azure-ovn-dualstack-ipv6-primary-techpreview |
|
/pj-rehearse pull-ci-openshift-installer-main-e2e-azure-ovn-dualstack-ipv6-primary-techpreview |
|
@tthvo: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse pull-ci-openshift-installer-main-e2e-azure-ovn-dualstack-ipv4-primary-techpreview |
|
@tthvo: your |
|
/pj-rehearse pull-ci-openshift-installer-main-e2e-azure-ovn-dualstack-ipv4-primary-techpreview |
|
@tthvo: your |
|
/pj-rehearse pull-ci-openshift-installer-main-e2e-azure-ovn-dualstack-ipv4-primary-techpreview |
|
@tthvo: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse pull-ci-openshift-installer-main-e2e-azure-ovn-dualstack-ipv4-primary-techpreview |
|
@rna-afk: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
@rna-afk: requesting more than one rehearsal in one comment is not supported. If you would like to rehearse multiple specific jobs, please separate the job names by a space in a single command. |
|
/pj-rehearse ack |
|
@rna-afk the failures in the dualstack jobs are expected. This PR is ready to merge as is to continue our testing. |
|
sounds good /lgtm |
|
/retest |
Keeping this list current.
d12779f to
962af4f
Compare
|
[REHEARSALNOTIFIER]
A total of 4915 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs. A full list of affected jobs can be found here Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
/lgtm |
|
/pj-rehearse ack The dualstack jobs are not expected to pass and the other jobs are unaffected by this change. |
|
@sadasu: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: patrickdillon, rna-afk, sadasu The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@sadasu: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
@sadasu: Jira Issue OCPBUGS-98102: Some pull requests linked via external trackers have merged: The following pull request, linked via external tracker, has not merged:
All associated pull requests must be merged or unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with Jira Issue OCPBUGS-98102 has not been moved to the MODIFIED state. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
…1697) * OCPBUGS-98102: Update Azure install-config for DualStack When DualStack is enabled, make the IPv6 machine network's address prefix to be the recommended /56 in the install-config customization step. * Generate step-registry metadata * Update Azure platform's step-registry owner's list Keeping this list current.
When DualStack is enabled, make the IPv6 machine network's address prefix to be the recommended /56 in the install-config customization step.
Summary by CodeRabbit
Updated OpenShift CI’s Azure IPI step-registry configuration so that DualStack installs use the recommended IPv6
/56prefix. Specifically, whenIP_FAMILYis enabled, the generatedinstall-config.yamlnow sets the IPv6machineNetworkCIDR fromfd00::/64tofd00::/56, affecting the Azure network settings for DualStack cluster provisioning.Also refreshed the Azure step-registry ownership metadata by updating the
OWNERSapprovers list and mirroring that change across the related Azure identity/chain/ref and sharednetwork ref/chain metadata.