Skip to content

openshift/os: add YUM_REPO_NAMES and EXTENSIONS_YUM_REPO_NAMES to extensions images#81704

Merged
openshift-merge-bot[bot] merged 2 commits into
openshift:mainfrom
dustymabe:dusty-os-yum-repos
Jul 9, 2026
Merged

openshift/os: add YUM_REPO_NAMES and EXTENSIONS_YUM_REPO_NAMES to extensions images#81704
openshift-merge-bot[bot] merged 2 commits into
openshift:mainfrom
dustymabe:dusty-os-yum-repos

Conversation

@dustymabe

@dustymabe dustymabe commented Jul 9, 2026

Copy link
Copy Markdown
Member

openshift/os#1945 refactors the extensions build to use dnf download
instead of rpm-ostree compose. The extensions Containerfile now
requires two build args:

  • YUM_REPO_NAMES: base repos (same as the node image build)
  • EXTENSIONS_YUM_REPO_NAMES: additional repos needed only for
    extensions (highavailability for two-node-ha, nfv for kernel-rt)

The build script combines them at runtime:
repo_list="${YUM_REPO_NAMES},${EXTENSIONS_YUM_REPO_NAMES}"

Add both build args to all extensions image definitions.

Assisted-by: <anthropic/claude-opus-4.6>

Obsoletes #81446

Summary by CodeRabbit

This updates OpenShift CI release and master configs for openshift/os so extensions image builds receive the new repository inputs required by the revised build flow. In practice, the affected CI jobs now pass both the base YUM_REPO_NAMES and the extensions-only EXTENSIONS_YUM_REPO_NAMES values, allowing builds for high-availability and NFV extensions to resolve repos correctly across the supported RHEL 9, RHEL 10, and OKD SCOS variants.

It also updates the OKD SCOS node image configuration to use the new non-mirror CentOS stream repository names, matching the upstream c10s.repo change and removing reliance on the old *-mirror repo naming.

dustymabe added 2 commits July 9, 2026 13:35
…names

The openshift/os repo switched its c10s.repo to point directly at
mirror.stream.centos.org URLs (commit 64af4d8 in openshift/os#1945),
making the separate c10s-mirror.repo and its -mirror suffixed repo
names obsolete. Update YUM_REPO_NAMES for the stream-coreos node
image build to match: c10s-baseos and c10s-appstream instead of
c10s-baseos-mirror and c10s-appstream-mirror.

Assisted-by: <anthropic/claude-opus-4.6>
…ensions images

openshift/os#1945 refactors the extensions build to use dnf download
instead of rpm-ostree compose. The extensions Containerfile now
requires two build args:

- YUM_REPO_NAMES: base repos (same as the node image build)
- EXTENSIONS_YUM_REPO_NAMES: additional repos needed only for
  extensions (highavailability for two-node-ha, nfv for kernel-rt)

The build script combines them at runtime:
  repo_list="${YUM_REPO_NAMES},${EXTENSIONS_YUM_REPO_NAMES}"

Add both build args to all extensions image definitions.

Assisted-by: <anthropic/claude-opus-4.6>
@dustymabe

Copy link
Copy Markdown
Member Author

/pj-rehearse auto-ack

@coderabbitai

coderabbitai Bot commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 2758d09d-b00a-458d-95c5-59e90f35ace2

📥 Commits

Reviewing files that changed from the base of the PR and between 1163483 and 37c23c2.

📒 Files selected for processing (5)
  • ci-operator/config/openshift/os/openshift-os-master.yaml
  • ci-operator/config/openshift/os/openshift-os-master__okd-scos.yaml
  • ci-operator/config/openshift/os/openshift-os-release-4.23.yaml
  • ci-operator/config/openshift/os/openshift-os-release-5.0.yaml
  • ci-operator/config/openshift/os/openshift-os-release-5.1.yaml

Walkthrough

This PR adds EXTENSIONS_YUM_REPO_NAMES build arguments alongside existing YUM_REPO_NAMES across multiple OpenShift CI operator configuration files for openshift/os (master, master__okd-scos, release-4.23, release-5.0, release-5.1), supplying additional repository lists for extensions image builds. One config also updates a YUM_REPO_NAMES value from a mirror to non-mirror repo list.

Changes

Extensions repo build args

Layer / File(s) Summary
Master config extensions build args
ci-operator/config/openshift/os/openshift-os-master.yaml
Adds EXTENSIONS_YUM_REPO_NAMES for RHEL 9 and RHEL 10 extension image builds.
OKD SCOS extensions build args and repo list change
ci-operator/config/openshift/os/openshift-os-master__okd-scos.yaml
Changes YUM_REPO_NAMES from mirror to non-mirror repo list and adds EXTENSIONS_YUM_REPO_NAMES for the stream-coreos extensions build.
Release 4.23 extensions build args
ci-operator/config/openshift/os/openshift-os-release-4.23.yaml
Adds EXTENSIONS_YUM_REPO_NAMES for RHEL CoreOS 9.8 and 10.2 build variants.
Release 5.0 extensions build args
ci-operator/config/openshift/os/openshift-os-release-5.0.yaml
Adds EXTENSIONS_YUM_REPO_NAMES for rhel-9 and rhel-10 based image builds.
Release 5.1 extensions build args
ci-operator/config/openshift/os/openshift-os-release-5.1.yaml
Adds EXTENSIONS_YUM_REPO_NAMES for RHEL-coreos 9.8 and RHEL-coreos-10 10.2 image builds.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Possibly related PRs

  • openshift/release#81643: Both PRs modify the OKD SCOS OS master build configuration in ci-operator/config/openshift/os/openshift-os-master__okd-scos.yaml, specifically the build_args repo list values.

Suggested labels: lgtm, approved

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: adding the two build args to extensions images.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed Only ci-operator YAML configs changed; no Ginkgo test titles or test files were modified.
Test Structure And Quality ✅ Passed The PR only changes ci-operator YAML configs; no Ginkgo or test code was modified, so this test-quality check is not applicable.
Microshift Test Compatibility ✅ Passed Only ci-operator YAML build args changed; no new Ginkgo e2e tests or test code were added, so MicroShift compatibility is not implicated.
Single Node Openshift (Sno) Test Compatibility ✅ Passed Only ci-operator YAML build args changed; no Ginkgo/e2e tests or SNO-sensitive test logic were added or modified.
Topology-Aware Scheduling Compatibility ✅ Passed Only ci-operator build-arg YAML changed; no pod scheduling fields, replicas, affinity, node selectors, or PDBs were added.
Ote Binary Stdout Contract ✅ Passed Only ci-operator YAML build-arg config changed; no main/init/TestMain/suite code or stdout writes were modified.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed No Ginkgo/e2e test code was added or modified; the PR only updates ci-operator YAML build args, so IPv4/disconnected test compatibility is not applicable.
No-Weak-Crypto ✅ Passed Touched YAML only adds YUM repo build args; scans found no MD5/SHA1/DES/RC4/3DES/Blowfish/ECB, custom crypto, or secret comparisons.
Container-Privileges ✅ Passed Diff only adds YUM_REPO_NAMES/EXTENSIONS_YUM_REPO_NAMES build args; no privileged, hostPID/Network/IPC, SYS_ADMIN, or allowPrivilegeEscalation settings found.
No-Sensitive-Data-In-Logs ✅ Passed Touched files are CI config YAML only; no logging statements or secret-like strings were added, and the new args are repo lists, not sensitive data.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@openshift-ci openshift-ci Bot requested review from jmarrero and yasminvalim July 9, 2026 17:38
@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 9, 2026
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@dustymabe: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-os-release-5.1-e2e-aws openshift/os presubmit Ci-operator config changed
pull-ci-openshift-os-release-5.1-images openshift/os presubmit Ci-operator config changed
pull-ci-openshift-os-master-okd-scos-e2e-aws-ovn openshift/os presubmit Ci-operator config changed
pull-ci-openshift-os-master-okd-scos-images openshift/os presubmit Ci-operator config changed
pull-ci-openshift-os-master-e2e-aws openshift/os presubmit Ci-operator config changed
pull-ci-openshift-os-master-images openshift/os presubmit Ci-operator config changed
pull-ci-openshift-os-release-5.0-e2e-aws openshift/os presubmit Ci-operator config changed
pull-ci-openshift-os-release-5.0-images openshift/os presubmit Ci-operator config changed
pull-ci-openshift-os-release-4.23-e2e-aws openshift/os presubmit Ci-operator config changed
pull-ci-openshift-os-release-4.23-images openshift/os presubmit Ci-operator config changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@dustymabe: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@joelcapitao joelcapitao left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jul 9, 2026
@openshift-ci

openshift-ci Bot commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dustymabe, joelcapitao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dustymabe

Copy link
Copy Markdown
Member Author

/override ci/rehearse/openshift/os/master/okd-scos-images
/override ci/rehearse/openshift/os/master/okd-scos-e2e-aws-ovn

These are going to fail until openshift/os#1945 merges anyway so we can ignore them here.

@openshift-ci

openshift-ci Bot commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

@dustymabe: dustymabe unauthorized: /override is restricted to Repo administrators, approvers in top level OWNERS file, and the following github teams:openshift: openshift-release-oversight openshift-staff-engineers openshift-sustaining-engineers.

Details

In response to this:

/override ci/rehearse/openshift/os/master/okd-scos-images
/override ci/rehearse/openshift/os/master/okd-scos-e2e-aws-ovn

These are going to fail until openshift/os#1945 merges anyway so we can ignore them here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@dustymabe

Copy link
Copy Markdown
Member Author

/pj-rehearse ack

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@dustymabe: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-merge-bot openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jul 9, 2026
@openshift-merge-bot openshift-merge-bot Bot merged commit 0669011 into openshift:main Jul 9, 2026
15 of 19 checks passed
@openshift-ci

openshift-ci Bot commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

@dustymabe: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/openshift/os/master/okd-scos-e2e-aws-ovn 37c23c2 link unknown /pj-rehearse pull-ci-openshift-os-master-okd-scos-e2e-aws-ovn
ci/rehearse/openshift/os/master/okd-scos-images 37c23c2 link unknown /pj-rehearse pull-ci-openshift-os-master-okd-scos-images

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants