Update ci-tools-build-root image#81746
Conversation
|
[REHEARSALNOTIFIER] Note: If this PR includes changes to step registry files ( |
WalkthroughThe CI tools build configuration is updated from OpenShift 1.25 to 1.26, including CentOS Stream 10 base images, version ChangesCI tools build update
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: danilo-gemoli, hector-vido The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@clusters/build-clusters/build-shared/supplemental-ci-images/ci-tools-build-root_mabc.yaml`:
- Line 18: The build publishes only the versioned ci-tools-build-root:1.26 tag
while consumers use ci-tools-build-root:latest. Update the image build
configuration to also publish the latest alias, or update all existing
ci-operator consumers to reference 1.26, ensuring producer and consumer tags
remain aligned.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: 97dd8add-0691-42ef-ac39-0b21c3913543
📒 Files selected for processing (1)
clusters/build-clusters/build-shared/supplemental-ci-images/ci-tools-build-root_mabc.yaml
| kind: ImageStreamTag | ||
| namespace: ci | ||
| name: ci-tools-build-root:1.25 | ||
| name: ci-tools-build-root:1.26 |
There was a problem hiding this comment.
🗄️ Data Integrity & Integration | 🟠 Major | ⚡ Quick win
🧩 Analysis chain
🏁 Script executed:
rg -n -C2 'ci-tools-build-root:(latest|1\.26)' .Repository: openshift/release
Length of output: 746
🏁 Script executed:
#!/bin/bash
set -euo pipefail
echo "== all ci-tools-build-root references =="
rg -n -C2 'ci-tools-build-root:(latest|1\.26)|ci-tools-build-root' clusters ci-operator core-services services tools || true
echo
echo "== file under review =="
cat -n clusters/build-clusters/build-shared/supplemental-ci-images/ci-tools-build-root_mabc.yaml | sed -n '1,120p'
echo
echo "== any ImageStreamTag / retag / promotion references =="
rg -n -C3 'ImageStreamTag|tag:' clusters/build-clusters/build-shared/supplemental-ci-images ci-operator core-services services tools || trueRepository: openshift/release
Length of output: 50374
🏁 Script executed:
#!/bin/bash
set -euo pipefail
echo "== file under review =="
cat -n clusters/build-clusters/build-shared/supplemental-ci-images/ci-tools-build-root_mabc.yaml | sed -n '1,220p'
echo
echo "== nearby ci-tools-build-root manifests =="
fd -a 'ci-tools-build-root*.yaml' clusters/build-clusters/build-shared/supplemental-ci-images
echo
echo "== focused references to the image stream and tags =="
rg -n -C3 'ci-tools-build-root|ImageStreamTag|retag|promote|latest|1\.26' \
clusters/build-clusters/build-shared/supplemental-ci-images \
ci-operator/config/redhat-chaos/prow-scripts/redhat-chaos-prow-scripts-main__4.21-nightly-upgrade.yamlRepository: openshift/release
Length of output: 19626
🏁 Script executed:
#!/bin/bash
set -euo pipefail
echo "== ci-tools-build-root definitions =="
rg -n -C4 'ci-tools-build-root' clusters core-services ci-operator services tools | head -n 300
echo
echo "== image stream/tag aliases around ci-tools-build-root =="
rg -n -C4 'kind: ImageStream|kind: ImageStreamTag|name: ci-tools-build-root|tag: latest|tag: 1\.26' clusters core-services ci-operator services tools | head -n 300Repository: openshift/release
Length of output: 50373
🏁 Script executed:
#!/bin/bash
set -euo pipefail
echo "== files that define ci-tools-build-root =="
fd -a 'ci-tools-build-root*.yaml' clusters core-services ci-operator services tools || true
echo
echo "== exact ci-tools-build-root image stream/tag definitions =="
rg -n -C4 'name: ci-tools-build-root|ci-tools-build-root:latest|ci-tools-build-root:1\.26' \
clusters core-services ci-operator services tools \
--glob '*.yaml' --glob '*.yml' --max-count 80 || true
echo
echo "== any retag/promotion logic mentioning ci-tools-build-root =="
rg -n -C3 'ci-tools-build-root.*(latest|1\.26)|tag.*latest|ImageStreamTag' \
clusters core-services ci-operator services tools \
--glob '*.yaml' --glob '*.yml' --max-count 120 || trueRepository: openshift/release
Length of output: 50374
🏁 Script executed:
#!/bin/bash
set -euo pipefail
echo "== direct ci-tools-build-root definitions in the repo =="
rg -n --max-count 50 'ci-tools-build-root' clusters/build-clusters core-services ci-operator services tools \
--glob '*.yaml' --glob '*.yml' || true
echo
echo "== any explicit latest/1.26 retagging for ci-tools-build-root =="
rg -n --max-count 50 'ci-tools-build-root:1\.26|ci-tools-build-root:latest|name:\s*ci-tools-build-root|tag:\s*(latest|1\.26)' \
clusters/build-clusters core-services ci-operator services tools \
--glob '*.yaml' --glob '*.yml' || trueRepository: openshift/release
Length of output: 50374
Keep the build-root tag aligned with existing consumers. This build publishes ci-tools-build-root:1.26, while the current ci-operator configs still pull ci-tools-build-root:latest. Add a latest alias or update those consumers so they pick up the new build.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In
`@clusters/build-clusters/build-shared/supplemental-ci-images/ci-tools-build-root_mabc.yaml`
at line 18, The build publishes only the versioned ci-tools-build-root:1.26 tag
while consumers use ci-tools-build-root:latest. Update the image build
configuration to also publish the latest alias, or update all existing
ci-operator consumers to reference 1.26, ensuring producer and consumer tags
remain aligned.
|
/override ci/prow/cluster-manifest-verifier |
|
@danilo-gemoli: Overrode contexts on behalf of danilo-gemoli: ci/prow/cluster-manifest-verifier DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@danilo-gemoli: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Bump image version, Golang and oc client.
Summary by CodeRabbit
Updates the
ci-tools-build-rootCI image to OpenShift 1.26, including newer CentOS Stream 10 and Go tooling, theocclient version 4.22.4, and the corresponding image tag.