Skip to content

NO-JIRA: Add Quay OMR 3 disconnected presubmit#81766

Closed
jbpratt wants to merge 1 commit into
openshift:mainfrom
jbpratt:omr3
Closed

NO-JIRA: Add Quay OMR 3 disconnected presubmit#81766
jbpratt wants to merge 1 commit into
openshift:mainfrom
jbpratt:omr3

Conversation

@jbpratt

@jbpratt jbpratt commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

Summary

  • add an optional quay/quay presubmit for stable OpenShift 4.22 through OMR 3
  • build Dockerfile.mirror, install the PR image on the standard disconnected AWS bastion, and publish runtime endpoint, credentials, and CA material
  • mirror payload and component signature tags with atomic completion proof, then validate cluster health, IDMS mappings, cluster-time OMR traffic, and a mirrored CLI smoke pod
  • collect secret-safe OMR diagnostics and retain the established disconnected AWS teardown and leak verification path

Verification

  • Bash syntax and warning-level ShellCheck for all changed command scripts
  • deterministic signature-mapping fixture and scoped secret/prohibited-architecture checks
  • make registry-metadata and registry metadata validation
  • make ci-operator-config and deterministic config comparison
  • make ci-operator-checkconfig SKIP_PULL=true
  • make jobs WHAT=quay/quay SKIP_PULL=true and generated Prow job inspection
  • git diff --check

A live AWS run was not performed locally. The optional presubmit is the end-to-end rehearsal path.

Summary by CodeRabbit

Adds an optional disconnected AWS presubmit for Quay’s stable OpenShift 4.22 OMR 3 workflow. It builds and installs the PR’s mirror image on a bastion, publishes runtime registry credentials and trust material, mirrors release signatures and payloads, and validates cluster health, IDMS mappings, OMR traffic, and mirrored CLI execution.

Introduces the supporting CI configuration and step-registry workflows, including OMR installation, validation, and secret-safe diagnostics collection. Existing mirror configuration now accepts runtime credentials and CA files, while bastion provisioning permits the OMR service port and signature mirroring includes retries, cleanup, and proof artifacts.

Verification covers shell validation, security and fixture checks, CI generation, Prow inspection, metadata validation, and whitespace checks. No live AWS run was performed locally.

Build the PR's Dockerfile.mirror image and install OMR 3 on the standard AWS disconnected bastion with runtime credentials and trust material.

Mirror OpenShift 4.22 payload and component signatures, validate cluster-time mirror pulls, collect secret-safe diagnostics, and retain the established disconnected teardown path.

Add the optional quay/quay job plus generated step-registry metadata and Prow configuration.
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 10, 2026
@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@jbpratt: This pull request explicitly references no jira issue.

Details

In response to this:

Summary

  • add an optional quay/quay presubmit for stable OpenShift 4.22 through OMR 3
  • build Dockerfile.mirror, install the PR image on the standard disconnected AWS bastion, and publish runtime endpoint, credentials, and CA material
  • mirror payload and component signature tags with atomic completion proof, then validate cluster health, IDMS mappings, cluster-time OMR traffic, and a mirrored CLI smoke pod
  • collect secret-safe OMR diagnostics and retain the established disconnected AWS teardown and leak verification path

Verification

  • Bash syntax and warning-level ShellCheck for all changed command scripts
  • deterministic signature-mapping fixture and scoped secret/prohibited-architecture checks
  • make registry-metadata and registry metadata validation
  • make ci-operator-config and deterministic config comparison
  • make ci-operator-checkconfig SKIP_PULL=true
  • make jobs WHAT=quay/quay SKIP_PULL=true and generated Prow job inspection
  • git diff --check

A live AWS run was not performed locally. The optional presubmit is the end-to-end rehearsal path.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci

openshift-ci Bot commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jbpratt
Once this PR has been reviewed and has the lgtm label, please assign aguidirh, patrickdillon for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coderabbitai

coderabbitai Bot commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: ee8e9347-53e0-4496-ba23-93645d88dcca

📥 Commits

Reviewing files that changed from the base of the PR and between b6aaa20 and c8a729c.

⛔ Files ignored due to path filters (1)
  • ci-operator/jobs/quay/quay/quay-quay-master-presubmits.yaml is excluded by !ci-operator/jobs/**
📒 Files selected for processing (21)
  • ci-operator/config/quay/quay/quay-quay-master__omr-3.yaml
  • ci-operator/step-registry/aws/provision/bastionhost/aws-provision-bastionhost-commands.sh
  • ci-operator/step-registry/ipi/conf/mirror/ipi-conf-mirror-commands.sh
  • ci-operator/step-registry/ipi/conf/mirror/ipi-conf-mirror-ref.yaml
  • ci-operator/step-registry/mirror-images/by-oc-adm-in-bastion/mirror-images-by-oc-adm-in-bastion-commands.sh
  • ci-operator/step-registry/mirror-images/by-oc-adm-in-bastion/mirror-images-by-oc-adm-in-bastion-ref.yaml
  • ci-operator/step-registry/quay/aws-ipi-disconnected-omr-3-provision/OWNERS
  • ci-operator/step-registry/quay/aws-ipi-disconnected-omr-3-provision/quay-aws-ipi-disconnected-omr-3-provision-chain.metadata.json
  • ci-operator/step-registry/quay/aws-ipi-disconnected-omr-3-provision/quay-aws-ipi-disconnected-omr-3-provision-chain.yaml
  • ci-operator/step-registry/quay/omr-3/gather/OWNERS
  • ci-operator/step-registry/quay/omr-3/gather/quay-omr-3-gather-commands.sh
  • ci-operator/step-registry/quay/omr-3/gather/quay-omr-3-gather-ref.metadata.json
  • ci-operator/step-registry/quay/omr-3/gather/quay-omr-3-gather-ref.yaml
  • ci-operator/step-registry/quay/omr-3/install/OWNERS
  • ci-operator/step-registry/quay/omr-3/install/quay-omr-3-install-commands.sh
  • ci-operator/step-registry/quay/omr-3/install/quay-omr-3-install-ref.metadata.json
  • ci-operator/step-registry/quay/omr-3/install/quay-omr-3-install-ref.yaml
  • ci-operator/step-registry/quay/omr-3/validate/OWNERS
  • ci-operator/step-registry/quay/omr-3/validate/quay-omr-3-validate-commands.sh
  • ci-operator/step-registry/quay/omr-3/validate/quay-omr-3-validate-ref.metadata.json
  • ci-operator/step-registry/quay/omr-3/validate/quay-omr-3-validate-ref.yaml

Cache: Disabled due to data retention organization setting

Knowledge base: Disabled due to data retention organization setting


Walkthrough

Adds CI orchestration and step-registry support for disconnected Quay OMR-3 AWS deployments, including installation, release and signature mirroring, diagnostics gathering, and cluster validation.

Changes

Quay OMR-3 disconnected workflow

Layer / File(s) Summary
CI and AWS provisioning orchestration
ci-operator/config/quay/quay/..., ci-operator/step-registry/aws/..., ci-operator/step-registry/quay/aws-ipi-disconnected-omr-3-provision/...
Adds the OMR-3 CI configuration, AWS provisioning chain, TCP 8443 ingress, chain environment settings, metadata, and ownership links.
OMR-3 installation and runtime publication
ci-operator/step-registry/quay/omr-3/install/...
Adds secure bastion installation of the PR-built Quay mirror, health verification, runtime credential/CA/endpoint publication, step configuration, and metadata.
Release and signature mirroring
ci-operator/step-registry/ipi/conf/mirror/..., ci-operator/step-registry/mirror-images/by-oc-adm-in-bastion/...
Adds runtime credential and CA overrides, secure cleanup, retry handling, release signature mirroring, OMR proof publication, and a 240-minute step timeout.
OMR-3 diagnostics collection
ci-operator/step-registry/quay/omr-3/gather/...
Adds best-effort bastion collection of Quay, Podman, journald, health, and host resource artifacts.
Disconnected cluster validation
ci-operator/step-registry/quay/omr-3/validate/...
Adds checks for cluster readiness, operators, nodes, IDMS mappings, OMR requests, and mirrored CLI execution.

Estimated code review effort: 4 (Complex) | ~60 minutes

Sequence Diagram(s)

sequenceDiagram
  participant CI
  participant AWSBastion
  participant Quay
  participant OpenShiftCluster
  CI->>AWSBastion: install OMR-3 and publish runtime artifacts
  CI->>Quay: mirror release images and signatures
  AWSBastion->>Quay: serve mirrored registry content
  CI->>OpenShiftCluster: configure mirror credentials and CA
  OpenShiftCluster->>Quay: request mirrored release content
  CI->>OpenShiftCluster: validate IDMS, OMR requests, and mirrored CLI
Loading

Suggested reviewers: dgoodwin, xueqzhan

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@openshift-ci openshift-ci Bot requested review from adolfo-ab and dgoodwin July 10, 2026 21:47
@jbpratt jbpratt closed this Jul 10, 2026
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@jbpratt: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-cluster-capi-operator-main-e2e-aws-capi-disconnected-techpreview openshift/cluster-capi-operator presubmit Registry content changed
pull-ci-openshift-cluster-capi-operator-release-5.1-e2e-aws-capi-disconnected-techpreview openshift/cluster-capi-operator presubmit Registry content changed
pull-ci-openshift-cluster-capi-operator-release-5.0-e2e-aws-capi-disconnected-techpreview openshift/cluster-capi-operator presubmit Registry content changed
pull-ci-openshift-cluster-capi-operator-release-4.23-e2e-aws-capi-disconnected-techpreview openshift/cluster-capi-operator presubmit Registry content changed
pull-ci-openshift-csi-operator-main-aws-efs-operator-e2e-extended openshift/csi-operator presubmit Registry content changed
pull-ci-openshift-csi-operator-main-aws-efs-single-zone-operator-e2e-extended openshift/csi-operator presubmit Registry content changed
pull-ci-openshift-csi-operator-release-5.1-aws-efs-operator-e2e-extended openshift/csi-operator presubmit Registry content changed
pull-ci-openshift-csi-operator-release-5.1-aws-efs-single-zone-operator-e2e-extended openshift/csi-operator presubmit Registry content changed
pull-ci-openshift-csi-operator-release-5.0-aws-efs-operator-e2e-extended openshift/csi-operator presubmit Registry content changed
pull-ci-openshift-csi-operator-release-5.0-aws-efs-single-zone-operator-e2e-extended openshift/csi-operator presubmit Registry content changed
pull-ci-openshift-csi-operator-release-4.23-aws-efs-operator-e2e-extended openshift/csi-operator presubmit Registry content changed
pull-ci-openshift-csi-operator-release-4.23-aws-efs-single-zone-operator-e2e-extended openshift/csi-operator presubmit Registry content changed
pull-ci-openshift-csi-operator-release-4.22-aws-efs-operator-e2e-extended openshift/csi-operator presubmit Registry content changed
pull-ci-openshift-csi-operator-release-4.22-aws-efs-single-zone-operator-e2e-extended openshift/csi-operator presubmit Registry content changed
pull-ci-openshift-csi-operator-release-4.21-aws-efs-operator-e2e-extended openshift/csi-operator presubmit Registry content changed
pull-ci-openshift-csi-operator-release-4.21-aws-efs-single-zone-operator-e2e-extended openshift/csi-operator presubmit Registry content changed
pull-ci-openshift-csi-operator-release-4.20-aws-efs-operator-e2e-extended openshift/csi-operator presubmit Registry content changed
pull-ci-openshift-csi-operator-release-4.20-aws-efs-single-zone-operator-e2e-extended openshift/csi-operator presubmit Registry content changed
pull-ci-openshift-csi-operator-release-4.19-aws-efs-operator-e2e-extended openshift/csi-operator presubmit Registry content changed
pull-ci-openshift-csi-operator-release-4.18-aws-efs-operator-e2e-extended openshift/csi-operator presubmit Registry content changed
pull-ci-openshift-csi-operator-release-4.17-aws-efs-operator-e2e-extended openshift/csi-operator presubmit Registry content changed
pull-ci-openshift-csi-operator-main-e2e-aws-csi-extended openshift/csi-operator presubmit Registry content changed
pull-ci-openshift-csi-operator-release-5.1-e2e-aws-csi-extended openshift/csi-operator presubmit Registry content changed
pull-ci-openshift-csi-operator-release-5.0-e2e-aws-csi-extended openshift/csi-operator presubmit Registry content changed
pull-ci-openshift-csi-operator-release-4.23-e2e-aws-csi-extended openshift/csi-operator presubmit Registry content changed

A total of 1637 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs.

A full list of affected jobs can be found here
Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants