Skip to content

Move 9 nodes from 4.18 to 4.20#81829

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
bshewale:4.20_cp_p1
Jul 13, 2026
Merged

Move 9 nodes from 4.18 to 4.20#81829
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
bshewale:4.20_cp_p1

Conversation

@bshewale

@bshewale bshewale commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • Reallocates nine Vexxhost OpenShift nodes from the 4.18 hosted management pool to the 4.20 pool.
  • Removes nodes 02–10 from the 4.18 inventory and reduces its pool capacity from 16 to 7.
  • Adds nodes 01–10 to the 4.20 inventory and increases its pool capacity from 2 to 11.

@openshift-merge-bot openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jul 13, 2026
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@bshewale: no rehearsable tests are affected by this change

Note: If this PR includes changes to step registry files (ci-operator/step-registry/) and you expected jobs to be found, try rebasing your PR onto the base branch. This helps pj-rehearse accurately detect changes when the base branch has moved forward.

@coderabbitai

coderabbitai Bot commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: fe0e00ec-806b-4ec0-a12f-4d997d3f6864

📥 Commits

Reviewing files that changed from the base of the PR and between 03b47ca and e24377d.

📒 Files selected for processing (2)
  • clusters/hosted-mgmt/hive/pools/openstack-k8s-operators/openstack-k8s-operators-4-18-vexxhost-hybrid_clusterpool.yaml
  • clusters/hosted-mgmt/hive/pools/openstack-k8s-operators/openstack-k8s-operators-4-20-vexxhost-hybrid_clusterpool.yaml

Walkthrough

The 4.18 and 4.20 Vexxhost OpenStack ClusterPool manifests update their customization inventories and adjust pool concurrency, capacity, and running-count values.

Changes

Vexxhost ClusterPool updates

Layer / File(s) Summary
Align pool inventories and capacity settings
clusters/hosted-mgmt/hive/pools/openstack-k8s-operators/*vexxhost-hybrid_clusterpool.yaml
The 4.18 inventory removes customizations -02 through -10 and changes sizing values from 16 to 7; the 4.20 inventory adds -01 through -10 and changes sizing values from 2 to 11. Existing secret references remain unchanged.

Estimated code review effort: 2 (Simple) | ~10 minutes

Suggested labels: lgtm, approved

Suggested reviewers: deepsm007, openshift-merge-bot[bot], evallesp, danilo-gemoli, openshift-bot

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: shifting 9 nodes from the 4.18 pool to the 4.20 pool.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed PR only changes ClusterPool YAML manifests; no Ginkgo tests or titles were added or modified.
Test Structure And Quality ✅ Passed PR only changes two ClusterPool YAML manifests; no Ginkgo tests or test logic were modified, so the test-quality check is not applicable.
Microshift Test Compatibility ✅ Passed No new Ginkgo/e2e test code was added; the PR only changes ClusterPool YAML sizing/inventory, so MicroShift compatibility is not applicable.
Single Node Openshift (Sno) Test Compatibility ✅ Passed PR only changes ClusterPool YAML manifests; no Ginkgo e2e tests or SNO-sensitive test logic were added.
Topology-Aware Scheduling Compatibility ✅ Passed Only ClusterPool inventory and sizing fields changed; no pod affinity, node selectors, topology spread, or replica scheduling constraints appear.
Ote Binary Stdout Contract ✅ Passed PR only changes ClusterPool YAML manifests; no main/init/suite code or stdout logging paths were touched.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed Only ClusterPool YAML manifests changed; no Ginkgo tests or network code were added, so IPv4/disconnected compatibility issues are not applicable.
No-Weak-Crypto ✅ Passed Changed files are YAML ClusterPool manifests only; they update inventory and pool sizing, with no crypto code or weak algorithms present.
Container-Privileges ✅ Passed The changed files are ClusterPool YAMLs and contain no privileged, hostPID/Network/IPC, SYS_ADMIN, root, or allowPrivilegeEscalation settings.
No-Sensitive-Data-In-Logs ✅ Passed PASS: The PR only edits ClusterPool manifests (inventory/size values); it adds no log statements or secret material and no new sensitive data exposure.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@openshift-ci openshift-ci Bot requested review from cjeanner and olliewalsh July 13, 2026 18:51

@abays abays left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jul 13, 2026
@openshift-ci

openshift-ci Bot commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abays, bshewale

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 13, 2026
@openshift-ci

openshift-ci Bot commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

@bshewale: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot Bot merged commit 50a68f0 into openshift:main Jul 13, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants