Skip to content

CNTRLPLANE-2850: hypershift: Add aws v2 periodics#81878

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
ironcladlou:e2e-v2-aws-periodic
Jul 15, 2026
Merged

CNTRLPLANE-2850: hypershift: Add aws v2 periodics#81878
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
ironcladlou:e2e-v2-aws-periodic

Conversation

@ironcladlou

@ironcladlou ironcladlou commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

Add the hypershift AWS v2 periodics to begin collecting baseline signal.

Fixes https://redhat.atlassian.net/browse/CNTRLPLANE-2850

Summary by CodeRabbit

Adds scheduled HyperShift AWS v2 baseline CI jobs for the 4.22, 4.23, and 5.0 release streams. Each job runs four times daily on the hypershift-aws cluster profile using the hypershift-aws-e2e-v2 workflow, expanding upgrade verification coverage for these release configurations.

@coderabbitai

coderabbitai Bot commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

  • ▶️ Resume reviews
  • 🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 2798e6fc-d7a6-48f0-b43f-330175488670

📥 Commits

Reviewing files that changed from the base of the PR and between 37cec54 and cbc9b3b.

⛔ Files ignored due to path filters (3)
  • ci-operator/jobs/openshift/hypershift/openshift-hypershift-release-4.22-periodics.yaml is excluded by !ci-operator/jobs/**
  • ci-operator/jobs/openshift/hypershift/openshift-hypershift-release-4.23-periodics.yaml is excluded by !ci-operator/jobs/**
  • ci-operator/jobs/openshift/hypershift/openshift-hypershift-release-5.0-periodics.yaml is excluded by !ci-operator/jobs/**
📒 Files selected for processing (3)
  • ci-operator/config/openshift/hypershift/openshift-hypershift-release-4.22__periodics.yaml
  • ci-operator/config/openshift/hypershift/openshift-hypershift-release-4.23__periodics.yaml
  • ci-operator/config/openshift/hypershift/openshift-hypershift-release-5.0__periodics.yaml
🚧 Files skipped from review as they are similar to previous changes (3)
  • ci-operator/config/openshift/hypershift/openshift-hypershift-release-5.0__periodics.yaml
  • ci-operator/config/openshift/hypershift/openshift-hypershift-release-4.22__periodics.yaml
  • ci-operator/config/openshift/hypershift/openshift-hypershift-release-4.23__periodics.yaml

Walkthrough

Adds the e2e-v2-aws periodic test to Hypershift release 4.22, 4.23, and 5.0 configurations, scheduled four times daily with the AWS cluster profile and E2E v2 workflow.

Changes

Hypershift AWS E2E v2 scheduling

Layer / File(s) Summary
Add AWS E2E v2 periodic jobs
ci-operator/config/openshift/hypershift/*__periodics.yaml
Release 4.22, 4.23, and 5.0 configurations add e2e-v2-aws with cron 30 1,7,13,19 * * *, the hypershift-aws cluster profile, and the hypershift-aws-e2e-v2 workflow.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Possibly related PRs

Suggested reviewers: jupierce, nirshal

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the main change: adding HyperShift AWS v2 periodic jobs.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed Only periodic CI YAML jobs were added; no Ginkgo It/Describe/Context/When titles or dynamic test names appear in the diff.
Test Structure And Quality ✅ Passed PR only adds ci-operator periodic YAML jobs; no Ginkgo test code or test behavior changes to review.
Microshift Test Compatibility ✅ Passed PR only adds periodic YAML entries for existing e2e-v2-aws jobs; no new Ginkgo test code or unsupported API usage was introduced.
Single Node Openshift (Sno) Test Compatibility ✅ Passed Only periodic job config was added; no new Ginkgo test logic or SNO-sensitive assertions were introduced.
Topology-Aware Scheduling Compatibility ✅ Passed PR only adds CI periodic job entries and generated Prow jobs; no deployment manifests, operator/controller code, or pod scheduling constraints changed.
Ote Binary Stdout Contract ✅ Passed HEAD commit changes only YAML periodics/jobs files; no process-level code or stdout writes were introduced.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed PASS: The PR only adds periodic/job YAML entries for an existing hypershift-aws-e2e-v2 workflow; no Ginkgo test code or network logic changed, so this check isn't applicable.
No-Weak-Crypto ✅ Passed PR only adds periodic CI YAML entries; no MD5/SHA1/DES/RC4/3DES/Blowfish/ECB, custom crypto, or secret comparisons appear in the diff.
Container-Privileges ✅ Passed The PR only adds periodic job entries and the generated job/workflow manifests for e2e-v2-aws contain no privileged, hostPID/Network/IPC, SYS_ADMIN, or escalation settings.
No-Sensitive-Data-In-Logs ✅ Passed Only periodic YAML entries were added; no logging statements or secret-bearing fields appear in the changed blocks.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@ironcladlou

Copy link
Copy Markdown
Contributor Author

/pj-rehearse

@openshift-ci
openshift-ci Bot requested review from Nirshal and jupierce July 14, 2026 15:04

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In
`@ci-operator/config/openshift/hypershift/openshift-hypershift-release-4.22__periodics.yaml`:
- Around line 147-153: The generated Prow artifacts are missing for both new v2
AWS periodic jobs. Regenerate and validate the jobs defined in
ci-operator/config/openshift/hypershift/openshift-hypershift-release-4.22__periodics.yaml
lines 147-153 and
ci-operator/config/openshift/hypershift/openshift-hypershift-release-5.0__periodics.yaml
lines 163-169 using make registry-metadata && make ci-operator-config && make
jobs, ensuring both e2e-v2-aws definitions produce corresponding generated jobs.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 0f245720-a4e9-4f68-9298-3b1bc9950a7a

📥 Commits

Reviewing files that changed from the base of the PR and between 334c674 and 468ca7d.

⛔ Files ignored due to path filters (2)
  • ci-operator/jobs/openshift/hypershift/openshift-hypershift-release-4.22-periodics.yaml is excluded by !ci-operator/jobs/**
  • ci-operator/jobs/openshift/hypershift/openshift-hypershift-release-5.0-periodics.yaml is excluded by !ci-operator/jobs/**
📒 Files selected for processing (4)
  • ci-operator/config/openshift/hypershift/openshift-hypershift-release-4.22__periodics.yaml
  • ci-operator/config/openshift/hypershift/openshift-hypershift-release-5.0__periodics.yaml
  • core-services/release-controller/_releases/release-ocp-4.22-ci.json
  • core-services/release-controller/_releases/release-ocp-5.0-ci.json

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@ironcladlou: your /pj-rehearse request was not processed because the request waited in queue for longer than 5 minutes. Please retry in a few minutes.

@ironcladlou

Copy link
Copy Markdown
Contributor Author

/pj-rehearse

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@ironcladlou: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@ironcladlou
ironcladlou force-pushed the e2e-v2-aws-periodic branch from 468ca7d to b666710 Compare July 14, 2026 16:08
@ironcladlou

Copy link
Copy Markdown
Contributor Author

/pj-rehearse

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@ironcladlou: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@ironcladlou

Copy link
Copy Markdown
Contributor Author

/pj-rehearse

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@ironcladlou: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@bryan-cox

bryan-cox commented Jul 15, 2026

Copy link
Copy Markdown
Member

/retitle CNTRLPLANE-2850: hypershift: Add aws v2 periodics

@openshift-ci openshift-ci Bot changed the title hypershift: Add aws v2 periodics CNTRLPLANE-2850: hypershift: Add aws v2 periodics Jul 15, 2026
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 15, 2026
@openshift-ci-robot

openshift-ci-robot commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

@ironcladlou: This pull request references CNTRLPLANE-2850 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set.

Details

In response to this:

Add the hypershift AWS v2 periodics to begin collecting baseline signal.

Fixes https://redhat.atlassian.net/browse/CNTRLPLANE-2850

Summary by CodeRabbit

This PR adds HyperShift AWS v2 baseline E2E periodic testing to OpenShift CI for both the 4.22 and 5.0 release streams. It introduces a scheduled e2e-v2-aws periodic job (cron: 30 1,7,13,19 * * *) that runs on the hypershift-aws cluster profile using the hypershift-aws-e2e-v2 workflow, and registers the corresponding hypershift-e2e-v2-aws entries in each release stream’s release-controller verify section (with maxRetries: 1 and upgrade: true) so these checks run as upgrade-enabled verifications.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@ironcladlou
ironcladlou force-pushed the e2e-v2-aws-periodic branch from 33765f4 to 37cec54 Compare July 15, 2026 13:21
@ironcladlou

Copy link
Copy Markdown
Contributor Author

/pj-rehearse

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@ironcladlou: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@bryan-cox

Copy link
Copy Markdown
Member

/approve

@ironcladlou

Copy link
Copy Markdown
Contributor Author

/rehearsals-ack

@ironcladlou

Copy link
Copy Markdown
Contributor Author

/pj-rehearse ack

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@ironcladlou: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-merge-bot openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jul 15, 2026
Add the hypershift AWS v2 periodics to begin collecting baseline signal.

Fixes https://redhat.atlassian.net/browse/CNTRLPLANE-2850
@ironcladlou
ironcladlou force-pushed the e2e-v2-aws-periodic branch from 37cec54 to cbc9b3b Compare July 15, 2026 19:02
@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 15, 2026
@openshift-merge-bot openshift-merge-bot Bot removed the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jul 15, 2026
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@ironcladlou: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
periodic-ci-openshift-hypershift-release-5.0-periodics-e2e-v2-aws N/A periodic Periodic changed
periodic-ci-openshift-hypershift-release-4.22-periodics-e2e-v2-aws N/A periodic Periodic changed
periodic-ci-openshift-hypershift-release-4.23-periodics-e2e-v2-aws N/A periodic Periodic changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@ironcladlou

Copy link
Copy Markdown
Contributor Author

/pj-rehearse skip

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@ironcladlou: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-merge-bot openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jul 15, 2026
@csrwng

csrwng commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jul 15, 2026
@openshift-ci

openshift-ci Bot commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bryan-cox, csrwng, ironcladlou

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci

openshift-ci Bot commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

@ironcladlou: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot
openshift-merge-bot Bot merged commit 44d21c2 into openshift:main Jul 15, 2026
16 checks passed
SachinNinganure pushed a commit to SachinNinganure/release that referenced this pull request Jul 20, 2026
Add the hypershift AWS v2 periodics to begin collecting baseline signal.

Fixes https://redhat.atlassian.net/browse/CNTRLPLANE-2850
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants