ROSAENG-61950 | chore: codecov configuration - #82070
Conversation
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Enterprise Run ID: ⛔ Files ignored due to path filters (2)
📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
WalkthroughThe ROSA service log CI configuration removes local secret fallbacks and credential checks from unit and integration jobs, and adds coverage and postsubmit coverage jobs that run ChangesROSA service log CI
Estimated code review effort: 3 (Moderate) | ~20 minutes Possibly related PRs
Suggested labels: Suggested reviewers: Sequence Diagram(s)sequenceDiagram
participant CIJob
participant MountedSecrets
participant TestDirectories
participant Database
participant Codecov
CIJob->>MountedSecrets: Copy openshift-online-osl-secrets into secrets/
CIJob->>TestDirectories: Symlink secrets/ and config/
CIJob->>Database: Run make db/setup
CIJob->>Codecov: Run make codecov
🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
openshift-ci
Bot
added
the
approved
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@ci-operator/config/openshift-online/rosa-service-log/openshift-online-rosa-service-log-master.yaml`:
- Around line 126-174: Regenerate the Prow job metadata for the new coverage
jobs by running make update, then commit the generated changes alongside the
source configuration. Ensure both coverage and publish-coverage definitions are
reflected in the generated job files.
- Around line 145-149: Update the rosa-service-log CI configuration and its
coverage targets so presubmit execution cannot access or upload with the Codecov
credential: remove the rosa-service-log-codecov mount from the general secrets,
mount it only for the publish-coverage postsubmit target, and make the regular
coverage target non-uploading while retaining upload behavior in
publish-coverage.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: f0230748-4517-43a5-9304-98d1af977c89
⛔ Files ignored due to path filters (2)
ci-operator/jobs/openshift-online/rosa-service-log/openshift-online-rosa-service-log-master-postsubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift-online/rosa-service-log/openshift-online-rosa-service-log-master-presubmits.yamlis excluded by!ci-operator/jobs/**
📒 Files selected for processing (1)
ci-operator/config/openshift-online/rosa-service-log/openshift-online-rosa-service-log-master.yaml
|
/pj-rehearse pull-ci-openshift-online-rosa-service-log-master-coverage |
|
@gdbranco: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse |
|
@gdbranco: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse pull-ci-openshift-online-rosa-service-log-master-coverage |
|
@gdbranco: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse pull-ci-openshift-online-rosa-service-log-master-coverage |
|
@gdbranco: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
d5565d7 to
e8cea3e
Compare
|
/pj-rehearse pull-ci-openshift-online-rosa-service-log-master-coverage |
|
@gdbranco: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
e8cea3e to
a502388
Compare
|
/pj-rehearse pull-ci-openshift-online-rosa-service-log-master-coverage |
|
@gdbranco: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
a502388 to
f63b677
Compare
|
/pj-rehearse pull-ci-openshift-online-rosa-service-log-master-coverage |
|
@gdbranco: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse pull-ci-openshift-online-rosa-service-log-master-unit |
f63b677 to
6a1cdd5
Compare
|
/pj-rehearse pull-ci-openshift-online-rosa-service-log-master-coverage |
|
/pj-rehearse pull-ci-openshift-online-rosa-service-log-master-unit |
|
@gdbranco: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
2 similar comments
|
@gdbranco: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
@gdbranco: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
[REHEARSALNOTIFIER]
Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
/pj-rehearse pull-ci-openshift-online-rosa-service-log-master-coverage |
|
@gdbranco: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse ack |
|
@gdbranco: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
openshift-merge-bot
Bot
added
the
rehearsals-ack
|
/lgtm |
|
@gdbranco: you cannot LGTM your own PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gdbranco, Lir10 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@gdbranco: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
![openshift-prow[bot]](https://github.githubassets.com/images/gravatars/gravatar-user-420.png){kind=avatar}
2 participants
Summary by CodeRabbit
Updates the OpenShift CI configuration for the
rosa-service-logcomponent (ci-operator/config/openshift-online/rosa-service-log/openshift-online-rosa-service-log-master.yaml):unitandintegrationjob setup by removing the previous inline shell logic that created default database/RHSM secret files and enforced presence of specific Vault-provided OCM credential files. The jobs now:secrets/directoryopenshift-online-osl-secretsinto itsecrets/andconfig/into the test directoriesmake db/setupfollowed bymake test/make test-integrationcoverage: runs the same secret-prep +make db/setupflow, then executesmake codecovwhile mounting bothopenshift-online-osl-secretsandrosa-service-log-codecovpublish-coverage: postsubmit variant ofcoverage(postsubmit: true) that performs the samemake codecovsteps with the same secret mounts