Skip to content

ROSAENG-58795 | task: add nested podman image for on-demand to rosa-clusters-service#82107

Closed
davidleerh wants to merge 2 commits into
openshift:mainfrom
davidleerh:ROSAENG-58795-2
Closed

ROSAENG-58795 | task: add nested podman image for on-demand to rosa-clusters-service#82107
davidleerh wants to merge 2 commits into
openshift:mainfrom
davidleerh:ROSAENG-58795-2

Conversation

@davidleerh

@davidleerh davidleerh commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

Updates the rosa-clusters-service Konflux CI pipeline to build and test the repository inside a nested Podman environment. It adds a Podman-enabled build image with the required dependencies and source layout, then introduces optional PR checks for HCP, AWS, GCP, ROSA Classic, and Core using the new image, Prow secrets, and the rosa-clusters-service sandbox secret.

@openshift-ci

openshift-ci Bot commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci openshift-ci Bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 17, 2026
@openshift-ci

openshift-ci Bot commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: davidleerh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 17, 2026
@coderabbitai

coderabbitai Bot commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 8d3cdc7f-7f9f-417e-a824-f4facc59182a

📥 Commits

Reviewing files that changed from the base of the PR and between f5db8cc and e853bac.

⛔ Files ignored due to path filters (1)
  • ci-operator/jobs/openshift-online/rosa-clusters-service/openshift-online-rosa-clusters-service-konflux-master-presubmits.yaml is excluded by !ci-operator/jobs/**
📒 Files selected for processing (1)
  • ci-operator/config/openshift-online/rosa-clusters-service/openshift-online-rosa-clusters-service-konflux-master.yaml

Cache: Disabled due to data retention organization setting

Knowledge base: Disabled due to data retention organization setting


Walkthrough

The Konflux pipeline now builds a custom src-podman image from a nested-Podman base and adds five optional PR check jobs for ROSA HCP, AWS, GCP, ROSA Classic, and core checks.

Changes

ROSA clusters PR checks

Layer / File(s) Summary
Build the PR check image
ci-operator/config/openshift-online/rosa-clusters-service/openshift-online-rosa-clusters-service-konflux-master.yaml
Defines the nested-podman base image and builds src-podman with required tooling and repository source.
Run provider-specific checks
ci-operator/config/openshift-online/rosa-clusters-service/openshift-online-rosa-clusters-service-konflux-master.yaml
Adds five optional PR check jobs that load Prow secrets, mount the sandbox secret, and run provider-specific ./pr_check.sh commands.

Estimated code review effort: 3 (Moderate) | ~15–30 minutes

Possibly related PRs

  • openshift/release#82042: Updates the same Konflux pipeline with overlapping pr-check-* jobs and sandbox-secret wiring.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
⚔️ Resolve merge conflicts
  • Resolve merge conflict in branch ROSAENG-58795-2

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@davidleerh davidleerh closed this Jul 17, 2026
@openshift-ci
openshift-ci Bot requested review from lucasponce and robpblake July 17, 2026 20:28
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@davidleerh: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-online-rosa-clusters-service-konflux-master-images openshift-online/rosa-clusters-service presubmit Presubmit changed
pull-ci-openshift-online-rosa-clusters-service-konflux-master-check-migrations openshift-online/rosa-clusters-service presubmit Ci-operator config changed
pull-ci-openshift-online-rosa-clusters-service-konflux-master-lint openshift-online/rosa-clusters-service presubmit Ci-operator config changed
pull-ci-openshift-online-rosa-clusters-service-konflux-master-pr-check-aws openshift-online/rosa-clusters-service presubmit Ci-operator config changed
pull-ci-openshift-online-rosa-clusters-service-konflux-master-pr-check-core openshift-online/rosa-clusters-service presubmit Ci-operator config changed
pull-ci-openshift-online-rosa-clusters-service-konflux-master-pr-check-gcp openshift-online/rosa-clusters-service presubmit Ci-operator config changed
pull-ci-openshift-online-rosa-clusters-service-konflux-master-pr-check-rosa-classic openshift-online/rosa-clusters-service presubmit Ci-operator config changed
pull-ci-openshift-online-rosa-clusters-service-konflux-master-pr-check-rosa-hcp openshift-online/rosa-clusters-service presubmit Ci-operator config changed
pull-ci-openshift-online-rosa-clusters-service-konflux-master-unit openshift-online/rosa-clusters-service presubmit Ci-operator config changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant