Skip to content

Bump route-monitor-operator CI memory limit to 6Gi#82116

Open
dustman9000 wants to merge 1 commit into
openshift:mainfrom
dustman9000:rmo-lint-memory-bump
Open

Bump route-monitor-operator CI memory limit to 6Gi#82116
dustman9000 wants to merge 1 commit into
openshift:mainfrom
dustman9000:rmo-lint-memory-bump

Conversation

@dustman9000

@dustman9000 dustman9000 commented Jul 18, 2026

Copy link
Copy Markdown
Member

The boilerplate golangci-lint config now enables 25+ linters (errcheck, staticcheck, gosec, revive, etc.) which exceeds the 4Gi memory limit, causing consistent OOMKill on the lint CI job.

Bumping to 6Gi to accommodate the expanded linter set.

Example OOM: https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/openshift_route-monitor-operator/598/pull-ci-openshift-route-monitor-operator-master-lint/2078483407221821440

Summary by CodeRabbit

  • Increases the route-monitor-operator CI lint job’s default memory limit from 4Gi to 6Gi to prevent OOMKills from its expanded golangci-lint configuration.

The boilerplate golangci-lint config now enables 25+ linters which
exceeds the 4Gi memory limit, causing OOMKill on the lint CI job.
@openshift-ci

openshift-ci Bot commented Jul 18, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dustman9000

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 18, 2026
@openshift-ci
openshift-ci Bot requested review from Mhodesty and nephomaniac July 18, 2026 15:04
@coderabbitai

coderabbitai Bot commented Jul 18, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 93a555bf-6977-4bfc-a050-c2894c92e830

📥 Commits

Reviewing files that changed from the base of the PR and between 32af706 and a35d4e9.

📒 Files selected for processing (1)
  • ci-operator/config/openshift/route-monitor-operator/openshift-route-monitor-operator-master.yaml

Walkthrough

The OpenShift Prow configuration increases the wildcard resource memory limit for the route-monitor-operator job from 4Gi to 6Gi.

Changes

Route Monitor CI Resources

Layer / File(s) Summary
Increase wildcard memory limit
ci-operator/config/openshift/route-monitor-operator/openshift-route-monitor-operator-master.yaml
The wildcard resource entry’s limits.memory value changes from 4Gi to 6Gi.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly matches the change: increasing the route-monitor-operator CI memory limit to 6Gi.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed Only a CI YAML memory limit changed; no Ginkgo test titles or test code were modified.
Test Structure And Quality ✅ Passed This PR only changes a ci-operator YAML memory limit; no Ginkgo test code or test helpers were modified.
Microshift Test Compatibility ✅ Passed The PR only changes a ci-operator memory limit in a YAML config; no new Ginkgo e2e tests or MicroShift-relevant APIs were added.
Single Node Openshift (Sno) Test Compatibility ✅ Passed Only a CI resource limit in a YAML job config changed; no Ginkgo e2e tests were added or modified.
Topology-Aware Scheduling Compatibility ✅ Passed The only change is a CI job memory limit bump (4Gi→6Gi); no pod scheduling, affinity, replica, or topology-specific fields were added.
Ote Binary Stdout Contract ✅ Passed The PR only changes a CI memory limit in a YAML config; no process-level Go code or stdout writes were modified.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed PR only changes CI memory limits in a YAML config; no new Ginkgo e2e tests or networking assumptions were added.
No-Weak-Crypto ✅ Passed The PR only changes a CI YAML memory limit from 4Gi to 6Gi; no crypto code or comparisons are introduced.
Container-Privileges ✅ Passed The only touched config adjusts memory to 6Gi; no privileged, hostPID/Network/IPC, SYS_ADMIN, or allowPrivilegeEscalation settings are present.
No-Sensitive-Data-In-Logs ✅ Passed The only relevant change is a CI memory limit bump in a YAML config; no new logging or sensitive-data exposure is present.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@dustman9000: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-route-monitor-operator-master-coverage openshift/route-monitor-operator presubmit Ci-operator config changed
pull-ci-openshift-route-monitor-operator-master-e2e-binary-build-success openshift/route-monitor-operator presubmit Ci-operator config changed
pull-ci-openshift-route-monitor-operator-master-generate openshift/route-monitor-operator presubmit Ci-operator config changed
pull-ci-openshift-route-monitor-operator-master-images openshift/route-monitor-operator presubmit Ci-operator config changed
pull-ci-openshift-route-monitor-operator-master-lint openshift/route-monitor-operator presubmit Ci-operator config changed
pull-ci-openshift-route-monitor-operator-master-rosa-sts-e2e openshift/route-monitor-operator presubmit Ci-operator config changed
pull-ci-openshift-route-monitor-operator-master-test openshift/route-monitor-operator presubmit Ci-operator config changed
periodic-ci-openshift-route-monitor-operator-master-rosa-sts-e2e-promotion-stage N/A periodic Ci-operator config changed
periodic-ci-openshift-route-monitor-operator-master-rosa-sts-e2e-promotion-int N/A periodic Ci-operator config changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@dustman9000

Copy link
Copy Markdown
Member Author

/pj-rehearse pull-ci-openshift-route-monitor-operator-master-lint

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@dustman9000: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci

openshift-ci Bot commented Jul 18, 2026

Copy link
Copy Markdown
Contributor

@dustman9000: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/openshift/route-monitor-operator/master/lint a35d4e9 link unknown /pj-rehearse pull-ci-openshift-route-monitor-operator-master-lint

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@dustman9000

Copy link
Copy Markdown
Member Author

The rehearsal lint failure is expected: in a rehearsal context, PULL_BASE_SHA points to the release repo's base commit, not the RMO repo's base. This means --new-from-rev compares against the wrong SHA, causing golangci-lint to treat all code as 'new' and report pre-existing lint issues.

The actual fix works: the rehearsal ran to completion without OOM (exit code 2 from lint errors, not 137 from OOMKill), confirming 6Gi is sufficient. When this change lands, the real RMO lint job will use the correct PULL_BASE_SHA and only lint changed code.

/retest

@dustman9000

Copy link
Copy Markdown
Member Author

/pj-rehearse ack

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@dustman9000: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-merge-bot openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jul 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant