Bump route-monitor-operator CI memory limit to 6Gi#82116
Conversation
The boilerplate golangci-lint config now enables 25+ linters which exceeds the 4Gi memory limit, causing OOMKill on the lint CI job.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dustman9000 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
WalkthroughThe OpenShift Prow configuration increases the wildcard resource memory limit for the route-monitor-operator job from ChangesRoute Monitor CI Resources
Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
[REHEARSALNOTIFIER]
Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals. Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
/pj-rehearse pull-ci-openshift-route-monitor-operator-master-lint |
|
@dustman9000: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
@dustman9000: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
The rehearsal lint failure is expected: in a rehearsal context, PULL_BASE_SHA points to the release repo's base commit, not the RMO repo's base. This means The actual fix works: the rehearsal ran to completion without OOM (exit code 2 from lint errors, not 137 from OOMKill), confirming 6Gi is sufficient. When this change lands, the real RMO lint job will use the correct PULL_BASE_SHA and only lint changed code. /retest |
|
/pj-rehearse ack |
|
@dustman9000: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
The boilerplate golangci-lint config now enables 25+ linters (errcheck, staticcheck, gosec, revive, etc.) which exceeds the 4Gi memory limit, causing consistent OOMKill on the lint CI job.
Bumping to 6Gi to accommodate the expanded linter set.
Example OOM: https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/openshift_route-monitor-operator/598/pull-ci-openshift-route-monitor-operator-master-lint/2078483407221821440
Summary by CodeRabbit