[WIP] update release image

[shakyav]

Summary by CodeRabbit

Updates OpenShift CI configuration for ACM/CNV interop testing to improve and align the upgrade and console E2E inputs on OCP 4.22: adds a console-e2e base image (acm-qe namespace/tag) and introduces a nightly candidate release target for OCP 4.22 under releases.latest. AWS LP interop upgrade-related jobs are switched to source the upgrade image from the new release:latest definition (rather than the prior release:target).

Also adjusts the ACM interop P2P spoke upgrade healthcheck step to allow more time (5h → 6h) and increases related MCP wait/budget defaults (minutes per node and ready timeout) to match the updated rehearsal/timeout expectations.

[openshift-ci]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[coderabbitai]

Walkthrough

The ACM interop configuration adds a console-e2e base image, defines an OCP 4.22 candidate nightly release, switches the AWS LP upgrade image override to release:latest, and extends the spoke upgrade healthcheck timeout and MCP readiness budgets.

Changes

ACM interop updates

Layer / File(s)	Summary
Candidate release and upgrade image wiring ci-operator/config/RedHatQE/interop-testing/...acm-cnv-ocp-4.22-p2p.yaml	Adds the console-e2e base image, defines an OCP 4.22 candidate nightly release, and changes the AWS LP upgrade override to release:latest.
Spoke upgrade healthcheck budgets ci-operator/step-registry/acm/interop-p2p/spoke-upgrade-healthcheck/acm-interop-p2p-spoke-upgrade-healthcheck-ref.yaml	Increases the step timeout from 5 hours to 6 hours, raises MCP budget defaults from 35 to 40 minutes per node and from 210 to 240 minutes, and updates the corresponding documentation.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

• openshift/release#82111: Updates related interop release selection and upgrade image wiring.
• openshift/release#82117: Updates ACM interop release definitions and upgrade override wiring.

Suggested reviewers: ugreener

🚥 Pre-merge checks | ✅ 15

✅ Passed checks (15 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title is concise and relevant to the release image update, though it does not mention the related healthcheck timeout change.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	PR only changes CI YAML/step-registry config; no Ginkgo It/Describe/Context/When titles or dynamic title construction were introduced.
Test Structure And Quality	✅ Passed	PR only updates a ci-operator YAML step timeout/env docs; no Ginkgo test code or It/BeforeEach/Eventually patterns were changed.
Microshift Test Compatibility	✅ Passed	The only changed file updates a step-registry YAML timeout/docs; no new Ginkgo tests or MicroShift-unsafe APIs were added.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	No new Ginkgo e2e tests were added; the PR only updates CI step/YAML config and timeout values, so SNO-specific test compatibility is not implicated.
Topology-Aware Scheduling Compatibility	✅ Passed	PASS: The PR only updates CI release refs and healthcheck timeout/docs; no pod affinity, node selectors, or other topology-sensitive scheduling fields were added.
Ote Binary Stdout Contract	✅ Passed	The PR only changes a YAML step timeout and env docs; it introduces no process-level code or stdout writes that could break OTE JSON output.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	No new Ginkgo e2e tests were added; the PR only changes ci-operator/step-registry YAML, so there are no IPv4 or external-connectivity assumptions to flag.
No-Weak-Crypto	✅ Passed	Only YAML release/timeout changes; no weak-crypto terms, custom crypto, or secret-comparison code in the touched files.
Container-Privileges	✅ Passed	The touched YAMLs only change release/timeout/env values; no privileged, hostPID/hostNetwork/hostIPC, SYS_ADMIN, or allowPrivilegeEscalation settings appear.
No-Sensitive-Data-In-Logs	✅ Passed	Touched YAML only adjusts release/timeout settings and docs; no new log statements or secret-bearing output was added.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[shakyav]

/pj-rehearse periodic-ci-RedHatQE-interop-testing-master-acm-cnv-ocp-4.22-p2p-lp-interop-aws

[openshift-merge-bot]

@shakyav: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[openshift-ci]

@shakyav: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/rehearse/periodic-ci-RedHatQE-interop-testing-master-acm-cnv-ocp-4.22-p2p-lp-interop-aws	4a6d823	link	unknown	/pj-rehearse periodic-ci-RedHatQE-interop-testing-master-acm-cnv-ocp-4.22-p2p-lp-interop-aws

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: shakyav

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• ci-operator/config/RedHatQE/interop-testing/OWNERS [shakyav]
• ci-operator/jobs/RedHatQE/interop-testing/OWNERS [shakyav]
• ci-operator/step-registry/acm/interop-p2p/spoke-upgrade-healthcheck/OWNERS [shakyav]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[coderabbitai]

🧹 Nitpick comments (1)

ci-operator/step-registry/acm/interop-p2p/spoke-upgrade-healthcheck/acm-interop-p2p-spoke-upgrade-healthcheck-ref.yaml (1)

19-38: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick win

Update the associated README to match the new defaults.

The updated configuration defaults and step timeout in this file are now out of sync with the documentation in ci-operator/step-registry/acm/interop-p2p/spoke-upgrade-healthcheck/README.md, which still lists the previous values (5h, 210, and 35). Please update the README to reflect 6h, 240, and 40 to ensure the step documentation remains accurate.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In
`@ci-operator/step-registry/acm/interop-p2p/spoke-upgrade-healthcheck/acm-interop-p2p-spoke-upgrade-healthcheck-ref.yaml`
around lines 19 - 38, The README for the spoke upgrade healthcheck still
documents outdated timeout defaults. Update the associated README to replace the
previous step timeout and MCP values with 6h, 240 minutes, and 40 minutes,
matching the configuration in the step definition.

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In
`@ci-operator/step-registry/acm/interop-p2p/spoke-upgrade-healthcheck/acm-interop-p2p-spoke-upgrade-healthcheck-ref.yaml`:
- Around line 19-38: The README for the spoke upgrade healthcheck still
documents outdated timeout defaults. Update the associated README to replace the
previous step timeout and MCP values with 6h, 240 minutes, and 40 minutes,
matching the configuration in the step definition.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: b3a9a7c4-28ae-4252-b1ff-410be7c9c155

📥 Commits

Reviewing files that changed from the base of the PR and between 4a6d823 and 4435158.

📒 Files selected for processing (1)

• ci-operator/step-registry/acm/interop-p2p/spoke-upgrade-healthcheck/acm-interop-p2p-spoke-upgrade-healthcheck-ref.yaml

[openshift-merge-bot]

[REHEARSALNOTIFIER]
@shakyav: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name	Repo	Type	Reason
pull-ci-RedHatQE-interop-testing-master-acm-cnv-ocp-4.22-p2p-images	RedHatQE/interop-testing	presubmit	Ci-operator config changed
periodic-ci-RedHatQE-interop-testing-master-acm-cnv-ocp-4.22-p2p-lp-interop-aws	N/A	periodic	Ci-operator config changed
periodic-ci-RedHatQE-interop-testing-master-acm-cnv-ocp-4.21-p2p-lp-interop-aws	N/A	periodic	Registry content changed

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

[shakyav]

/pj-rehearse periodic-ci-RedHatQE-interop-testing-master-acm-cnv-ocp-4.22-p2p-lp-interop-aws

[openshift-merge-bot]

@shakyav: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.