Skip to content

Add TLS 1.3 adherence parameters to csi-operator TLS scanner job - #82133

Open
RomanBednar wants to merge 1 commit into
openshift:mainfrom
RomanBednar:feat/aws-ebs-tls-scanner
Open

Add TLS 1.3 adherence parameters to csi-operator TLS scanner job#82133
RomanBednar wants to merge 1 commit into
openshift:mainfrom
RomanBednar:feat/aws-ebs-tls-scanner

Conversation

@RomanBednar

@RomanBednar RomanBednar commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

Summary

Add TLS 1.3 adherence parameters to the tls-scanner-aws-ebs test in csi-operator CI configs.

Followup to #82134 which added the base TLS scanner test. This adds:

  • TLS_13_ENABLE_TLS_ADHERENCE: "true" env var
  • TLS_13_TLS_ADHERENCE_POLICY: StrictAllComponents env var
  • - ref: tls-13 step before tls-scanner-run

Pattern follows #81917 (GCP Filestore CSI driver operator).

Files changed

  • ci-operator/config/openshift/csi-operator/openshift-csi-operator-main.yaml
  • ci-operator/config/openshift/csi-operator/openshift-csi-operator-release-4.23.yaml
  • ci-operator/config/openshift/csi-operator/openshift-csi-operator-release-5.0.yaml
  • ci-operator/config/openshift/csi-operator/openshift-csi-operator-release-5.1.yaml

Summary by CodeRabbit

  • Enables TLS 1.3 adherence checks for the AWS EBS TLS scanner in the csi-operator CI configurations for main, release-4.23, release-5.0, and release-5.1.
  • Applies a strict TLS adherence policy and adds the tls-13 test alongside the existing scanner test.

@coderabbitai

coderabbitai Bot commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

Walkthrough

The CSI operator TLS scanner configuration enables TLS 1.3 adherence and adds the tls-13 test to main and release 4.23, 5.0, and 5.1 CI configurations.

Changes

TLS 1.3 scanner configuration

Layer / File(s) Summary
Enable TLS 1.3 adherence across CSI operator profiles
ci-operator/config/openshift/csi-operator/openshift-csi-operator-*.yaml
The tls-scanner-aws-ebs step sets TLS 1.3 adherence environment variables and adds tls-13 alongside the existing scanner test.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

Suggested reviewers: tsmetana, dobsonj, jmguzik, jkyros

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed Only CI YAML changed; the new tls-13 and tls-scanner-run refs are static and no Ginkgo It/Describe/Context/When titles were added.
Test Structure And Quality ✅ Passed PR changes only ci-operator YAML; no Ginkgo test code, fixtures, waits, or assertions were modified.
Microshift Test Compatibility ✅ Passed PASS: The PR only updates ci-operator YAML to wire in the existing tls-13 step; no new Ginkgo tests or MicroShift-specific test code were added.
Single Node Openshift (Sno) Test Compatibility ✅ Passed Only ci-operator YAML changed; the added tls-13 ref is an existing shared step-registry step, and no new Ginkgo e2e tests or SNO-unsafe assumptions were added.
Topology-Aware Scheduling Compatibility ✅ Passed Only ci-operator test config changed; the new tls-scanner job adds env vars and a tls-13 step ref, with no node selectors, affinity, spread constraints, or PDBs.
Ote Binary Stdout Contract ✅ Passed PR only changes ci-operator YAML job config; no Go/test binary code or process-level stdout writes were introduced, so the contract is unaffected.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed Only ci-operator YAML changed; no new Ginkgo tests or network-sensitive code were added, so the check is not applicable.
No-Weak-Crypto ✅ Passed The changed csi-operator configs only add TLS 1.3 adherence env vars and tls-scanner refs; no MD5/SHA1/DES/RC4/3DES/Blowfish, custom crypto, or unsafe comparisons found.
Container-Privileges ✅ Passed PASS: the PR only adds TLS scanner refs/env vars; no changed manifest introduces privileged/hostNetwork/root settings, and the existing scanner step already documents its required privileges.
No-Sensitive-Data-In-Logs ✅ Passed The PR only adds TLS scanner env vars and a test ref in YAML; no new logging or sensitive data exposure appears in the diff.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: adding TLS 1.3 adherence settings to the csi-operator TLS scanner job.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 20, 2026
@openshift-ci
openshift-ci Bot requested review from dobsonj and tsmetana July 20, 2026 07:47
@RomanBednar

Copy link
Copy Markdown
Contributor Author

Closing: wrong target repo (aws-ebs-csi-driver-operator). Reopening with correct target (csi-operator).

Add TLS_13_ENABLE_TLS_ADHERENCE, TLS_13_TLS_ADHERENCE_POLICY env vars
and tls-13 step ref to tls-scanner-aws-ebs test in csi-operator configs
for main, release-4.23, release-5.0, and release-5.1.

This follows the pattern established in PR openshift#81917 for GCP Filestore
and is a followup to PR openshift#82134 which added the base TLS scanner test.
@RomanBednar
RomanBednar force-pushed the feat/aws-ebs-tls-scanner branch from c2915dd to 6df339f Compare July 22, 2026 06:37
@RomanBednar RomanBednar changed the title Add TLS scanner job to aws-ebs-csi-driver-operator Add TLS 1.3 adherence parameters to csi-operator TLS scanner job Jul 22, 2026
@openshift-ci

openshift-ci Bot commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RomanBednar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@RomanBednar: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-csi-operator-main-tls-scanner-aws-ebs openshift/csi-operator presubmit Ci-operator config changed
pull-ci-openshift-csi-operator-release-4.23-tls-scanner-aws-ebs openshift/csi-operator presubmit Ci-operator config changed
pull-ci-openshift-csi-operator-release-5.1-tls-scanner-aws-ebs openshift/csi-operator presubmit Ci-operator config changed
pull-ci-openshift-csi-operator-release-5.0-tls-scanner-aws-ebs openshift/csi-operator presubmit Ci-operator config changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@RomanBednar

Copy link
Copy Markdown
Contributor Author

/pj-rehearse pull-ci-openshift-csi-operator-main-tls-scanner-aws-ebs pull-ci-openshift-csi-operator-release-4.23-tls-scanner-aws-ebs

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@RomanBednar: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@RomanBednar

Copy link
Copy Markdown
Contributor Author

/pj-rehearse pull-ci-openshift-csi-operator-release-4.23-tls-scanner-aws-ebs

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@RomanBednar: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci

openshift-ci Bot commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

@RomanBednar: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/openshift/csi-operator/main/tls-scanner-aws-ebs 6df339f link unknown /pj-rehearse pull-ci-openshift-csi-operator-main-tls-scanner-aws-ebs
ci/rehearse/openshift/csi-operator/release-4.23/tls-scanner-aws-ebs 6df339f link unknown /pj-rehearse pull-ci-openshift-csi-operator-release-4.23-tls-scanner-aws-ebs

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant