origin: allow missing architectures for node-perf images by jubittajohn · Pull Request #82153 · openshift/release

jubittajohn · 2026-07-20T14:54:25Z

node-perf-pytorch-wide-deep is a new image introduced in 1.36 in Add PyTorch Wide-Deep node performance test image kubernetes/kubernetes#136397. It replaced the old node-perf-tf-wide-deep image .(which had only the amd64/arm64 architectures as well). It doesn't have ppc64le/s390x because PyTorch doesn't publish pip wheels for those architectures
e2e-19-registry-k8s-io-e2e-test-images-node-perf-tf-wide-deep can only be removed after OCPSTRAT-3036: Rebase 1.36.2 origin#31237 lands and that reference is removed from zz_generated.txt
node-perf-npb-is existed before, but its ppc64le/s390x architectures were removed in 1.36 in Remove ppc64le and s390x support from npb-is image kubernetes/kubernetes#136429 because they never actually built successfully. Had its architectures removed due to a linker relocation overflow (R_PPC64_TOC16_HA) on ppc64le with the large CLASS=D arrays.

Summary by CodeRabbit

Updates OpenShift Origin CI’s verify-image-manifest-lists job configuration (ci-operator/config/openshift/origin/) to prevent false failures when Kubernetes 1.36-era node-perf images don’t publish all architecture variants in their manifest lists:

In openshift-origin-main.yaml, extends the --allow-missing-architectures allowlist to also permit missing arches for:
- registry-k8s-io/e2e-test-images/node-perf-npb
- registry-k8s-io/e2e-test-images/node-perf-pytorch-wide-deep
- (keeps the existing allowance for node-perf-tf-wide-deep).
Applies the same --allow-missing-architectures allowlist updates in openshift-origin-release-4.23.yaml and openshift-origin-release-5.0.yaml.

coderabbitai · 2026-07-20T14:55:15Z

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

@coderabbitai resume to resume automatic reviews.
@coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

▶️ Resume reviews
🔍 Trigger review

Walkthrough

The manifest-list verification step now allows missing architectures for node-perf-npb and node-perf-pytorch-wide-deep in the main, 4.23, and 5.0 configurations.

Changes

Manifest verification configuration

Layer / File(s)	Summary
Extend allowed missing architectures `ci-operator/config/openshift/origin/openshift-origin-main.yaml`, `ci-operator/config/openshift/origin/openshift-origin-release-4.23.yaml`, `ci-operator/config/openshift/origin/openshift-origin-release-5.0.yaml`	Adds `node-perf-npb` and `node-perf-pytorch-wide-deep` to the verification command’s allowed missing architectures.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Suggested reviewers: sjenning, deads2k

🚥 Pre-merge checks | ✅ 15

✅ Passed checks (15 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly summarizes the main change: allowing missing architectures for node-perf images in Origin configs.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	The PR only edits CI YAML allowlists; no Ginkgo It/Describe/Context/When test titles are added or changed.
Test Structure And Quality	✅ Passed	PASS: The PR only updates CI YAML allowlists; no Ginkgo test code or cluster-interacting tests were changed, so the test-structure check is not applicable.
Microshift Test Compatibility	✅ Passed	PR only updates ci-operator YAML allowlists for image-manifest verification; no new Ginkgo e2e tests or API usage were added.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	Diff only updates ci-operator YAML allowlists; no new Ginkgo tests or multi-node assumptions were added.
Topology-Aware Scheduling Compatibility	✅ Passed	Only ci-operator test config changed; no deployment manifests, operators, or controllers, and no scheduling/topology settings were added.
Ote Binary Stdout Contract	✅ Passed	Only ci-operator YAML allowlist entries changed; no main/TestMain/BeforSuite stdout-writing code was touched.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	The PR only updates ci-operator YAML allowlists; it adds no new Ginkgo tests or networking code, so there are no IPv4 or external-connectivity concerns to flag.
No-Weak-Crypto	✅ Passed	The PR only adds image allowlist entries in three YAML CI configs; no weak crypto, custom crypto, or secret comparisons are present.
Container-Privileges	✅ Passed	The PR only adds allow-missing-architectures entries; no privileged, hostPID/Network/IPC, SYS_ADMIN, root, or allowPrivilegeEscalation settings were introduced.
No-Sensitive-Data-In-Logs	✅ Passed	The diff only adds image allowlist entries in CI YAML; no log statements or sensitive data patterns were introduced.

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

_{Comment @coderabbitai help to get the list of available commands.}

jubittajohn · 2026-07-20T15:25:20Z

/pj-rehearse pull-ci-openshift-origin-main-verify-image-manifest-lists

openshift-merge-bot · 2026-07-20T15:25:23Z

@jubittajohn: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

openshift-merge-bot · 2026-07-20T16:06:53Z

@jubittajohn: pj-rehearse could not automatically process this event because the request waited in queue for longer than 5 minutes. Use /pj-rehearse to trigger rehearsals manually.

jubittajohn · 2026-07-20T16:14:44Z

/pj-rehearse pull-ci-openshift-origin-main-verify-image-manifest-lists

openshift-merge-bot · 2026-07-20T16:15:31Z

@jubittajohn: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

jubittajohn · 2026-07-20T20:02:14Z

/pj-rehearse pull-ci-openshift-origin-main-verify-image-manifest-lists
/pj-rehearse pull-ci-openshift-origin-release-5.0-verify-image-manifest-lists
/pj-rehearse pull-ci-openshift-origin-release-4.23-verify-image-manifest-lists

openshift-merge-bot · 2026-07-20T20:02:17Z

@jubittajohn: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

openshift-merge-bot · 2026-07-20T20:06:09Z

@jubittajohn: requesting more than one rehearsal in one comment is not supported. If you would like to rehearse multiple specific jobs, please separate the job names by a space in a single command.

openshift-merge-bot · 2026-07-20T20:06:09Z

@jubittajohn: requesting more than one rehearsal in one comment is not supported. If you would like to rehearse multiple specific jobs, please separate the job names by a space in a single command.

jubittajohn · 2026-07-20T20:09:57Z

/pj-rehearse pull-ci-openshift-origin-release-5.0-verify-image-manifest-lists

openshift-merge-bot · 2026-07-20T20:10:00Z

@jubittajohn: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

jubittajohn · 2026-07-20T20:10:09Z

/pj-rehearse pull-ci-openshift-origin-release-4.23-verify-image-manifest-lists

openshift-merge-bot · 2026-07-20T20:10:12Z

@jubittajohn: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

Signed-off-by: jubittajohn <jujohn@redhat.com>

jubittajohn · 2026-07-20T21:06:54Z

/pj-rehearse pull-ci-openshift-origin-main-verify-image-manifest-lists

jubittajohn · 2026-07-20T21:07:01Z

/pj-rehearse pull-ci-openshift-origin-release-5.0-verify-image-manifest-lists

openshift-merge-bot · 2026-07-20T21:07:04Z

@jubittajohn: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

jubittajohn · 2026-07-20T21:07:10Z

/pj-rehearse pull-ci-openshift-origin-release-4.23-verify-image-manifest-lists

openshift-merge-bot · 2026-07-20T21:07:12Z

@jubittajohn: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

jacobsee · 2026-07-20T21:07:42Z

/lgtm

openshift-merge-bot · 2026-07-20T21:08:13Z

@jubittajohn: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

openshift-merge-bot · 2026-07-20T21:10:04Z

[REHEARSALNOTIFIER]
@jubittajohn: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name	Repo	Type	Reason
pull-ci-openshift-origin-main-verify-image-manifest-lists	openshift/origin	presubmit	Ci-operator config changed
pull-ci-openshift-origin-release-4.23-verify-image-manifest-lists	openshift/origin	presubmit	Ci-operator config changed
pull-ci-openshift-origin-release-5.0-verify-image-manifest-lists	openshift/origin	presubmit	Ci-operator config changed

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

openshift-ci · 2026-07-20T21:44:16Z

@jubittajohn: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

jubittajohn · 2026-07-21T00:31:08Z

/pj-rehearse ack

openshift-merge-bot · 2026-07-21T00:31:11Z

@jubittajohn: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

bertinatto

/lgtm

openshift-ci · 2026-07-21T13:30:25Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bertinatto, jacobsee, jubittajohn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~ci-operator/config/openshift/origin/OWNERS~~ [bertinatto]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

…2153) Signed-off-by: jubittajohn <jujohn@redhat.com>

openshift-ci Bot requested review from deads2k and sjenning July 20, 2026 14:55

jubittajohn force-pushed the node-perf-manifest-list-exception branch from 1792e91 to e3c6204 Compare July 20, 2026 14:58

jubittajohn force-pushed the node-perf-manifest-list-exception branch from e3c6204 to d4e920c Compare July 20, 2026 16:01

jubittajohn force-pushed the node-perf-manifest-list-exception branch from d4e920c to db10ce1 Compare July 20, 2026 19:53

origin: allow missing architectures for node-perf images

943af04

Signed-off-by: jubittajohn <jujohn@redhat.com>

jubittajohn force-pushed the node-perf-manifest-list-exception branch from db10ce1 to 943af04 Compare July 20, 2026 21:06

openshift-ci Bot assigned jacobsee Jul 20, 2026

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jul 20, 2026

openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jul 21, 2026

bertinatto reviewed Jul 21, 2026

View reviewed changes

openshift-ci Bot assigned bertinatto Jul 21, 2026

openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 21, 2026

openshift-merge-bot Bot merged commit aed2164 into openshift:main Jul 21, 2026
17 checks passed

fracappa pushed a commit to fracappa/release that referenced this pull request Jul 22, 2026

$@fracappa$

origin: allow missing architectures for node-perf images (openshift#8…

39ef86d

…2153) Signed-off-by: jubittajohn <jujohn@redhat.com>

Uh oh!

Conversation

jubittajohn commented Jul 20, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented Jul 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviews paused

Walkthrough

Changes

Uh oh!

jubittajohn commented Jul 20, 2026

Uh oh!

openshift-merge-bot Bot commented Jul 20, 2026

Uh oh!

openshift-merge-bot Bot commented Jul 20, 2026

Uh oh!

jubittajohn commented Jul 20, 2026

Uh oh!

openshift-merge-bot Bot commented Jul 20, 2026

Uh oh!

jubittajohn commented Jul 20, 2026

Uh oh!

openshift-merge-bot Bot commented Jul 20, 2026

Uh oh!

openshift-merge-bot Bot commented Jul 20, 2026

Uh oh!

openshift-merge-bot Bot commented Jul 20, 2026

Uh oh!

jubittajohn commented Jul 20, 2026

Uh oh!

openshift-merge-bot Bot commented Jul 20, 2026

Uh oh!

jubittajohn commented Jul 20, 2026

Uh oh!

openshift-merge-bot Bot commented Jul 20, 2026

Uh oh!

jubittajohn commented Jul 20, 2026

Uh oh!

jubittajohn commented Jul 20, 2026

Uh oh!

openshift-merge-bot Bot commented Jul 20, 2026

Uh oh!

jubittajohn commented Jul 20, 2026

Uh oh!

openshift-merge-bot Bot commented Jul 20, 2026

Uh oh!

jacobsee commented Jul 20, 2026

Uh oh!

openshift-merge-bot Bot commented Jul 20, 2026

Uh oh!

openshift-merge-bot Bot commented Jul 20, 2026

Uh oh!

openshift-ci Bot commented Jul 20, 2026

Uh oh!

jubittajohn commented Jul 21, 2026

Uh oh!

openshift-merge-bot Bot commented Jul 21, 2026

Uh oh!

bertinatto left a comment

Choose a reason for hiding this comment

Uh oh!

openshift-ci Bot commented Jul 21, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

jubittajohn commented Jul 20, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Jul 20, 2026 •

edited

Loading