Skip to content

Enable ready-for-humans plugin for openshift/router#82379

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
bentito:enable-ready-for-humans-router
Jul 24, 2026
Merged

Enable ready-for-humans plugin for openshift/router#82379
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
bentito:enable-ready-for-humans-router

Conversation

@bentito

@bentito bentito commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

This PR registers the 'openshift/router' repository under the 'openshift' organization with the 'ready-for-humans' plugin in ship-hook.yaml. This automatically applies the 'ready-for-human-review' label once the CodeRabbit bot review has successfully completed, as discussed in openshift/router#798.

Summary by CodeRabbit

  • Registers openshift/router for the ready-for-humans plugin.
  • Automatically applies the ready-for-human-review label after a successful CodeRabbit review.

@openshift-merge-bot openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jul 23, 2026
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@bentito: no rehearsable tests are affected by this change

Note: If this PR includes changes to step registry files (ci-operator/step-registry/) and you expected jobs to be found, try rebasing your PR onto the base branch. This helps pj-rehearse accurately detect changes when the base branch has moved forward.

@openshift-ci
openshift-ci Bot requested review from psalajova and smg247 July 23, 2026 20:05
@coderabbitai

coderabbitai Bot commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: a0914f5b-82c1-4d3b-90f8-0e45e0a103ed

📥 Commits

Reviewing files that changed from the base of the PR and between b01f46a and b9650b6.

📒 Files selected for processing (1)
  • clusters/app.ci/prow/03_deployment/ship-hook.yaml

Walkthrough

The ship-hook ConfigMap’s embedded Prow configuration now registers the router repository under orgs.open_shift.repos and enables the ready-for-humans plugin.

Changes

Router plugin configuration

Layer / File(s) Summary
Register router repository plugin
clusters/app.ci/prow/03_deployment/ship-hook.yaml
Adds the router repository entry with the ready-for-humans plugin.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Suggested reviewers: petr-muller

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: enabling the ready-for-humans plugin for openshift/router.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed Only ship-hook.yaml config changed; no Ginkgo tests or test titles were added or modified.
Test Structure And Quality ✅ Passed PASS: The PR only edits ship-hook.yaml to add router to ready-for-humans; no Ginkgo tests or cluster-interaction code were changed.
Microshift Test Compatibility ✅ Passed Only ship-hook.yaml changed; no Ginkgo/e2e tests were added or modified, so MicroShift compatibility is unaffected.
Single Node Openshift (Sno) Test Compatibility ✅ Passed Only a ship-hook config YAML changed; no Ginkgo test files or new test bodies were added, so SNO compatibility isn’t applicable.
Topology-Aware Scheduling Compatibility ✅ Passed Only a router plugin entry was added; the deployment spec and its existing scheduling settings were unchanged.
Ote Binary Stdout Contract ✅ Passed PR only adds a YAML repo/plugin entry in ship-hook config; no process-level code or stdout writes were changed.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed This PR only adds a ship-hook repo plugin entry in YAML; no Ginkgo tests or network-dependent test code were added.
No-Weak-Crypto ✅ Passed Diff only adds a Prow plugin entry for openshift/router in ship-hook.yaml; no crypto, token handling, or comparisons were changed.
Container-Privileges ✅ Passed Diff only adds a repo/plugin entry in ship-hook config; no privileged=true, hostNetwork/PID/IPC, SYS_ADMIN, root, or allowPrivilegeEscalation=true fields appear.
No-Sensitive-Data-In-Logs ✅ Passed The only change adds a repo plugin entry in ship-hook config; no new logs or sensitive data are introduced.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@openshift-ci

openshift-ci Bot commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

@bentito: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@bentito

bentito commented Jul 23, 2026

Copy link
Copy Markdown
Contributor Author

/assign @rikatz

@rikatz

rikatz commented Jul 23, 2026

Copy link
Copy Markdown
Member

/lgtm
/approve
tho my approval counts nothing here

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jul 23, 2026
@danilo-gemoli

Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci

openshift-ci Bot commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bentito, danilo-gemoli, rikatz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 24, 2026
@openshift-merge-bot
openshift-merge-bot Bot merged commit b9e2137 into openshift:main Jul 24, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants