fix(omc): use llmisvc_core marker for e2e test selection#82422
Conversation
The upstream marker refactor (kserve#5771) replaced @pytest.mark.autoscaling with auto-assigned llmisvc_autoscaling from the filename. The old "not autoscaling" negative filter no longer excludes autoscaling tests, causing them to run in the non-autoscaling CI job and exhaust the 2h Prow timeout. Switch to the positive llmisvc_core marker which conftest auto-assigns to non-autoscaling, non-tracing test files. This correctly excludes autoscaling_hpa, autoscaling_keda, and tracing tests. pvc_storage still needs explicit exclusion as those tests live inside llmisvc_core files. Mirrors the kserve fix in 4a2a9e0. Signed-off-by: James Ostrander <jostrand@redhat.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
WalkthroughThe ChangesLLMISVC E2E configuration
Estimated code review effort: 1 (Trivial) | ~2 minutes 🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jlost The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
[REHEARSALNOTIFIER]
Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals. Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
/pj-rehearse auto-ack |
|
@jlost: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
@jlost: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Summary
e2e-kserve-llmisvcpytest marker from negative filter (not autoscaling and not tracing) to positivellmisvc_coremarker on bothmainandincubatingbranch configs@pytest.mark.autoscalingwith auto-assignedllmisvc_autoscalingfrom filename convention. The oldnot autoscalingno longer excludes autoscaling tests, causing all WVA autoscaling tests to run in the non-autoscaling CI job and exhaust the 2h Prow timeoutTest plan
e2e-kserve-llmisvcno longer runs autoscaling_wva tests (e.g. opendatahub-io/odh-model-controller#893)Summary by CodeRabbit
e2e-kserve-llmisvcCI test selection in themainandincubatingconfigurations.llmisvc_core and cluster_cpumarker, while retaining thepvc_storageexclusion.