Skip to content

fix(omc): use llmisvc_core marker for e2e test selection#82422

Open
jlost wants to merge 1 commit into
openshift:mainfrom
jlost:fix/omc-llmisvc-core-marker
Open

fix(omc): use llmisvc_core marker for e2e test selection#82422
jlost wants to merge 1 commit into
openshift:mainfrom
jlost:fix/omc-llmisvc-core-marker

Conversation

@jlost

@jlost jlost commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Switch odh-model-controller e2e-kserve-llmisvc pytest marker from negative filter (not autoscaling and not tracing) to positive llmisvc_core marker on both main and incubating branch configs
  • The upstream marker refactor (kserve#5771) replaced @pytest.mark.autoscaling with auto-assigned llmisvc_autoscaling from filename convention. The old not autoscaling no longer excludes autoscaling tests, causing all WVA autoscaling tests to run in the non-autoscaling CI job and exhaust the 2h Prow timeout
  • Mirrors the kserve fix in 4a2a9e0

Test plan

Summary by CodeRabbit

  • Updates odh-model-controller’s e2e-kserve-llmisvc CI test selection in the main and incubating configurations.
  • Replaces ineffective negative autoscaling/tracing filters with the llmisvc_core and cluster_cpu marker, while retaining the pvc_storage exclusion.
  • Prevents autoscaling WVA tests from running in the non-autoscaling job and exceeding the 2-hour Prow timeout.

The upstream marker refactor (kserve#5771) replaced @pytest.mark.autoscaling
with auto-assigned llmisvc_autoscaling from the filename. The old
"not autoscaling" negative filter no longer excludes autoscaling tests,
causing them to run in the non-autoscaling CI job and exhaust the 2h
Prow timeout.

Switch to the positive llmisvc_core marker which conftest auto-assigns
to non-autoscaling, non-tracing test files. This correctly excludes
autoscaling_hpa, autoscaling_keda, and tracing tests. pvc_storage still
needs explicit exclusion as those tests live inside llmisvc_core files.

Mirrors the kserve fix in 4a2a9e0.

Signed-off-by: James Ostrander <jostrand@redhat.com>
@coderabbitai

coderabbitai Bot commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: fb6b2e58-aa88-4e89-8a5b-d66dfd29e748

📥 Commits

Reviewing files that changed from the base of the PR and between 4569ede and e60ef29.

📒 Files selected for processing (2)
  • ci-operator/config/opendatahub-io/odh-model-controller/opendatahub-io-odh-model-controller-incubating.yaml
  • ci-operator/config/opendatahub-io/odh-model-controller/opendatahub-io-odh-model-controller-main.yaml

Walkthrough

The e2e-kserve-llmisvc CI test selector changes from an llminferenceservice-based filter to llmisvc_core and cluster_cpu, while retaining the pvc_storage exclusion and existing trailing parameters in both configurations.

Changes

LLMISVC E2E configuration

Layer / File(s) Summary
Update LLMISVC E2E test selection
ci-operator/config/opendatahub-io/odh-model-controller/opendatahub-io-odh-model-controller-incubating.yaml, ci-operator/config/opendatahub-io/odh-model-controller/opendatahub-io-odh-model-controller-main.yaml
The test command now selects llmisvc_core and cluster_cpu, excludes pvc_storage, and preserves the existing trailing parameters.

Estimated code review effort: 1 (Trivial) | ~2 minutes

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly matches the main change: switching e2e test selection to the llmisvc_core marker in odh-model-controller CI config.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed PR only updates ci-operator YAML test selectors; no Ginkgo It/Describe/Context/When titles were added or changed.
Test Structure And Quality ✅ Passed PR only changes ci-operator YAML test selection; no Ginkgo test code or fixtures were modified, so the checklist is not applicable.
Microshift Test Compatibility ✅ Passed Only CI job test-selection YAML changed; no new Ginkgo tests or API usage were added, so MicroShift compatibility is not implicated.
Single Node Openshift (Sno) Test Compatibility ✅ Passed Only ci-operator YAML changed; no Ginkgo test code or new test definitions were added, so the SNO compatibility check is not applicable.
Topology-Aware Scheduling Compatibility ✅ Passed Only ci-operator test marker strings changed; no deployment/controller manifests or scheduling fields (affinity, nodeSelector, PDBs, replicas) were added.
Ote Binary Stdout Contract ✅ Passed PR only changes ci-operator YAML test selectors; no runtime code, suite setup, or stdout-writing process code was modified.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed Only ci-operator YAML test selectors changed; no new Ginkgo tests or network code were added, so this compatibility check is not applicable.
No-Weak-Crypto ✅ Passed Only ci-operator test selector strings changed; no MD5/SHA1/DES/RC4/3DES/Blowfish/ECB, custom crypto, or secret comparisons appear.
Container-Privileges ✅ Passed The PR only changes KSERVE_E2E_TEST_ARGS in two ci-operator YAMLs; no privileged/host* securityContext fields or root settings appear in the touched files.
No-Sensitive-Data-In-Logs ✅ Passed Changed CI commands only adjust pytest markers; no passwords, tokens, API keys, PII, hostnames, or customer data appear in the modified lines.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@openshift-ci
openshift-ci Bot requested review from Jooho and israel-hdez July 24, 2026 17:28
@openshift-ci

openshift-ci Bot commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jlost

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 24, 2026
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@jlost: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-opendatahub-io-odh-model-controller-main-e2e-kserve-llmisvc opendatahub-io/odh-model-controller presubmit Ci-operator config changed
pull-ci-opendatahub-io-odh-model-controller-incubating-e2e-kserve-llmisvc opendatahub-io/odh-model-controller presubmit Ci-operator config changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@jlost

jlost commented Jul 24, 2026

Copy link
Copy Markdown
Contributor Author

/pj-rehearse auto-ack

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@jlost: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci

openshift-ci Bot commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

@jlost: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/opendatahub-io/odh-model-controller/main/e2e-kserve-llmisvc e60ef29 link unknown /pj-rehearse pull-ci-opendatahub-io-odh-model-controller-main-e2e-kserve-llmisvc

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant