Skip to content

Update fleetshift UI and all-in-one image CI for fleetshift-poc monorepo merger#82427

Open
alechenninger wants to merge 1 commit into
openshift:mainfrom
alechenninger:fleetshift-monorepo
Open

Update fleetshift UI and all-in-one image CI for fleetshift-poc monorepo merger#82427
alechenninger wants to merge 1 commit into
openshift:mainfrom
alechenninger:fleetshift-monorepo

Conversation

@alechenninger

@alechenninger alechenninger commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

Summary

Fold fleetshift-user-interface jobs into a ui variant with path filters, and assemble the AIO image from this commit's server-local and web builds.

Motivation

  • The old UI repo is deprecated, new images must be built from the new location inside the monorepo
  • Now that everything is colocated, build the AIO image from a consistent snapshot of the repository, to ensure backend & frontend consistency

Summary by CodeRabbit

  • Migrates Fleetshift UI CI from the standalone repository into the fleetshift-poc monorepo using a ui variant and fleetshift-ui/ path filters.
  • Adds server-local and web image builds, and assembles the all-in-one Fleetshift image from those consistent commit-local artifacts.
  • Expands image build triggers and adds pull-request and merge image-mirror jobs.
  • Removes obsolete standalone Fleetshift UI CI ownership and sanitize-Prow job entries.

Fold fleetshift-user-interface jobs into a ui variant with path filters,
and assemble the AIO image from this commit's server-local and web builds.

Co-authored-by: Cursor <cursoragent@cursor.com>
@coderabbitai

coderabbitai Bot commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: 2f31d556-b191-46da-a8ea-e72a859402c2

📥 Commits

Reviewing files that changed from the base of the PR and between a912569 and f622e0d.

⛔ Files ignored due to path filters (7)
  • ci-operator/jobs/fleetshift/fleetshift-poc/fleetshift-fleetshift-poc-main-periodics.yaml is excluded by !ci-operator/jobs/**
  • ci-operator/jobs/fleetshift/fleetshift-poc/fleetshift-fleetshift-poc-main-postsubmits.yaml is excluded by !ci-operator/jobs/**
  • ci-operator/jobs/fleetshift/fleetshift-poc/fleetshift-fleetshift-poc-main-presubmits.yaml is excluded by !ci-operator/jobs/**
  • ci-operator/jobs/fleetshift/fleetshift-user-interface/OWNERS is excluded by !ci-operator/jobs/**
  • ci-operator/jobs/fleetshift/fleetshift-user-interface/fleetshift-fleetshift-user-interface-main-periodics.yaml is excluded by !ci-operator/jobs/**
  • ci-operator/jobs/fleetshift/fleetshift-user-interface/fleetshift-fleetshift-user-interface-main-postsubmits.yaml is excluded by !ci-operator/jobs/**
  • ci-operator/jobs/fleetshift/fleetshift-user-interface/fleetshift-fleetshift-user-interface-main-presubmits.yaml is excluded by !ci-operator/jobs/**
📒 Files selected for processing (5)
  • ci-operator/config/fleetshift/fleetshift-poc/fleetshift-fleetshift-poc-main.yaml
  • ci-operator/config/fleetshift/fleetshift-poc/fleetshift-fleetshift-poc-main__fleetshift.yaml
  • ci-operator/config/fleetshift/fleetshift-poc/fleetshift-fleetshift-poc-main__ui.yaml
  • ci-operator/config/fleetshift/fleetshift-user-interface/OWNERS
  • core-services/sanitize-prow-jobs/_config.yaml
💤 Files with no reviewable changes (2)
  • ci-operator/config/fleetshift/fleetshift-user-interface/OWNERS
  • core-services/sanitize-prow-jobs/_config.yaml

Walkthrough

Fleetshift CI image definitions now include server-local and UI inputs, with path-based triggers for UI changes. New image-mirroring jobs and skip rules were added, metadata was reassigned to the POC UI variant, and obsolete user-interface job registrations were removed.

Changes

Fleetshift CI configuration

Layer / File(s) Summary
Fleetshift image builds and mirroring
ci-operator/config/fleetshift/fleetshift-poc/fleetshift-fleetshift-poc-main__fleetshift.yaml
Adds server-local and web image definitions, expands image change detection, and defines pull-request and merge image-mirroring jobs.
UI image build and path gating
ci-operator/config/fleetshift/fleetshift-poc/fleetshift-fleetshift-poc-main__ui.yaml, ci-operator/config/fleetshift/fleetshift-poc/fleetshift-fleetshift-poc-main.yaml
Scopes UI builds and mirror jobs to fleetshift-ui/ changes, updates generated metadata to the POC UI variant, and adds matching skip rules to Fleetshift CI steps.
Obsolete job registration cleanup
ci-operator/config/fleetshift/fleetshift-user-interface/OWNERS, core-services/sanitize-prow-jobs/_config.yaml
Removes the user-interface ownership configuration and sanitized job entries while updating nearby OpenShift job registrations.

Estimated code review effort: 2 (Simple) | ~10 minutes

Suggested reviewers: redhat-chai-bot

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the monorepo merger and the UI/all-in-one CI updates.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed PR only changes ci-operator/prow YAML and deletes old job configs; no Ginkgo test titles or test code were modified.
Test Structure And Quality ✅ Passed PR only changes CI YAML/OWNERS; no Ginkgo test files or test code were modified, so this test-structure check is not applicable.
Microshift Test Compatibility ✅ Passed No Go/e2e test code changed; this PR only updates CI/job YAML and OWNERS, so MicroShift compatibility isn’t implicated.
Single Node Openshift (Sno) Test Compatibility ✅ Passed PASS: The PR only changes ci-operator/job YAML for Fleetshift CI; no Go/Ginkgo e2e test bodies or topology-sensitive logic were added.
Topology-Aware Scheduling Compatibility ✅ Passed Only CI config, sanitize-prow-jobs, and OWNERS changed; no deployment manifests, controllers, replicas, affinity, nodeSelectors, or PDBs were modified.
Ote Binary Stdout Contract ✅ Passed HEAD only changes CI YAML/OWNERS; no Go/test binary code or process-level stdout paths were modified.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed Only CI YAML/OWNERS files changed; no new Ginkgo e2e tests or network code was added, so the IPv6/disconnected check is not applicable.
No-Weak-Crypto ✅ Passed Only CI YAML/OWNERS changed; added path filters and image/job wiring, with no MD5/SHA1/DES/RC4/3DES/Blowfish/ECB, custom crypto, or secret comparisons.
Container-Privileges ✅ Passed No added privileged, hostPID/hostNetwork/hostIPC, SYS_ADMIN, allowPrivilegeEscalation, or root settings appear in the changed YAMLs.
No-Sensitive-Data-In-Logs ✅ Passed No new logging or plaintext sensitive data was added; the PR only updates CI/job YAML with path filters and secret mount references.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@openshift-ci

openshift-ci Bot commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: alechenninger
Once this PR has been reviewed and has the lgtm label, please assign smg247 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@alechenninger: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-fleetshift-fleetshift-poc-main-fleetshift-pr-image-mirror fleetshift/fleetshift-poc presubmit Presubmit changed
pull-ci-fleetshift-fleetshift-poc-main-ui-images fleetshift/fleetshift-poc presubmit Presubmit changed
pull-ci-fleetshift-fleetshift-poc-main-ui-pr-image-mirror fleetshift/fleetshift-poc presubmit Presubmit changed
pull-ci-fleetshift-fleetshift-poc-main-fleetshift-images fleetshift/fleetshift-poc presubmit Ci-operator config changed
pull-ci-fleetshift-fleetshift-poc-main-images fleetshift/fleetshift-poc presubmit Ci-operator config changed
pull-ci-fleetshift-fleetshift-poc-main-pr-image-mirror fleetshift/fleetshift-poc presubmit Ci-operator config changed
pull-ci-fleetshift-fleetshift-poc-main-pr-image-mirror-local fleetshift/fleetshift-poc presubmit Ci-operator config changed
periodic-ci-fleetshift-fleetshift-poc-main-ui-republish-latest N/A periodic Periodic changed
periodic-ci-fleetshift-fleetshift-poc-main-republish-local-latest N/A periodic Ci-operator config changed
periodic-ci-fleetshift-fleetshift-poc-main-fleetshift-republish-latest N/A periodic Ci-operator config changed
periodic-ci-fleetshift-fleetshift-poc-main-republish-latest N/A periodic Ci-operator config changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci

openshift-ci Bot commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

@alechenninger: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant