ACM-36515: Bump CI build images to Go 1.25 for cluster-api-provider-kubevirt release-4.19 by nindsimonv · Pull Request #82431 · openshift/release

nindsimonv · 2026-07-24T20:40:00Z

Summary

Update build_root and dockerfile_literal Go toolchain from rhel-9-release-golang-1.24-openshift-4.21 to rhel-9-release-golang-1.25-openshift-4.22 for cluster-api-provider-kubevirt release-4.19 CI config.
Required because CAPK release-4.19 will bump golang.org/x/crypto to v0.52.0 (fixing CVE-2026-39829 + related CVEs), which requires Go 1.25.0.
Jira: ACM-36515 (MCE 2.9 / OCP 4.19)

Why

Without this change, CI jobs for the CAPK release-4.19 crypto bump would fail with:
go: go.mod requires go >= 1.25.0 (running go 1.24.x; GOTOOLCHAIN=local)

Changes

Location	Before	After
`build_root.image_stream_tag.tag`	`rhel-9-release-golang-1.24-openshift-4.21`	`rhel-9-release-golang-1.25-openshift-4.22`
`dockerfile_literal` FROM	`...golang-1.24-openshift-4.21`	`...golang-1.25-openshift-4.22`

Summary by CodeRabbit

Updates the cluster-api-provider-kubevirt release-4.19 OpenShift CI build configuration to use the Go 1.25 toolchain image, enabling the planned golang.org/x/crypto v0.52.0 upgrade and related security fixes.

…ubevirt release-4.19 Update build_root and dockerfile_literal to use rhel-9-release-golang-1.25-openshift-4.22 (from golang-1.24-openshift-4.21). Required because CAPK release-4.19 will bump golang.org/x/crypto to v0.52.0 (fixing CVE-2026-39829), which requires Go 1.25.0. Co-authored-by: Cursor <cursoragent@cursor.com> Signed-off-by: nisimon <nisimon@redhat.com>

openshift-ci-robot · 2026-07-24T20:40:04Z

@nindsimonv: This pull request references ACM-36515 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the vulnerability to target either version "5.0." or "openshift-5.0.", but it targets "MCE 2.9.0" instead.

Details

In response to this:

Summary

Update build_root and dockerfile_literal Go toolchain from rhel-9-release-golang-1.24-openshift-4.21 to rhel-9-release-golang-1.25-openshift-4.22 for cluster-api-provider-kubevirt release-4.19 CI config.

Required because CAPK release-4.19 will bump golang.org/x/crypto to v0.52.0 (fixing CVE-2026-39829 + related CVEs), which requires Go 1.25.0.

Jira: ACM-36515 (MCE 2.9 / OCP 4.19)

Why

Without this change, CI jobs for the CAPK release-4.19 crypto bump would fail with:
go: go.mod requires go >= 1.25.0 (running go 1.24.x; GOTOOLCHAIN=local)

Changes

Location Before After

build_root.image_stream_tag.tag rhel-9-release-golang-1.24-openshift-4.21 rhel-9-release-golang-1.25-openshift-4.22

dockerfile_literal FROM ...golang-1.24-openshift-4.21 ...golang-1.25-openshift-4.22

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

coderabbitai · 2026-07-24T20:40:33Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: 11e9fd63-fdd6-4bd3-a335-6485edfb6836

📥 Commits

Reviewing files that changed from the base of the PR and between a912569 and 6b88d53.

📒 Files selected for processing (1)

ci-operator/config/openshift/cluster-api-provider-kubevirt/openshift-cluster-api-provider-kubevirt-release-4.19.yaml

Walkthrough

The OpenShift CI release configuration updates the toolchain stage to use the Go 1.25 and OpenShift 4.22 release image instead of the Go 1.24 and OpenShift 4.21 image.

Changes

Toolchain image update

Layer / File(s)	Summary
Update toolchain base image `ci-operator/config/openshift/cluster-api-provider-kubevirt/openshift-cluster-api-provider-kubevirt-release-4.19.yaml`	The generated Dockerfile’s `toolchain` stage now references the `rhel-9-release-golang-1.25-openshift-4.22` image.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

openshift/release#82390: Updates the same cluster-api-provider-kubevirt toolchain image reference.

Suggested reviewers: redhat-chai-bot

🚥 Pre-merge checks | ✅ 15

✅ Passed checks (15 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes the main change: bumping the release-4.19 CI build images to Go 1.25 for cluster-api-provider-kubevirt.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	Only a CI YAML image tag changed; no Ginkgo test titles or test files were modified.
Test Structure And Quality	✅ Passed	Only a ci-operator YAML changed; no Ginkgo test files or test code were modified.
Microshift Test Compatibility	✅ Passed	PR only updates CI build/toolchain config and a shell step script; no new Ginkgo tests or MicroShift-sensitive APIs were added.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	No new Ginkgo tests were added; the PR only updates CI image/toolchain refs in a YAML config, so SNO test compatibility is not applicable.
Topology-Aware Scheduling Compatibility	✅ Passed	Only the CI build image Go toolchain was updated; no deployment manifests, replicas, affinities, node selectors, or PDBs were changed.
Ote Binary Stdout Contract	✅ Passed	PR only changes a ci-operator YAML to switch Go toolchain images; no main/init/TestMain/suite setup code or stdout writes were added.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	Only CI build-root/dockerfile base image tags changed; no new Ginkgo tests or IPv4/external connectivity code was added.
No-Weak-Crypto	✅ Passed	PR only updates CI YAML to Go 1.25 image tags; no weak-crypto, custom crypto, or secret comparison code was added.
Container-Privileges	✅ Passed	The changed CI config only updates Go toolchain images; no privileged:true, hostPID/network/IPC, SYS_ADMIN, or allowPrivilegeEscalation settings appear, and it runs as nonroot USER 65532.
No-Sensitive-Data-In-Logs	✅ Passed	Diff only updates Go toolchain image tags in CI config; no logging statements or sensitive data literals are present.

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

openshift-ci · 2026-07-24T20:40:35Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: nindsimonv
Once this PR has been reviewed and has the lgtm label, please assign nirarg for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

ci-operator/config/openshift/cluster-api-provider-kubevirt/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-merge-bot · 2026-07-24T20:43:19Z

[REHEARSALNOTIFIER]
@nindsimonv: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name	Repo	Type	Reason
pull-ci-openshift-cluster-api-provider-kubevirt-release-4.19-e2e-hypershift-kubevirt	openshift/cluster-api-provider-kubevirt	presubmit	Ci-operator config changed
pull-ci-openshift-cluster-api-provider-kubevirt-release-4.19-images	openshift/cluster-api-provider-kubevirt	presubmit	Ci-operator config changed
pull-ci-openshift-cluster-api-provider-kubevirt-release-4.19-unit-tests	openshift/cluster-api-provider-kubevirt	presubmit	Ci-operator config changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

openshift-ci · 2026-07-24T21:11:48Z

@nindsimonv: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 24, 2026

openshift-ci Bot requested review from nunnatsa and orenc1 July 24, 2026 20:40

coderabbitai Bot mentioned this pull request Jul 24, 2026

ACM-36505: Bump CI build images to Go 1.25 for cluster-api-provider-kubevirt release-4.18 #82432

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

ACM-36515: Bump CI build images to Go 1.25 for cluster-api-provider-kubevirt release-4.19#82431

ACM-36515: Bump CI build images to Go 1.25 for cluster-api-provider-kubevirt release-4.19#82431
nindsimonv wants to merge 1 commit into
openshift:mainfrom
nindsimonv:ACM-36515-mce29-Target-branch-config-release419

nindsimonv commented Jul 24, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

openshift-ci-robot commented Jul 24, 2026 •

edited by atlassian Bot

Loading

Summary

Why

Changes

Uh oh!

coderabbitai Bot commented Jul 24, 2026 •

edited

Loading

Uh oh!

openshift-ci Bot commented Jul 24, 2026

Uh oh!

openshift-merge-bot Bot commented Jul 24, 2026

Uh oh!

openshift-ci Bot commented Jul 24, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

nindsimonv commented Jul 24, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Why

Changes

Summary by CodeRabbit

Uh oh!

openshift-ci-robot commented Jul 24, 2026 • edited by atlassian Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Why

Changes

Uh oh!

coderabbitai Bot commented Jul 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Uh oh!

openshift-ci Bot commented Jul 24, 2026

Uh oh!

openshift-merge-bot Bot commented Jul 24, 2026

Uh oh!

openshift-ci Bot commented Jul 24, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

nindsimonv commented Jul 24, 2026 •

edited by coderabbitai Bot

Loading

openshift-ci-robot commented Jul 24, 2026 •

edited by atlassian Bot

Loading

coderabbitai Bot commented Jul 24, 2026 •

edited

Loading