Skip to content

openshift/os: update release-4.22 okd-scos ci-operator config for build-args#82433

Open
aaradhak wants to merge 1 commit into
openshift:mainfrom
aaradhak:acs-ar-okd-scos
Open

openshift/os: update release-4.22 okd-scos ci-operator config for build-args#82433
aaradhak wants to merge 1 commit into
openshift:mainfrom
aaradhak:acs-ar-okd-scos

Conversation

@aaradhak

@aaradhak aaradhak commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

The release-4.22 Containerfile now uses IMAGE_FROM and STREAM_CLASS build args. Update the okd-scos variant to match — map stream-coreos-base as ${IMAGE_FROM} and pass STREAM_CLASS=centos-10, consistent with the RHEL variant and master configs.

Ref: f6f9339
PR CI Error - openshift/os#1946 (comment)

Summary by CodeRabbit

Updates the release-4.22 OKD SCOS ci-operator configuration (ci-operator/config/openshift/os/openshift-os-release-4.22__okd-scos.yaml) so the stream-coreos image builds accept the Containerfile build arguments. The config now wires stream image inputs through ${IMAGE_FROM} (instead of hardcoded registry image references) and sets STREAM_CLASS=centos-10 to match the RHEL variant behavior, for both the core and extension stream-coreos builds.

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 24, 2026
@coderabbitai

coderabbitai Bot commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: d6013b48-6cb2-4278-9117-3770f7d86ad2

📥 Commits

Reviewing files that changed from the base of the PR and between 220ee71 and 2adca67.

📒 Files selected for processing (1)
  • ci-operator/config/openshift/os/openshift-os-release-4.22__okd-scos.yaml
🚧 Files skipped from review as they are similar to previous changes (1)
  • ci-operator/config/openshift/os/openshift-os-release-4.22__okd-scos.yaml

Walkthrough

The release 4.22 OKD SCOS image builds add the centos-10 stream class and replace fixed image references with ${IMAGE_FROM}-backed inputs for core stream images.

Changes

OKD SCOS image builds

Layer / File(s) Summary
Update image build arguments and inputs
ci-operator/config/openshift/os/openshift-os-release-4.22__okd-scos.yaml
The core and extensions builds add STREAM_CLASS: centos-10 and use ${IMAGE_FROM} for the applicable stream-coreos inputs; the extensions build retains the UBI9 ocp_builder_stream source.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

Suggested labels: lgtm, ok-to-test

Suggested reviewers: jschintag, rolv-apneseth

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately reflects the ci-operator config update and the build-args changes in release-4.22 okd-scos.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed Only a ci-operator YAML file changed; no Ginkgo test titles or code-level test names were modified.
Test Structure And Quality ✅ Passed The PR only changes a ci-operator YAML config; no Ginkgo test code or test files are modified, so the check is not applicable.
Microshift Test Compatibility ✅ Passed Only a ci-operator YAML changed; no Ginkgo tests or OpenShift API usage were added, so MicroShift compatibility is not implicated.
Single Node Openshift (Sno) Test Compatibility ✅ Passed Only a ci-operator YAML changed; no Ginkgo e2e tests were added or modified, so SNO compatibility is not applicable.
Topology-Aware Scheduling Compatibility ✅ Passed Only ci-operator image build inputs/build args changed; no deployment manifests, operators, or scheduling constraints were introduced.
Ote Binary Stdout Contract ✅ Passed Only a ci-operator YAML config changed; no main/init/TestMain/suite setup code was touched, so stdout behavior of OTE binaries is unaffected.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed Only a ci-operator YAML config changed; no Ginkgo e2e tests or network logic were added or modified.
No-Weak-Crypto ✅ Passed Changed file only updates CI image inputs/build args; no weak crypto, custom crypto, or secret comparisons were added.
Container-Privileges ✅ Passed Only ci-operator image build args/inputs changed; no privileged, hostPID, hostNetwork, hostIPC, SYS_ADMIN, or allowPrivilegeEscalation fields appear in the diff.
No-Sensitive-Data-In-Logs ✅ Passed The only changed file is a ci-operator YAML; it adds build args and image mappings and contains no passwords, tokens, PII, hostnames, or log statements.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@aaradhak: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-os-release-4.22-okd-scos-e2e-aws-ovn openshift/os presubmit Ci-operator config changed
pull-ci-openshift-os-release-4.22-okd-scos-images openshift/os presubmit Ci-operator config changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

…ld-args

The release-4.22 Containerfile now uses IMAGE_FROM and STREAM_CLASS
build args. Update the okd-scos variant to match — map stream-coreos-base
as ${IMAGE_FROM} and pass STREAM_CLASS=centos-10, consistent with the
RHEL variant and master configs.

Ref: openshift@f6f9339
PR CI Error: openshift/os#1946 (comment)

@Rolv-Apneseth Rolv-Apneseth left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jul 24, 2026
@openshift-ci

openshift-ci Bot commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aaradhak, Rolv-Apneseth

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@aaradhak: pj-rehearse could not automatically process this event because the request waited in queue for longer than 5 minutes. Use /pj-rehearse to trigger rehearsals manually.

@openshift-ci

openshift-ci Bot commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

@aaradhak: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants