openshift/os: update release-4.22 okd-scos ci-operator config for build-args#82433
openshift/os: update release-4.22 okd-scos ci-operator config for build-args#82433aaradhak wants to merge 1 commit into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
WalkthroughThe release 4.22 OKD SCOS image builds add the ChangesOKD SCOS image builds
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
[REHEARSALNOTIFIER]
Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals. Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
…ld-args
The release-4.22 Containerfile now uses IMAGE_FROM and STREAM_CLASS
build args. Update the okd-scos variant to match — map stream-coreos-base
as ${IMAGE_FROM} and pass STREAM_CLASS=centos-10, consistent with the
RHEL variant and master configs.
Ref: openshift@f6f9339
PR CI Error: openshift/os#1946 (comment)
220ee71 to
2adca67
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aaradhak, Rolv-Apneseth The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@aaradhak: |
|
@aaradhak: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
The release-4.22 Containerfile now uses IMAGE_FROM and STREAM_CLASS build args. Update the okd-scos variant to match — map stream-coreos-base as ${IMAGE_FROM} and pass STREAM_CLASS=centos-10, consistent with the RHEL variant and master configs.
Ref: f6f9339
PR CI Error - openshift/os#1946 (comment)
Summary by CodeRabbit
Updates the
release-4.22OKD SCOSci-operatorconfiguration (ci-operator/config/openshift/os/openshift-os-release-4.22__okd-scos.yaml) so thestream-coreosimage builds accept the Containerfile build arguments. The config now wires stream image inputs through${IMAGE_FROM}(instead of hardcoded registry image references) and setsSTREAM_CLASS=centos-10to match the RHEL variant behavior, for both the core and extensionstream-coreosbuilds.