fix: update prod periodic to work with recent changes

[sclarkso]

What

Sync prod-e2e-parallel in __periodic.yaml with the branch job config: set VAULT_SECRET_PROFILE: prod (was prod-rh) and add ALLOWED_SUBSCRIPTIONS: ARO HCP E2E

Why

The periodic job acquires a slot from the MSFT test-tenant pool (aro-hcp-prod-testtenant-slot) but was looking for credentials in /var/run/aro-hcp-prod-rh (the RH tenant dir). The test-tenant credentials live in /var/run/aro-hcp-prod, so slot-manager failed immediately with "no customer subscription name file matched." This caused every 02:00 UTC prod periodic to fail in under 2 minutes since July 24. The branch prod-e2e-parallel was already correct after #82340; the periodic variant was not updated at the same time.

Summary by CodeRabbit

Updates the ARO HCP production parallel periodic CI job to use the prod Vault profile and load the ARO HCP E2E allowed subscription set. This aligns periodic execution with the branch job configuration and restores access to customer subscription credentials in the MSFT test-tenant directory.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sclarkso
Once this PR has been reviewed and has the lgtm label, please assign raelga for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• ci-operator/config/Azure/ARO-HCP/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: 23c1b9ba-581f-40ad-ad93-87e789a16062

📥 Commits

Reviewing files that changed from the base of the PR and between cd8104a and b7a2d49.

📒 Files selected for processing (1)

• ci-operator/config/Azure/ARO-HCP/Azure-ARO-HCP-main__periodic.yaml

---

Walkthrough

The prod-e2e-parallel periodic job adds an allowed subscription environment variable and changes its Vault secret profile from prod-rh to prod.

Changes

ARO HCP periodic job

Layer / File(s)	Summary
Update periodic job environment ci-operator/config/Azure/ARO-HCP/Azure-ARO-HCP-main__periodic.yaml	Adds ALLOWED_SUBSCRIPTIONS: ARO HCP E2E and changes VAULT_SECRET_PROFILE to prod for the prod-e2e-parallel job.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Suggested reviewers: roivaz

🚥 Pre-merge checks | ✅ 14 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name	Status	Explanation	Resolution
Title check	❓ Inconclusive	The title is related to the periodic job update, but it is vague and does not describe the specific env changes made.	Use a more specific title, e.g. mention the prod periodic job env update or the VAULT_SECRET_PROFILE and ALLOWED_SUBSCRIPTIONS changes.

✅ Passed checks (14 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	PASS: The PR only changes a ci-operator YAML job config; no Ginkgo It/Describe/Context/When titles were added or edited.
Test Structure And Quality	✅ Passed	PR only changes a ci-operator YAML job config; no Ginkgo test code was added or modified, so the test-quality check is not applicable.
Microshift Test Compatibility	✅ Passed	No new Ginkgo tests were added; the PR only changes ci-operator env vars in a periodic YAML, so MicroShift test compatibility review is not applicable.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	The PR only updates ci-operator job env in YAML; no new or changed Ginkgo tests were added to assess for SNO assumptions.
Topology-Aware Scheduling Compatibility	✅ Passed	Only a ci-operator periodic YAML env tweak changed; no manifests/controllers/scheduling logic were modified.
Ote Binary Stdout Contract	✅ Passed	PASS: The PR only changes ci-operator YAML env vars; no process-level code, init/main/suite setup, or stdout writes were added.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	Only a ci-operator YAML env update changed; no Ginkgo e2e test definitions or network code were added.
No-Weak-Crypto	✅ Passed	The patch only changes CI env vars in a YAML job config; no weak-crypto algorithms, custom crypto, or secret-comparison code is present.
Container-Privileges	✅ Passed	The only change is env var updates in a ci-operator config; no privileged/root/host* or allowPrivilegeEscalation settings are present or modified.
No-Sensitive-Data-In-Logs	✅ Passed	PASS: The only change is a YAML env var update in prod-e2e-parallel; no new log/print/logger calls or secret/PII exposure appear in the modified stanza.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[openshift-merge-bot]

[REHEARSALNOTIFIER]
@sclarkso: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name	Repo	Type	Reason
periodic-ci-Azure-ARO-HCP-main-periodic-prod-e2e-parallel	N/A	periodic	Ci-operator config changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

[sclarkso]

/pj-rehearse periodic-ci-Azure-ARO-HCP-main-periodic-prod-e2e-parallel

[openshift-merge-bot]

@sclarkso: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[openshift-ci]

@sclarkso: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.