Skip to content

feat: run CAPA smoke test suite - #82477

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
andclt:fix/capa-e2e-run-smoke
Jul 29, 2026
Merged

feat: run CAPA smoke test suite#82477
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
andclt:fix/capa-e2e-run-smoke

Conversation

@andclt

@andclt andclt commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Run the full ROSA HCP smoke test lifecycle in CI instead of just listing available tests

Summary by CodeRabbit

  • Updates the OpenShift Online ROSA HCP capa-e2e CI job configuration to run the smoke E2E subset by setting TEST_SUITE: --tag smoke in the job’s env (so the job executes tests via run-test-suite.py using that selector).
  • Enhances ci-operator/step-registry/rosa/e2e/capa/rosa-e2e-capa-commands.sh to read AWS credentials from the mounted awsEncodedCredentials/awsAccountId files and export them as AWS_ACCESS_KEY_ID, AWS_SECRET_ACCESS_KEY, and AWS_ACCOUNT_ID (replacing the prior AWS_B64ENCODED_CREDENTIALS export).
  • Adds an inline Helm bootstrap to the same runner: installs Helm v3.17.3 (download + SHA256 verification) into /tmp/bin and prepends it to PATH when helm is not already available, then reports helm version --short.

@coderabbitai

coderabbitai Bot commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

  • ▶️ Resume reviews
  • 🔍 Trigger review

Walkthrough

The ROSA E2E capa-e2e job now selects smoke-tagged tests, exports mounted AWS credentials and account information, and bootstraps a pinned Helm release with checksum verification when Helm is unavailable.

Changes

ROSA E2E capa workflow

Layer / File(s) Summary
Configure smoke test selection
ci-operator/config/openshift-online/rosa-e2e/openshift-online-rosa-e2e-main_capa-e2e.yaml
The job sets TEST_SUITE to --tag smoke.
Prepare AWS credentials and Helm runtime
ci-operator/step-registry/rosa/e2e/capa/rosa-e2e-capa-commands.sh
The script parses and exports AWS credentials and account information, then installs pinned Helm with SHA256 verification when necessary.

Estimated code review effort: 2 (Simple) | ~10 minutes

Suggested labels: rehearsals-ack

Suggested reviewers: ravitri, tiwillia, vr4manta

🚥 Pre-merge checks | ✅ 14 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Ipv6 And Disconnected Network Test Compatibility ⚠️ Warning The step script now downloads Helm from get.helm.sh, adding a public-internet dependency that can fail in disconnected CI. Use a preinstalled Helm or fetch it from an internal mirror/baked image instead of curling a public URL; no new Ginkgo test code was added.
✅ Passed checks (14 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately reflects the main change: switching the CAPA E2E job to run the smoke test suite.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed No Ginkgo test titles were added or changed; the PR only updates CI env and shell credential/Helm setup, so the stability check is not implicated.
Test Structure And Quality ✅ Passed The PR only changes CI config and a shell bootstrap script; no Ginkgo test code, assertions, or cluster waits were modified.
Microshift Test Compatibility ✅ Passed No Ginkgo test definitions were added; the PR only changes CI config and a shell runner, so MicroShift test compatibility is not applicable.
Single Node Openshift (Sno) Test Compatibility ✅ Passed No new Ginkgo e2e tests were added; the diff only changes CI config and a shell wrapper, so the SNO compatibility check is not applicable.
Topology-Aware Scheduling Compatibility ✅ Passed Only CI test config and a shell bootstrap changed; no manifests, controllers, node selectors, affinity, or PDBs were added.
Ote Binary Stdout Contract ✅ Passed PASS: The PR only changes CI YAML and a shell wrapper; no OTE binary/main/test suite code was modified, so the stdout-on-JSON contract isn’t implicated.
No-Weak-Crypto ✅ Passed No weak crypto found; the new helm bootstrap uses SHA-256 checksum verification only, with no MD5/SHA1/DES/RC4 or secret comparisons.
Container-Privileges ✅ Passed Touched files only change TEST_SUITE and credential/helm bootstrapping; no privileged, hostPID/Network/IPC, SYS_ADMIN, or allowPrivilegeEscalation fields appear.
No-Sensitive-Data-In-Logs ✅ Passed Secrets are loaded with tracing disabled, and the added logs only print repo/branch, helm version, and test progress—no passwords, tokens, or keys are echoed.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@openshift-ci
openshift-ci Bot requested review from ravitri and tiwillia July 27, 2026 12:15
@andclt

andclt commented Jul 27, 2026

Copy link
Copy Markdown
Contributor Author

/pj-rehearse periodic-ci-openshift-online-rosa-e2e-main_capa-e2e-capa-e2e

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@andclt: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@andclt
andclt force-pushed the fix/capa-e2e-run-smoke branch from 41d282f to 35ca52e Compare July 27, 2026 14:00
@andclt

andclt commented Jul 27, 2026

Copy link
Copy Markdown
Contributor Author

/pj-rehearse periodic-ci-openshift-online-rosa-e2e-main_capa-e2e-capa-e2e

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@andclt: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@andclt
andclt force-pushed the fix/capa-e2e-run-smoke branch from 35ca52e to af31e9b Compare July 27, 2026 14:52

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@ci-operator/step-registry/rosa/e2e/capa/rosa-e2e-capa-commands.sh`:
- Around line 50-51: Update both curl downloads in the Helm setup flow to use
bounded connection and total timeouts, and add limited retries for transient
failures. Apply the same timeout and retry options to the archive and its
checksum downloads while preserving their existing URLs and output paths.
- Around line 50-55: Update the Helm download verification in the rosa e2e setup
so the downloaded checksum file is not the sole trust anchor. Pin the expected
archive SHA-256 in repository-controlled configuration or verify Helm’s official
detached GPG signature, then validate the downloaded archive against that
trusted value before continuing.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: ecb1c5b1-c534-422e-bd0b-4dbf7b4fba1c

📥 Commits

Reviewing files that changed from the base of the PR and between 35ca52e and af31e9b.

📒 Files selected for processing (2)
  • ci-operator/config/openshift-online/rosa-e2e/openshift-online-rosa-e2e-main_capa-e2e.yaml
  • ci-operator/step-registry/rosa/e2e/capa/rosa-e2e-capa-commands.sh
🚧 Files skipped from review as they are similar to previous changes (1)
  • ci-operator/config/openshift-online/rosa-e2e/openshift-online-rosa-e2e-main_capa-e2e.yaml

Comment thread ci-operator/step-registry/rosa/e2e/capa/rosa-e2e-capa-commands.sh Outdated
Comment thread ci-operator/step-registry/rosa/e2e/capa/rosa-e2e-capa-commands.sh Outdated
@andclt
andclt force-pushed the fix/capa-e2e-run-smoke branch from af31e9b to 87558a8 Compare July 27, 2026 15:09
@andclt

andclt commented Jul 27, 2026

Copy link
Copy Markdown
Contributor Author

/pj-rehearse periodic-ci-openshift-online-rosa-e2e-main_capa-e2e-capa-e2e

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@andclt: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@andclt
andclt force-pushed the fix/capa-e2e-run-smoke branch 2 times, most recently from 3f90fca to caf4b7f Compare July 27, 2026 17:01
@andclt

andclt commented Jul 27, 2026

Copy link
Copy Markdown
Contributor Author

/pj-rehearse periodic-ci-openshift-online-rosa-e2e-main_capa-e2e-capa-e2e

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@andclt: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@andclt
andclt force-pushed the fix/capa-e2e-run-smoke branch from caf4b7f to 7a87a61 Compare July 27, 2026 22:51
@andclt

andclt commented Jul 27, 2026

Copy link
Copy Markdown
Contributor Author

/pj-rehearse periodic-ci-openshift-online-rosa-e2e-main_capa-e2e-capa-e2e

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@andclt: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@andclt
andclt force-pushed the fix/capa-e2e-run-smoke branch from 7a87a61 to ee3d8e2 Compare July 28, 2026 09:10
@andclt

andclt commented Jul 28, 2026

Copy link
Copy Markdown
Contributor Author

/pj-rehearse periodic-ci-openshift-online-rosa-e2e-main_capa-e2e-capa-e2e

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@andclt: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@andclt
andclt force-pushed the fix/capa-e2e-run-smoke branch from ee3d8e2 to 71c7a70 Compare July 28, 2026 11:48
@andclt

andclt commented Jul 28, 2026

Copy link
Copy Markdown
Contributor Author

/pj-rehearse periodic-ci-openshift-online-rosa-e2e-main_capa-e2e-capa-e2e

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@andclt: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@andclt

andclt commented Jul 28, 2026

Copy link
Copy Markdown
Contributor Author

/pj-rehearse periodic-ci-openshift-online-rosa-e2e-main_capa-e2e-capa-e2e

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@andclt: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@andclt

andclt commented Jul 28, 2026

Copy link
Copy Markdown
Contributor Author

/pj-rehearse periodic-ci-openshift-online-rosa-e2e-main_capa-e2e-capa-e2e

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@andclt: your /pj-rehearse request was not processed because the request waited in queue for longer than 5 minutes. Please retry in a few minutes.

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@andclt: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@andclt

andclt commented Jul 28, 2026

Copy link
Copy Markdown
Contributor Author

/pj-rehearse periodic-ci-openshift-online-rosa-e2e-main_capa-e2e-capa-e2e

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@andclt: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@andclt

andclt commented Jul 28, 2026

Copy link
Copy Markdown
Contributor Author

/pj-rehearse periodic-ci-openshift-online-rosa-e2e-main_capa-e2e-capa-e2e

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@andclt: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@andclt
andclt force-pushed the fix/capa-e2e-run-smoke branch from 71c7a70 to 712d7be Compare July 29, 2026 07:07
@andclt

andclt commented Jul 29, 2026

Copy link
Copy Markdown
Contributor Author

/pj-rehearse periodic-ci-openshift-online-rosa-e2e-main_capa-e2e-capa-e2e

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@andclt: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@andclt
andclt force-pushed the fix/capa-e2e-run-smoke branch from 712d7be to c5cfb22 Compare July 29, 2026 10:34
@andclt

andclt commented Jul 29, 2026

Copy link
Copy Markdown
Contributor Author

/pj-rehearse periodic-ci-openshift-online-rosa-e2e-main_capa-e2e-capa-e2e

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@andclt: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@andclt
andclt force-pushed the fix/capa-e2e-run-smoke branch from c5cfb22 to 577545e Compare July 29, 2026 13:26
@andclt

andclt commented Jul 29, 2026

Copy link
Copy Markdown
Contributor Author

/pj-rehearse periodic-ci-openshift-online-rosa-e2e-main_capa-e2e-capa-e2e

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@andclt: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@andclt: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
periodic-ci-openshift-online-rosa-e2e-main_capa-e2e-capa-e2e N/A periodic Ci-operator config changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci

openshift-ci Bot commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

@andclt: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@dustman9000

Copy link
Copy Markdown
Member

/lgtm
/approve
/pj-rehearse ack

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@dustman9000: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-merge-bot openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jul 29, 2026
@lucasponce

Copy link
Copy Markdown

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jul 29, 2026
@openshift-ci

openshift-ci Bot commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andclt, dustman9000, lucasponce

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 29, 2026
@openshift-merge-bot
openshift-merge-bot Bot merged commit 42c9e02 into openshift:main Jul 29, 2026
17 checks passed
@andclt
andclt deleted the fix/capa-e2e-run-smoke branch July 29, 2026 16:30
amogh-redhat pushed a commit to amogh-redhat/release that referenced this pull request Aug 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants