Skip to content

openshift-logging: Use CI-built images of api and opa-openshift for 5.y - #82571

Open
xperimental wants to merge 1 commit into
openshift:mainfrom
xperimental:log-storage-apis-lo
Open

openshift-logging: Use CI-built images of api and opa-openshift for 5.y#82571
xperimental wants to merge 1 commit into
openshift:mainfrom
xperimental:log-storage-apis-lo

Conversation

@xperimental

@xperimental xperimental commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

/cc @cahartma
/assign @xperimental

Summary by CodeRabbit

  • Updates OpenShift Loki CI configuration on the 5.y branch to reference CI-built loki-stack-gateway and opa-openshift images using the 5.y image stream tags.
  • Applies the image reference corrections to the 5.8 and 5.9 release configurations.

@xperimental
xperimental force-pushed the log-storage-apis-lo branch from c1368fc to 6917345 Compare July 28, 2026 17:03
@coderabbitai

coderabbitai Bot commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

Walkthrough

Corrected base_images mappings in the Loki 5.8 and 5.9 release configurations to use explicit component image names with the 5.y tag.

Changes

Loki release image mappings

Layer / File(s) Summary
Correct base image references
ci-operator/config/openshift/loki/openshift-loki-release-5.8.yaml, ci-operator/config/openshift/loki/openshift-loki-release-5.9.yaml
Updated Loki gateway and OPA image mappings to use component names and the 5.y tag.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Suggested reviewers: cahartma

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title matches the main goal of switching openshift-logging 5.y config to CI-built images, including opa-openshift.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed Only ci-operator YAML changed; no It/Describe/Context/When test titles were added or modified.
Test Structure And Quality ✅ Passed PR only changes two ci-operator YAML configs; no Ginkgo or test files were modified, so the test-quality check is not applicable.
Microshift Test Compatibility ✅ Passed Only ci-operator YAML image refs changed; no new Ginkgo e2e tests were added, so MicroShift compatibility is not implicated.
Single Node Openshift (Sno) Test Compatibility ✅ Passed Only ci-operator YAML base image refs changed; no Ginkgo e2e tests were added or modified, so SNO compatibility check is not applicable.
Topology-Aware Scheduling Compatibility ✅ Passed Only ci-operator base_images names/tags changed; no manifests, controllers, or scheduling constraints were added.
Ote Binary Stdout Contract ✅ Passed PR only edits two ci-operator YAML configs; no Go/test binary code or process-level stdout paths changed, so the stdout contract is unaffected.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed Only ci-operator YAML base_image refs changed; no new Ginkgo/e2e tests or networking logic was added, so this check is not applicable.
No-Weak-Crypto ✅ Passed Touched files are CI YAML image config only; they contain no crypto algorithms, custom implementations, or secret comparisons.
Container-Privileges ✅ Passed The diff only renames CI base image refs; no privileged, hostPID/Network/IPC, SYS_ADMIN, or allowPrivilegeEscalation settings appear.
No-Sensitive-Data-In-Logs ✅ Passed Changed YAML only updates CI image references; no logging code or sensitive fields are introduced.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@openshift-ci

openshift-ci Bot commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xperimental

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 28, 2026

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@ci-operator/config/openshift/loki/openshift-loki-release-5.8.yaml`:
- Around line 11-21: In
ci-operator/config/openshift/loki/openshift-loki-release-5.8.yaml lines 11-21
and ci-operator/config/openshift/loki/openshift-loki-release-5.9.yaml lines
11-21, restore the mirroring contract by using mirror-5.y as the image name and
the corresponding component names as tags for the affected image entries, or
update all mirroring producers consistently if retaining the new references.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: 3dbb5cb0-d89e-4434-90f4-f17269a86bbd

📥 Commits

Reviewing files that changed from the base of the PR and between fcc0e20 and 6917345.

📒 Files selected for processing (2)
  • ci-operator/config/openshift/loki/openshift-loki-release-5.8.yaml
  • ci-operator/config/openshift/loki/openshift-loki-release-5.9.yaml

Comment on lines +11 to +21
name: lokistack-gateway
namespace: logging
tag: lokistack-gateway
tag: 5.y
ocp_builder_rhel-9-golang-1.22-builder-multi-openshift-4.17:
name: builder
namespace: ocp
tag: rhel-9-golang-1.22-builder-multi-openshift-4.17
opa-openshift:
name: mirror-5.y
name: opa-openshift
namespace: logging
tag: opa-openshift
tag: 5.y

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🗄️ Data Integrity & Integration | 🟠 Major | ⚡ Quick win

The new image references do not match the supplied mirroring contract.

  • ci-operator/config/openshift/loki/openshift-loki-release-5.8.yaml#L11-L21: restore mirror-5.y as the image name and use component names as tags, or update the mirroring producers together.
  • ci-operator/config/openshift/loki/openshift-loki-release-5.9.yaml#L11-L21: apply the same correction.
📍 Affects 2 files
  • ci-operator/config/openshift/loki/openshift-loki-release-5.8.yaml#L11-L21 (this comment)
  • ci-operator/config/openshift/loki/openshift-loki-release-5.9.yaml#L11-L21
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@ci-operator/config/openshift/loki/openshift-loki-release-5.8.yaml` around
lines 11 - 21, In
ci-operator/config/openshift/loki/openshift-loki-release-5.8.yaml lines 11-21
and ci-operator/config/openshift/loki/openshift-loki-release-5.9.yaml lines
11-21, restore the mirroring contract by using mirror-5.y as the image name and
the corresponding component names as tags for the affected image entries, or
update all mirroring producers consistently if retaining the new references.

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@xperimental: pj-rehearse could not automatically process this event because the request waited in queue for longer than 5 minutes. Use /pj-rehearse to trigger rehearsals manually.

1 similar comment
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@xperimental: pj-rehearse could not automatically process this event because the request waited in queue for longer than 5 minutes. Use /pj-rehearse to trigger rehearsals manually.

@xperimental

Copy link
Copy Markdown
Contributor Author

/pj-rehearse auto-ack

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@xperimental: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci

openshift-ci Bot commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

@xperimental: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jul 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant