openshift-logging: Use CI-built images of api and opa-openshift for 5.y - #82571
openshift-logging: Use CI-built images of api and opa-openshift for 5.y#82571xperimental wants to merge 1 commit into
Conversation
c1368fc to
6917345
Compare
WalkthroughCorrected ChangesLoki release image mappings
Estimated code review effort: 1 (Trivial) | ~2 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: xperimental The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@ci-operator/config/openshift/loki/openshift-loki-release-5.8.yaml`:
- Around line 11-21: In
ci-operator/config/openshift/loki/openshift-loki-release-5.8.yaml lines 11-21
and ci-operator/config/openshift/loki/openshift-loki-release-5.9.yaml lines
11-21, restore the mirroring contract by using mirror-5.y as the image name and
the corresponding component names as tags for the affected image entries, or
update all mirroring producers consistently if retaining the new references.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Pro Plus
Run ID: 3dbb5cb0-d89e-4434-90f4-f17269a86bbd
📒 Files selected for processing (2)
ci-operator/config/openshift/loki/openshift-loki-release-5.8.yamlci-operator/config/openshift/loki/openshift-loki-release-5.9.yaml
| name: lokistack-gateway | ||
| namespace: logging | ||
| tag: lokistack-gateway | ||
| tag: 5.y | ||
| ocp_builder_rhel-9-golang-1.22-builder-multi-openshift-4.17: | ||
| name: builder | ||
| namespace: ocp | ||
| tag: rhel-9-golang-1.22-builder-multi-openshift-4.17 | ||
| opa-openshift: | ||
| name: mirror-5.y | ||
| name: opa-openshift | ||
| namespace: logging | ||
| tag: opa-openshift | ||
| tag: 5.y |
There was a problem hiding this comment.
🗄️ Data Integrity & Integration | 🟠 Major | ⚡ Quick win
The new image references do not match the supplied mirroring contract.
ci-operator/config/openshift/loki/openshift-loki-release-5.8.yaml#L11-L21: restoremirror-5.yas the image name and use component names as tags, or update the mirroring producers together.ci-operator/config/openshift/loki/openshift-loki-release-5.9.yaml#L11-L21: apply the same correction.
📍 Affects 2 files
ci-operator/config/openshift/loki/openshift-loki-release-5.8.yaml#L11-L21(this comment)ci-operator/config/openshift/loki/openshift-loki-release-5.9.yaml#L11-L21
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@ci-operator/config/openshift/loki/openshift-loki-release-5.8.yaml` around
lines 11 - 21, In
ci-operator/config/openshift/loki/openshift-loki-release-5.8.yaml lines 11-21
and ci-operator/config/openshift/loki/openshift-loki-release-5.9.yaml lines
11-21, restore the mirroring contract by using mirror-5.y as the image name and
the corresponding component names as tags for the affected image entries, or
update all mirroring producers consistently if retaining the new references.
|
@xperimental: |
1 similar comment
|
@xperimental: |
|
/pj-rehearse auto-ack |
|
@xperimental: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
@xperimental: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
/cc @cahartma
/assign @xperimental
Summary by CodeRabbit
5.ybranch to reference CI-builtloki-stack-gatewayandopa-openshiftimages using the5.yimage stream tags.