CNTRLPLANE-3947: feat(oauth-apiserver): mount ci-pull-credentials and add oc to verify step - #82639
CNTRLPLANE-3947: feat(oauth-apiserver): mount ci-pull-credentials and add oc to verify step#82639jubittajohn wants to merge 1 commit into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Enterprise Run ID: ⛔ Files ignored due to path filters (3)
📒 Files selected for processing (5)
🚧 Files skipped from review as they are similar to previous changes (5)
WalkthroughOpenShift OAuth apiserver CI configurations now mount pull credentials. Release 4.23, 5.0, and 5.1 pipelines also build an image containing ChangesOAuth apiserver CI verification
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: jubittajohn The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/pj-rehearse pull-ci-openshift-oauth-apiserver-master-verify |
|
@jubittajohn: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse pull-ci-openshift-oauth-apiserver-release-5.0-verify |
|
@jubittajohn: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse pull-ci-openshift-oauth-apiserver-release-5.0-images |
|
@jubittajohn: your |
… step Signed-off-by: jubittajohn <jujohn@redhat.com>
bcbee54 to
916d5cd
Compare
openshift-ci-robot
added
the
jira/valid-reference
|
@jubittajohn: This pull request references CNTRLPLANE-3947 which is a valid jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[REHEARSALNOTIFIER]
A total of 32 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs. A full list of affected jobs can be found here Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
@jubittajohn: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
2 participants
Summary by CodeRabbit
Updates the OpenShift CI verification setup for
oauth-apiserverto be more reliable and consistent across master and supported release streams by:ci-pull-credentialsinto theverifyjobs (and settingREGISTRY_AUTH_FILE) so the verification step can authenticate when pulling required images/artifacts.oauth-apiserver-bin-with-ochelper image that bundles theocbinary into the verification environment, then switchingverifyto run from that image.openshift-org-gcpcluster profile, with explicit CPU/memory resource requests.verifywhen changes are limited to docs/metadata/ownership/license-related paths viaskip_if_only_changed.make verifywith failure-tolerant behavior where configured, such asmake verify -k, and including additional flags in the 5.0 stream).