Skip to content

STOR-3001: Add TLS scanner job for aws-efs - #82656

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
RomanBednar:feat/efs-tls-scanner
Jul 30, 2026
Merged

STOR-3001: Add TLS scanner job for aws-efs#82656
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
RomanBednar:feat/efs-tls-scanner

Conversation

@RomanBednar

@RomanBednar RomanBednar commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

Adds an optional, manually-triggered TLS scanner presubmit job (tls-scanner-aws-efs) to csi-operator for the AWS EFS CSI driver. Covers main, release-4.23, release-5.0, and release-5.1 branches.

The job reuses the existing openshift-e2e-aws-csi-efs workflow with the test phase overridden to run tls-13 and tls-scanner-run against the openshift-cluster-csi-drivers namespace.

Summary by CodeRabbit

Adds an optional, manually triggered TLS scanner presubmit job for the AWS EFS CSI driver to csi-operator CI on the main, release-4.23, release-5.0, and release-5.1 branches. The job reuses the existing AWS EFS workflow, installs the EFS CSI driver operator, and runs TLS 1.3 compliance and scanner tests with strict component coverage.

Adds an optional, manually-triggered TLS scanner presubmit job
(tls-scanner-aws-efs) to csi-operator for the AWS EFS CSI driver.
Covers main, release-4.23, release-5.0, and release-5.1 branches.

The job reuses the existing openshift-e2e-aws-csi-efs workflow
with the test phase overridden to run tls-13 and tls-scanner-run
against the openshift-cluster-csi-drivers namespace.
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 30, 2026
@openshift-ci-robot

openshift-ci-robot commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

@RomanBednar: This pull request references STOR-3001 which is a valid jira issue.

Details

In response to this:

Adds an optional, manually-triggered TLS scanner presubmit job (tls-scanner-aws-efs) to csi-operator for the AWS EFS CSI driver. Covers main, release-4.23, release-5.0, and release-5.1 branches.

The job reuses the existing openshift-e2e-aws-csi-efs workflow with the test phase overridden to run tls-13 and tls-scanner-run against the openshift-cluster-csi-drivers namespace.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@coderabbitai

coderabbitai Bot commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: c18d2e62-3222-4ab0-8dca-440f4509a7ce

📥 Commits

Reviewing files that changed from the base of the PR and between 43b6aab and 3cf32d3.

⛔ Files ignored due to path filters (4)
  • ci-operator/jobs/openshift/csi-operator/openshift-csi-operator-main-presubmits.yaml is excluded by !ci-operator/jobs/**
  • ci-operator/jobs/openshift/csi-operator/openshift-csi-operator-release-4.23-presubmits.yaml is excluded by !ci-operator/jobs/**
  • ci-operator/jobs/openshift/csi-operator/openshift-csi-operator-release-5.0-presubmits.yaml is excluded by !ci-operator/jobs/**
  • ci-operator/jobs/openshift/csi-operator/openshift-csi-operator-release-5.1-presubmits.yaml is excluded by !ci-operator/jobs/**
📒 Files selected for processing (4)
  • ci-operator/config/openshift/csi-operator/openshift-csi-operator-main.yaml
  • ci-operator/config/openshift/csi-operator/openshift-csi-operator-release-4.23.yaml
  • ci-operator/config/openshift/csi-operator/openshift-csi-operator-release-5.0.yaml
  • ci-operator/config/openshift/csi-operator/openshift-csi-operator-release-5.1.yaml

Walkthrough

Adds an optional tls-scanner-aws-efs CI test to four CSI operator configurations. The test installs the AWS EFS CSI driver operator, enables strict TLS 1.3 adherence, applies availability conditions, and runs tls-13 and tls-scanner-run through the AWS EFS workflow.

Changes

AWS EFS TLS scanner

Layer / File(s) Summary
Add AWS EFS TLS scanner configuration
ci-operator/config/openshift/csi-operator/openshift-csi-operator-main.yaml, ci-operator/config/openshift/csi-operator/openshift-csi-operator-release-4.23.yaml, ci-operator/config/openshift/csi-operator/openshift-csi-operator-release-5.0.yaml, ci-operator/config/openshift/csi-operator/openshift-csi-operator-release-5.1.yaml
Each configuration adds an optional tls-scanner-aws-efs test with AWS EFS operator installation settings, strict TLS 1.3 adherence, scanner test refs, and the openshift-e2e-aws-csi-efs workflow.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

Suggested reviewers: stuggi

Sequence Diagram(s)

sequenceDiagram
  participant CI as CI test job
  participant Operator as AWS EFS CSI driver operator
  participant Scanner as TLS scanner
  CI->>Operator: Install AWS EFS CSI driver operator
  CI->>Scanner: Run tls-13 and tls-scanner-run
  Scanner->>Operator: Validate strict TLS 1.3 adherence
Loading
🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly matches the main change: adding a TLS scanner job for AWS EFS.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed The PR only adds static ci-operator job config; no Ginkgo It/Describe/Context titles were changed, and the new job name is deterministic.
Test Structure And Quality ✅ Passed PR only adds CI YAML job/config entries; no Ginkgo test code was changed, so the test-structure check is not applicable.
Microshift Test Compatibility ✅ Passed PASS: The PR only adds CI/job YAML; no Ginkgo test definitions or MicroShift-sensitive API references were introduced.
Single Node Openshift (Sno) Test Compatibility ✅ Passed No new Ginkgo test code was added; this PR only wires existing tls-13/tls-scanner-run refs into the AWS EFS workflow, with no SNO-assumption logic.
Topology-Aware Scheduling Compatibility ✅ Passed Only CI test entries were added; no deployment manifests, replicas, affinities, nodeSelectors, or topology-aware scheduling constraints changed.
Ote Binary Stdout Contract ✅ Passed PASS: The PR only changes CI YAML/job definitions; no OTE binary or process-level code (main/TestMain/init/suite setup) was modified, so no stdout contract risk.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed Only CI job wiring was added; no new Ginkgo test code, hardcoded IPs, or external URLs appear in the new entry.
No-Weak-Crypto ✅ Passed Changed YAML only adds TLS scanner CI jobs; no MD5/SHA1/DES/RC4/3DES/Blowfish/ECB, custom crypto, or secret comparisons found.
Container-Privileges ✅ Passed The added tls-scanner-aws-efs stanzas contain no privileged:true, hostPID/Network/IPC, SYS_ADMIN, or allowPrivilegeEscalation:true settings.
No-Sensitive-Data-In-Logs ✅ Passed New CI YAML blocks contain no passwords, tokens, PII, internal hostnames, or customer data.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@RomanBednar

Copy link
Copy Markdown
Contributor Author

/assign @dfajmon

For review.

@openshift-ci
openshift-ci Bot requested review from mandre and tsmetana July 30, 2026 08:19
@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 30, 2026
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@RomanBednar: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-csi-operator-main-tls-scanner-aws-efs openshift/csi-operator presubmit Presubmit changed
pull-ci-openshift-csi-operator-release-4.23-tls-scanner-aws-efs openshift/csi-operator presubmit Presubmit changed
pull-ci-openshift-csi-operator-release-5.0-tls-scanner-aws-efs openshift/csi-operator presubmit Presubmit changed
pull-ci-openshift-csi-operator-release-5.1-tls-scanner-aws-efs openshift/csi-operator presubmit Presubmit changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci

openshift-ci Bot commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

@RomanBednar: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@dfajmon

dfajmon commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jul 30, 2026
@openshift-ci

openshift-ci Bot commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dfajmon, RomanBednar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@RomanBednar

Copy link
Copy Markdown
Contributor Author

/pj-rehearse ack

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@RomanBednar: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-merge-bot openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jul 30, 2026
@openshift-merge-bot
openshift-merge-bot Bot merged commit b5f6060 into openshift:main Jul 30, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants