Add optional vSphere MCO bootimage presubmits for machine-config-oper…

[jcpowermac]

…ator main

Adds three optional/on-demand presubmit jobs (plain IPI, zonal single-vCenter, multi-vCenter) scoped to the MCO Bootimages longduration spec group, so the new vSphere multi-vCenter/multi-failure-domain reconciliation e2e specs in openshift/machine-config-operator#6354 can be exercised via /test before they land in a periodic. Reuses the existing openshift-e2e-vsphere and openshift-e2e-vsphere-zones workflows, differentiated only by MAX_VCENTERS per SPLAT-2238 (#81215), instead of a separate hardcoded-pool multi-vcenter workflow.

Summary by CodeRabbit

This PR adds three optional, on-demand vSphere Bootimages presubmit jobs for the Machine Config Operator repository:

• Plain IPI testing.
• Zonal single-vCenter testing with MAX_VCENTERS=1.
• Multi-vCenter testing with MAX_VCENTERS=3.

The jobs run the MCO.Bootimages long-duration suite with the TechPreview feature set and RHEL 9 images. They reuse the existing vSphere workflows and allow contributors to trigger these tests with /test.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 48aa11b8-c686-43ce-8281-7e46c23a1e62

📥 Commits

Reviewing files that changed from the base of the PR and between 0be868a and 81e75dc.

⛔ Files ignored due to path filters (1)

• ci-operator/jobs/openshift/machine-config-operator/openshift-machine-config-operator-main-presubmits.yaml is excluded by !ci-operator/jobs/**

📒 Files selected for processing (1)

• ci-operator/config/openshift/machine-config-operator/openshift-machine-config-operator-main.yaml

🚧 Files skipped from review as they are similar to previous changes (1)

• ci-operator/config/openshift/machine-config-operator/openshift-machine-config-operator-main.yaml

---

Walkthrough

The configuration adds three optional vSphere end-to-end jobs for MCO bootimages tests: standard vSphere, zoned vSphere with one vCenter, and zoned vSphere with three vCenters.

Changes

MCO bootimages test coverage

Layer / File(s)	Summary
Configure vSphere bootimages jobs ci-operator/config/openshift/machine-config-operator/openshift-machine-config-operator-main.yaml	Adds optional standard, one-vCenter zoned, and three-vCenter zoned jobs. Each uses TechPreview, RHEL 9, and the MCO bootimages suite. The zoned jobs set MAX_VCENTERS to 1 and 3.

Estimated code review effort: 2 (Simple) | ~10 minutes

Suggested reviewers: dkhater-redhat, harshwardhanpatil07

🚥 Pre-merge checks | ✅ 15

✅ Passed checks (15 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly summarizes the main change: adding optional vSphere MCO bootimage presubmit jobs.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	The commit changes only CI YAML and generated Prow jobs; it adds no Ginkgo title declarations, and all added job and selector names are static.
Test Structure And Quality	✅ Passed	The PR changes only YAML CI configuration and generated Prow jobs; it adds no Ginkgo It blocks or test implementation, so this check is not applicable.
Microshift Test Compatibility	✅ Passed	The pull request changes only two CI YAML files; it adds no Go test files or Ginkgo declarations, so the MicroShift test compatibility check is not applicable.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	The PR changes only two YAML configuration files and adds no Ginkgo test declarations; it selects the existing MCO.Bootimages suite, so SNO compatibility review is not applicable.
Topology-Aware Scheduling Compatibility	✅ Passed	The diff only adds CI operator test entries and generated Prow jobs; it adds no deployment, operator, controller, or topology-dependent scheduling constraint.
Ote Binary Stdout Contract	✅ Passed	The PR changes only CI YAML and generated presubmit definitions; it adds no OTE binary or process-level code that can write non-JSON stdout.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	The PR changes only CI YAML and generated presubmit definitions. It adds no Ginkgo test declarations or test code, so this check is not applicable.
No-Weak-Crypto	✅ Passed	The PR adds only vSphere test YAML; exact scans of all added and changed lines found no MD5, SHA1, DES, 3DES, RC4, Blowfish, ECB, or custom crypto usage.
Container-Privileges	✅ Passed	The three added jobs and generated Pod specs set no privileged, hostPID, hostNetwork, hostIPC, SYS_ADMIN, allowPrivilegeEscalation, or root security fields.
No-Sensitive-Data-In-Logs	✅ Passed	The diff adds no logging commands, PII, literal credentials, or token values; it only uses non-sensitive test settings and standard mounted CI secret references.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands.}

[jcpowermac]

/pj-rehearse pull-ci-openshift-machine-config-operator-main-e2e-vsphere-multi-vcenter-mco-bootimages

[openshift-merge-bot]

@jcpowermac: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[vr4manta]

/lgtm

[jcpowermac]

/pj-rehearse pull-ci-openshift-machine-config-operator-main-e2e-vsphere-multi-vcenter-mco-bootimages

[openshift-merge-bot]

@jcpowermac: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[djoshy]

/lgtm

[jcpowermac]

/pj-rehearse pull-ci-openshift-machine-config-operator-main-e2e-vsphere-multi-vcenter-mco-bootimages

[openshift-merge-bot]

@jcpowermac: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[openshift-merge-bot]

[REHEARSALNOTIFIER]
@jcpowermac: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name	Repo	Type	Reason
pull-ci-openshift-machine-config-operator-main-e2e-vsphere-mco-bootimages	openshift/machine-config-operator	presubmit	Presubmit changed
pull-ci-openshift-machine-config-operator-main-e2e-vsphere-multi-vcenter-mco-bootimages	openshift/machine-config-operator	presubmit	Presubmit changed
pull-ci-openshift-machine-config-operator-main-e2e-vsphere-zones-mco-bootimages	openshift/machine-config-operator	presubmit	Presubmit changed

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

[openshift-merge-bot]

@jcpowermac: pj-rehearse could not automatically process this event because the request waited in queue for longer than 5 minutes. Use /pj-rehearse to trigger rehearsals manually.

[jcpowermac]

@djoshy this is ready to go. Once this is merged I can follow up with the changes in mco repo.

[jcpowermac]

/pj-rehearse ack

[openshift-merge-bot]

@jcpowermac: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[djoshy]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: djoshy, jcpowermac, vr4manta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• ci-operator/config/openshift/machine-config-operator/OWNERS [djoshy]
• ci-operator/jobs/openshift/machine-config-operator/OWNERS [djoshy]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment