Skip to content

ROSAENG-62156 fix: add openshift version and channel group support for CAPA e2e - #82728

Open
andclt wants to merge 1 commit into
openshift:mainfrom
andclt:fix/capa-staging-openshift-version
Open

ROSAENG-62156 fix: add openshift version and channel group support for CAPA e2e#82728
andclt wants to merge 1 commit into
openshift:mainfrom
andclt:fix/capa-staging-openshift-version

Conversation

@andclt

@andclt andclt commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

Summary

Staging OCM currently has no stable HCP versions enabled, only nightly builds. This change allows the CAPA e2e periodic job to target nightly versions in staging.

Summary by CodeRabbit

The CAPA e2e periodic job now targets OpenShift 4.22.0 from the nightly channel in staging.

The rosa-e2e-capa step accepts OPENSHIFT_VERSION and CHANNEL_GROUP and passes them to the Ansible test suite as extra variables. Empty values preserve existing repository defaults.

@coderabbitai

coderabbitai Bot commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: 9605e4ac-d365-4ba7-86ca-e532e144769e

📥 Commits

Reviewing files that changed from the base of the PR and between f8fc195 and 98eac09.

📒 Files selected for processing (3)
  • ci-operator/config/openshift-online/rosa-e2e/openshift-online-rosa-e2e-main_capa-e2e.yaml
  • ci-operator/step-registry/rosa/e2e/capa/rosa-e2e-capa-commands.sh
  • ci-operator/step-registry/rosa/e2e/capa/rosa-e2e-capa-ref.yaml
🚧 Files skipped from review as they are similar to previous changes (2)
  • ci-operator/step-registry/rosa/e2e/capa/rosa-e2e-capa-ref.yaml
  • ci-operator/config/openshift-online/rosa-e2e/openshift-online-rosa-e2e-main_capa-e2e.yaml

Walkthrough

The ROSA Capa-E2E step now accepts optional OpenShift version and channel group values. The test configuration sets OpenShift 4.22.0 and the nightly channel. The command passes these values and name_prefix to run-test-suite.py.

Changes

ROSA Capa-E2E configuration

Layer / File(s) Summary
Configure and pass test parameters
ci-operator/step-registry/rosa/e2e/capa/rosa-e2e-capa-ref.yaml, ci-operator/config/openshift-online/rosa-e2e/openshift-online-rosa-e2e-main_capa-e2e.yaml, ci-operator/step-registry/rosa/e2e/capa/rosa-e2e-capa-commands.sh
The step defines optional OPENSHIFT_VERSION and CHANNEL_GROUP variables. The test configuration sets them to 4.22.0 and nightly. The command passes them with name_prefix to run-test-suite.py.

Estimated code review effort: 2 (Simple) | ~10 minutes

Suggested labels: ok-to-test

Suggested reviewers: serngawy, tiwillia

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the addition of OpenShift version and channel group support for CAPA e2e.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed The commit changes only YAML and a shell launcher; no It/Describe/Context/When titles were added. NAME_PREFIX is an argument, not a test title.
Test Structure And Quality ✅ Passed The commit changes only YAML configuration and a shell launcher; it adds no Ginkgo test code, assertions, waits, resource setup, or cleanup to review.
Microshift Test Compatibility ✅ Passed The patch changes only CI YAML and a shell command; it adds no Ginkgo tests or test declarations requiring MicroShift compatibility review.
Single Node Openshift (Sno) Test Compatibility ✅ Passed The PR changes only YAML configuration and a shell runner; HEAD contains no new Go or Ginkgo test declarations, so SNO compatibility checks are not applicable.
Topology-Aware Scheduling Compatibility ✅ Passed The patch changes CI environment variables and test-runner arguments only; it adds no deployment manifests, operators, controllers, or topology scheduling constraints.
Ote Binary Stdout Contract ✅ Passed The PR changes only CI YAML and a shell wrapper; no OTE/Go/Ginkgo binary or process-level suite setup is added, and the wrapper runs an external Python test suite.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed The commit changes only CI YAML and a shell runner; it adds no Ginkgo tests or IPv4-specific test logic. The compatibility check is not applicable.
No-Weak-Crypto ✅ Passed The PR adds only CI variables and Ansible argument handling; no MD5, SHA1, DES, RC4, Blowfish, ECB, custom crypto, or secret comparisons appear in added lines.
Container-Privileges ✅ Passed The commit adds only environment variables and test arguments. The changed manifests and script contain no privileged, host*, SYS_ADMIN, allowPrivilegeEscalation, or root security settings.
No-Sensitive-Data-In-Logs ✅ Passed The diff adds only non-sensitive version, channel, and run-prefix arguments; no new credential logging occurs, and existing tracing is disabled while secrets are loaded.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@andclt andclt changed the title fix: add openshift version and channel group support for CAPA e2e ROSAENG-62156 fix: add openshift version and channel group support for CAPA e2e Jul 31, 2026
@openshift-ci

openshift-ci Bot commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: andclt
Once this PR has been reviewed and has the lgtm label, please assign tiwillia for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
openshift-ci Bot requested review from serngawy and tiwillia July 31, 2026 13:49

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@ci-operator/step-registry/rosa/e2e/capa/rosa-e2e-capa-commands.sh`:
- Around line 96-105: Update the EXTRA_VARS construction in the rosa-hcp-e2e
command flow to use a Bash array, appending each `-e` key/value pair as separate
elements and expanding it with `"${EXTRA_VARS[@]}"` when invoking
`run-test-suite.py`. Preserve the existing conditional variables and leave
`${TEST_SUITE}` unchanged.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: c73906e6-e611-42ca-aa28-4beb3deb1455

📥 Commits

Reviewing files that changed from the base of the PR and between c54020d and e4930f2.

📒 Files selected for processing (3)
  • ci-operator/config/openshift-online/rosa-e2e/openshift-online-rosa-e2e-main_capa-e2e.yaml
  • ci-operator/step-registry/rosa/e2e/capa/rosa-e2e-capa-commands.sh
  • ci-operator/step-registry/rosa/e2e/capa/rosa-e2e-capa-ref.yaml

Comment thread ci-operator/step-registry/rosa/e2e/capa/rosa-e2e-capa-commands.sh Outdated
@andclt

andclt commented Jul 31, 2026

Copy link
Copy Markdown
Contributor Author

/pj-rehearse periodic-ci-openshift-online-rosa-e2e-main_capa-e2e-capa-e2e

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@andclt: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@andclt
andclt force-pushed the fix/capa-staging-openshift-version branch from e4930f2 to 56bfbc4 Compare July 31, 2026 13:59
@andclt

andclt commented Jul 31, 2026

Copy link
Copy Markdown
Contributor Author

/pj-rehearse periodic-ci-openshift-online-rosa-e2e-main_capa-e2e-capa-e2e

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@andclt: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@andclt
andclt force-pushed the fix/capa-staging-openshift-version branch from 56bfbc4 to f8fc195 Compare July 31, 2026 16:00
@andclt

andclt commented Jul 31, 2026

Copy link
Copy Markdown
Contributor Author

/pj-rehearse periodic-ci-openshift-online-rosa-e2e-main_capa-e2e-capa-e2e

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@andclt: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@andclt
andclt force-pushed the fix/capa-staging-openshift-version branch from f8fc195 to 98eac09 Compare July 31, 2026 16:23
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@andclt: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
periodic-ci-openshift-online-rosa-e2e-main_capa-e2e-capa-e2e N/A periodic Ci-operator config changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@andclt

andclt commented Jul 31, 2026

Copy link
Copy Markdown
Contributor Author

/pj-rehearse periodic-ci-openshift-online-rosa-e2e-main_capa-e2e-capa-e2e

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@andclt: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci

openshift-ci Bot commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

@andclt: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/periodic-ci-openshift-online-rosa-e2e-main_capa-e2e-capa-e2e 98eac09 link unknown /pj-rehearse periodic-ci-openshift-online-rosa-e2e-main_capa-e2e-capa-e2e

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant