Skip to content

Add minimal CI for openshift/bgp-cloud-connector - #82735

Closed
alebedev87 wants to merge 1 commit into
openshift:mainfrom
alebedev87:bgp-cloud-connector
Closed

Add minimal CI for openshift/bgp-cloud-connector#82735
alebedev87 wants to merge 1 commit into
openshift:mainfrom
alebedev87:bgp-cloud-connector

Conversation

@alebedev87

@alebedev87 alebedev87 commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Onboard openshift/bgp-cloud-connector with minimal CI: image build from Dockerfile and unit tests via make test
  • Uses from_repository build root (.ci-operator.yaml from the repo targeting Go 1.26, OCP 4.23 integration stream)
  • Add Prow plugin config enabling approve, lgtm, and label plugins
  • Tide merge policy requires only approved label on main to allow self-merging during initial bootstrap

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Adds minimal CI for openshift/bgp-cloud-connector.
  • Builds Docker images from Dockerfile and runs unit tests with make test.
  • Uses the repository’s .ci-operator.yaml build root with Go 1.26 and the OCP 4.23 integration stream.
  • Adds Prow configuration for approve, lgtm, and label.
  • Allows Tide to merge pull requests to main when they have the approved and lgtm labels and no blocking labels.

@coderabbitai

coderabbitai Bot commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: d980275e-aa35-4976-b67f-d421e1f103f5

📥 Commits

Reviewing files that changed from the base of the PR and between baac17d and 73cdf9c.

📒 Files selected for processing (2)
  • core-services/prow/02_config/openshift/bgp-cloud-connector/_pluginconfig.yaml
  • core-services/prow/02_config/openshift/bgp-cloud-connector/_prowconfig.yaml

Cache: Disabled due to data retention organization setting

Knowledge base: Disabled due to data retention organization setting


Walkthrough

This change adds repository-specific Prow plugin settings and a Tide merge query for openshift/bgp-cloud-connector. The configuration enables approval workflows and automated merges to main based on required labels and blocking labels.

Changes

Repository Prow integration

Layer / File(s) Summary
Approval plugins and Tide merge policy
core-services/prow/02_config/openshift/bgp-cloud-connector/*
Configures approve and lgtm, disables required self-approval, and enables Tide merges to main when pull requests have approved and lgtm labels without blocking labels.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Possibly related PRs

Suggested labels: lgtm

Suggested reviewers: hector-vido, prucek

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the primary change: adding minimal CI for openshift/bgp-cloud-connector.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed The PR adds only CI, Prow, and OWNERS YAML files. It adds no Ginkgo test source or test-title expressions.
Test Structure And Quality ✅ Passed The patch adds only CI/Prow YAML and OWNERS files; it contains no Ginkgo test code, It blocks, cluster operations, or assertions to review.
Microshift Test Compatibility ✅ Passed The pull request adds only CI, Prow, and OWNERS configuration files; it adds no Ginkgo e2e tests or MicroShift-incompatible API references.
Single Node Openshift (Sno) Test Compatibility ✅ Passed The patch adds only YAML and OWNERS/CI configuration files; it adds no Go or Ginkgo e2e tests, so SNO compatibility review is not applicable.
Topology-Aware Scheduling Compatibility ✅ Passed The PR changes only CI-operator, Prow job, plugin, Tide, and OWNERS files; it adds no deployment manifests, operator code, controllers, or topology scheduling constraints.
Ote Binary Stdout Contract ✅ Passed The PR adds only YAML, OWNERS, and generated CI job configuration; it contains no OTE binary source or process-level stdout writes to evaluate.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed The commit adds only YAML and OWNERS configuration files; it adds no Ginkgo e2e tests or test source with IPv4 assumptions or external connectivity.
No-Weak-Crypto ✅ Passed All six added files are CI YAML or OWNERS metadata; scans of every added line found no MD5, SHA-1, DES, RC4, Blowfish, ECB, custom crypto, or secret comparisons.
Container-Privileges ✅ Passed All six changed files contain no privileged, hostPID, hostNetwork, hostIPC, SYS_ADMIN, allowPrivilegeEscalation, or securityContext settings.
No-Sensitive-Data-In-Logs ✅ Passed The PR adds only CI/Prow YAML and OWNERS files; the parent-to-HEAD diff contains no logging commands or sensitive-data literals.
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@openshift-ci
openshift-ci Bot requested review from Prucek and hector-vido July 31, 2026 14:49
@openshift-ci

openshift-ci Bot commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alebedev87

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 31, 2026

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In
`@core-services/prow/02_config/openshift/bgp-cloud-connector/_pluginconfig.yaml`:
- Around line 5-7: Remove the repo-level lgtm configuration block from
_pluginconfig.yaml, including the repos entry for openshift/bgp-cloud-connector;
rely on the organization-level inherited lgtm plugin and leave other plugin
configuration unchanged.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 9d832653-9437-42ae-a46f-c05ae48cb1c4

📥 Commits

Reviewing files that changed from the base of the PR and between 8a6a1ad and 0fa6132.

⛔ Files ignored due to path filters (1)
  • ci-operator/jobs/openshift/bgp-cloud-connector/openshift-bgp-cloud-connector-main-presubmits.yaml is excluded by !ci-operator/jobs/**
📒 Files selected for processing (3)
  • ci-operator/config/openshift/bgp-cloud-connector/openshift-bgp-cloud-connector-main.yaml
  • core-services/prow/02_config/openshift/bgp-cloud-connector/_pluginconfig.yaml
  • core-services/prow/02_config/openshift/bgp-cloud-connector/_prowconfig.yaml

Comment on lines +5 to +7
lgtm:
- repos:
- openshift/bgp-cloud-connector

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🗄️ Data Integrity & Integration | 🟠 Major | ⚡ Quick win

Remove the repo-level lgtm block.

This repo inherits the lgtm plugin at the org level. Do not add lgtm again at the repo level. This duplication can cause make prow-config or determinize-prow-config to fail with a duplicate plugin error.

🔧 Proposed fix
 approve:
 - repos:
   - openshift/bgp-cloud-connector
   require_self_approval: false
-lgtm:
-- repos:
-  - openshift/bgp-cloud-connector
 plugins:
   openshift/bgp-cloud-connector:
     plugins:
     - approve

Based on learnings, repo-level _pluginconfig.yaml files should generally not add the lgtm plugin since it is inherited at the org level, and doing so "can cause make prow-config / determinize-prow-config to fail with a duplicate plugin error."

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
lgtm:
- repos:
- openshift/bgp-cloud-connector
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In
`@core-services/prow/02_config/openshift/bgp-cloud-connector/_pluginconfig.yaml`
around lines 5 - 7, Remove the repo-level lgtm configuration block from
_pluginconfig.yaml, including the repos entry for openshift/bgp-cloud-connector;
rely on the organization-level inherited lgtm plugin and leave other plugin
configuration unchanged.

Source: Learnings

@alebedev87
alebedev87 force-pushed the bgp-cloud-connector branch 2 times, most recently from c825865 to baac17d Compare August 3, 2026 09:03
Enable approve, lgtm, and label plugins. Tide merge policy requires
`approved` and `lgtm` labels on `main`. CI will be handled via Konflux.

Co-Authored-By: Claude
@alebedev87
alebedev87 force-pushed the bgp-cloud-connector branch from baac17d to 73cdf9c Compare August 3, 2026 09:46
@alebedev87 alebedev87 closed this Aug 3, 2026
@openshift-merge-bot openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Aug 3, 2026
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@alebedev87: no rehearsable tests are affected by this change

Note: If this PR includes changes to step registry files (ci-operator/step-registry/) and you expected jobs to be found, try rebasing your PR onto the base branch. This helps pj-rehearse accurately detect changes when the base branch has moved forward.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant