Skip to content

Migrate sa-claude-openshift-ci jobs to openshift-ci-prow-agents GCP project - #82801

Merged
openshift-merge-bot[bot] merged 3 commits into
openshift:mainfrom
not-stbenjam:hpnex-22-migrate-prow-sa-gcp-project
Aug 3, 2026
Merged

Migrate sa-claude-openshift-ci jobs to openshift-ci-prow-agents GCP project#82801
openshift-merge-bot[bot] merged 3 commits into
openshift:mainfrom
not-stbenjam:hpnex-22-migrate-prow-sa-gcp-project

Conversation

@not-stbenjam

@not-stbenjam not-stbenjam commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

Summary

Migrates all Claude AI step-registry refs from the old GCP project itpc-gcp-hybrid-pe-eng-claude to the new project openshift-ci-prow-agents, updates credential token keys, and moves non-hypershift steps that only need the google token to sa-claude-openshift-ci.

Commit 1 — 5 refs using sa-claude-openshift-ci secret:

  • ANTHROPIC_VERTEX_PROJECT_ID: itpc-gcp-hybrid-pe-eng-claudeopenshift-ci-prow-agents
  • GOOGLE_APPLICATION_CREDENTIALS token key: tokengoogle-token
  • Steps: openshift-claude-payload-agent, openshift-claude-agent-eval, openshift-edge-tooling-agent-eval, openshift-edge-tooling-lvms-ci-doctor, openshift-edge-tooling-microshift-ci-doctor

Commit 2 — 15 refs using hypershift-team-claude-prow secret:

  • ANTHROPIC_VERTEX_PROJECT_ID: itpc-gcp-hybrid-pe-eng-claudeopenshift-ci-prow-agents
  • GOOGLE_APPLICATION_CREDENTIALS token key: claude-prowgoogle-token

Commit 3 — Move 10 non-hypershift steps from hypershift-team-claude-prowsa-claude-openshift-ci:
These steps only consume the google token for Vertex AI auth; their GitHub/Jira/Slack credentials come from separate secrets. Verified by auditing each step's command script for references to the mount path.

Step Other credential secrets
openshift-edge-tooling-ci-monitor pr-creds, claude-payload-agent-jira-token
openshift-api-review-run api-review-bot-github-app
openshift-api-eval-run (none)
openshift-api-eval-setup (none)
openshift-agentic-trt-review-responder trt-agent-gh-app
openshift-agentic-trt-jira-solver trt-agent-gh-app
openshift-agentic-trt-eval-solve trt-agent-gh-app
openshift-agentic-trt-init (mounts secret but script reads nothing from it)
jira-agent-setup (none — only checks GOOGLE_APPLICATION_CREDENTIALS exists)
jira-agent-claude-helpers (mounts secret, writes helper functions to SHARED_DIR that don't read from mount)

Steps remaining on hypershift-team-claude-prow (use additional keys like app-id, private-key, jira-pat, gangway-token, etc.):

  • review-agent-process, jira-agent-process, jira-agent-github-app-auth, jira-agent-git-helpers, jira-agent-jira-helpers, jira-agent-slack-pr-notify, installer-review-agent-trigger
  • All hypershift/* steps

Not in scope

  • openshift-observability-qe-agent — uses a different project (itpc-gcp-hcm-pe-eng-claude) and different secret (dt-secrets)

Test plan

  • Verify a job using sa-claude-openshift-ci runs successfully (e.g. payload-agent or api-review)
  • Verify a job still on hypershift-team-claude-prow runs successfully (e.g. hypershift-jira-agent)

🤖 Generated with Claude Code

Summary by CodeRabbit

Migrates OpenShift CI Claude workflows to the openshift-ci-prow-agents GCP project.

Updates Vertex AI project defaults and changes credential paths to use google-token. Several non-Hypershift workflows also switch from hypershift-team-claude-prow to sa-claude-openshift-ci.

Affected workflows include Claude, OpenShift API, Edge Tooling, TRT, Jira, Review Agent, and HyperShift steps.

…roject

Update all step-registry refs that mount the sa-claude-openshift-ci secret
to use the new GCP project (openshift-ci-prow-agents) and new token key
(google-token) in that secret.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

Walkthrough

CI step configurations now use the openshift-ci-prow-agents Vertex AI project, the /var/run/claude-code-service-account/google-token credentials file, and, where applicable, the sa-claude-openshift-ci secret.

Changes

Vertex AI credential configuration

Layer / File(s) Summary
Update Vertex AI and credential defaults
ci-operator/step-registry/openshift/claude/..., ci-operator/step-registry/openshift/edge-tooling/..., ci-operator/step-registry/hypershift/..., ci-operator/step-registry/jira-agent/process/..., ci-operator/step-registry/review-agent/...
Updated Vertex AI project identifiers and Google application credential paths.
Update service-account references
ci-operator/step-registry/jira-agent/..., ci-operator/step-registry/openshift/agentic/trt/..., ci-operator/step-registry/openshift/edge-tooling/ci-monitor/...
Changed mounted credential references to sa-claude-openshift-ci and updated related Vertex AI defaults.
Update API evaluation and review steps
ci-operator/step-registry/openshift/api/...
Updated Vertex AI project identifiers, credential paths, and mounted credential secrets for API evaluation and review steps.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

  • openshift/release#82520: Modifies Claude/Vertex AI credential configuration for the openshift-agentic-trt-eval-solve step.

Suggested reviewers: enxebre, fracappa, smg247

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed The full PR changes 22 YAML step-registry refs only; no Ginkgo declarations or test titles, dynamic values, or test code were added or changed.
Test Structure And Quality ✅ Passed The complete PR range changes 22 YAML ref files only; no Ginkgo test paths or constructs are added or modified, so this test-quality check is not applicable.
Microshift Test Compatibility ✅ Passed The two-commit pull request changes only 17 YAML step-registry references and adds no Ginkgo tests or test declarations.
Single Node Openshift (Sno) Test Compatibility ✅ Passed The PR changes only 10 YAML step-registry credential references and adds no Ginkgo e2e tests or node/HA assumptions, so the SNO check is not applicable.
Topology-Aware Scheduling Compatibility ✅ Passed The diff modifies only credential secret names in 10 step-registry refs; it adds no deployment, controller, or scheduling constraints.
Ote Binary Stdout Contract ✅ Passed The PR changes only YAML step-registry refs; the 22-file migration range has no executable source or OTE process-level stdout writes.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed The full diff against origin/main changes 22 YAML refs only; it adds no Ginkgo tests, IPv4 assumptions, or external-network code.
No-Weak-Crypto ✅ Passed The PR changes only 22 YAML refs; added lines update project, credential paths, and secret names, with no weak algorithms, crypto implementations, or secret comparisons.
Container-Privileges ✅ Passed The full PR diff changes only credential names and Vertex AI environment defaults in step-registry refs; no privileged, host namespace, SYS_ADMIN, root, or allowPrivilegeEscalation settings are added.
No-Sensitive-Data-In-Logs ✅ Passed The PR changes only 22 YAML refs; added lines set a project ID, credential path, or secret name, with no logging statements or literal secret values.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the migration of sa-claude-openshift-ci jobs to the openshift-ci-prow-agents GCP project.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@openshift-ci openshift-ci Bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 3, 2026
@openshift-ci

openshift-ci Bot commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

Hi @not-stbenjam. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Tip

We noticed you've done this a few times! Consider joining the org to skip this step and gain /lgtm and other bot rights. We recommend asking approvers on your previous PRs to sponsor you.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci
openshift-ci Bot requested review from enxebre and fracappa August 3, 2026 10:49
@vimauro

vimauro commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

Should we include also edge-tooling-ci-monitor ? I see it uses the same ANTHROPIC_VERTEX_PROJECT_ID of the projects mentioned in this PR:

@stbenjam

stbenjam commented Aug 3, 2026

Copy link
Copy Markdown
Member

It is using a different secret:

- namespace: test-credentials
name: hypershift-team-claude-prow
mount_path: /var/run/claude-code-service-account

I am working on getting access to that one so I can update it as well. It will be updated here or another PR

not-stbenjam and others added 2 commits August 3, 2026 11:22
…GCP project

Update all step-registry refs that mount the hypershift-team-claude-prow
secret to use the new GCP project (openshift-ci-prow-agents) and new
token key (google-token) replacing the old claude-prow key.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…laude-openshift-ci

These steps only consume the google token for Vertex AI authentication
and get their GitHub/Jira/Slack credentials from separate secrets.
Moving them to sa-claude-openshift-ci narrows the scope of the
hypershift-team-claude-prow secret to actual hypershift jobs and
the jira-agent chain steps that need its additional keys.

Steps moved: openshift-edge-tooling-ci-monitor, openshift-api-review-run,
openshift-api-eval-run, openshift-api-eval-setup,
openshift-agentic-trt-{review-responder,jira-solver,eval-solve,init},
jira-agent-setup, jira-agent-claude-helpers.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@not-stbenjam: pj-rehearse could not automatically process this event because the request waited in queue for longer than 5 minutes. Use /pj-rehearse to trigger rehearsals manually.

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@not-stbenjam: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-release-main-jira-solver-eval-jira-solver-eval openshift/release presubmit Registry content changed
pull-ci-openshift-api-master-evals-eval openshift/api presubmit Registry content changed
pull-ci-openshift-api-master-api-review openshift/api presubmit Registry content changed
pull-ci-openshift-api-release-5.1-api-review openshift/api presubmit Registry content changed
pull-ci-openshift-api-release-5.0-api-review openshift/api presubmit Registry content changed
pull-ci-openshift-api-release-4.23-api-review openshift/api presubmit Registry content changed
pull-ci-openshift-eng-ai-helpers-main-eval-payload-analysis openshift-eng/ai-helpers presubmit Registry content changed
pull-ci-openshift-eng-ai-helpers-main-eval-payload-analysis-changed openshift-eng/ai-helpers presubmit Registry content changed
pull-ci-openshift-eng-ai-helpers-main-eval-payload-analysis-minimal openshift-eng/ai-helpers presubmit Registry content changed
pull-ci-openshift-eng-ai-helpers-main-eval-prow-job-analysis openshift-eng/ai-helpers presubmit Registry content changed
pull-ci-openshift-eng-ai-helpers-main-eval-prow-job-analysis-minimal openshift-eng/ai-helpers presubmit Registry content changed
pull-ci-openshift-eng-ai-helpers-main-eval-classify-review-comment openshift-eng/ai-helpers presubmit Registry content changed
pull-ci-openshift-eng-ai-helpers-main-eval-address-reviews openshift-eng/ai-helpers presubmit Registry content changed
pull-ci-openshift-eng-ai-helpers-main-eval-ready-to-solve openshift-eng/ai-helpers presubmit Registry content changed
pull-ci-openshift-eng-ai-helpers-main-eval-jira-solve openshift-eng/ai-helpers presubmit Registry content changed
pull-ci-openshift-eng-ai-helpers-main-payload-agent openshift-eng/ai-helpers presubmit Registry content changed
pull-ci-openshift-eng-edge-tooling-main-eval-all openshift-eng/edge-tooling presubmit Registry content changed
pull-ci-openshift-eng-edge-tooling-main-eval-changed openshift-eng/edge-tooling presubmit Registry content changed
pull-ci-openshift-hypershift-main-agentic-qe-aws openshift/hypershift presubmit Registry content changed
pull-ci-openshift-hypershift-release-5.1-agentic-qe-aws openshift/hypershift presubmit Registry content changed
pull-ci-openshift-hypershift-release-5.0-agentic-qe-aws openshift/hypershift presubmit Registry content changed
pull-ci-openshift-hypershift-release-4.23-agentic-qe-aws openshift/hypershift presubmit Registry content changed
pull-ci-openshift-hypershift-release-4.22-agentic-qe-aws openshift/hypershift presubmit Registry content changed
pull-ci-openshift-hypershift-main-e2e-aks openshift/hypershift presubmit Registry content changed
pull-ci-openshift-hypershift-main-e2e-aws openshift/hypershift presubmit Registry content changed

A total of 53 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs.

A full list of affected jobs can be found here

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@stbenjam

stbenjam commented Aug 3, 2026

Copy link
Copy Markdown
Member

/ok-to-test

Extending self-approval rights to the bot:
/approve

/hold

@openshift-ci openshift-ci Bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 3, 2026

@bryan-cox bryan-cox left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Aug 3, 2026
@openshift-ci

openshift-ci Bot commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bryan-cox, not-stbenjam, stbenjam

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@redhat-chai-bot

Copy link
Copy Markdown
Contributor

/pj-rehearse periodic-ci-openshift-release-main-payload-agent-analyze pull-ci-openshift-eng-edge-tooling-main-eval-all periodic-ci-openshift-hypershift-main-dependabot-triage pull-ci-openshift-eng-ai-helpers-main-eval-payload-analysis-minimal


AI-generated. Review for accuracy.

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@redhat-chai-bot: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci

openshift-ci Bot commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

@not-stbenjam: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@redhat-chai-bot

redhat-chai-bot commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

✅ GCP Project Migration Verified

All 4 rehearsal jobs passed with the new google-token credential from the openshift-ci-prow-agents GCP project. Each job was verified to be using Vertex AI authentication (anthropic[vertex] SDK, req_vrtx_-prefixed API request IDs) with claude-opus-4-6:

Job Status Evidence
payload-agent-analyze ✅ Pass Auth: Vertex AI, 36 turns, $6.57, full payload analysis of 5.0 nightly
edge-tooling-eval-all ✅ Pass anthropic[vertex]>=0.40, 2 eval suites (cluster-diagnostic + threat-model-tnf)
ai-helpers-eval-payload-analysis-minimal ✅ Pass anthropic[vertex]>=0.40, req_vrtx_ API calls
hypershift-dependabot-triage ✅ Pass req_vrtx_ API calls, processed 10 dependabot PRs with cherry-pick + make verify

Zero authentication errors across all jobs. The migration from itpc-gcp-hybrid-pe-eng-claude to openshift-ci-prow-agents is working correctly.

Tracked by: HPNEX-22


AI-generated. Review for accuracy.

@redhat-chai-bot

Copy link
Copy Markdown
Contributor

/hold cancel


AI-generated. Review for accuracy.

@openshift-ci openshift-ci Bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 3, 2026
@stbenjam

stbenjam commented Aug 3, 2026

Copy link
Copy Markdown
Member

/pj-rehearse ack

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@stbenjam: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-merge-bot openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Aug 3, 2026
@openshift-merge-bot
openshift-merge-bot Bot merged commit 818eb34 into openshift:main Aug 3, 2026
17 checks passed
amogh-redhat pushed a commit to amogh-redhat/release that referenced this pull request Aug 5, 2026
…roject (openshift#82801)

* Migrate sa-claude-openshift-ci jobs to openshift-ci-prow-agents GCP project

Update all step-registry refs that mount the sa-claude-openshift-ci secret
to use the new GCP project (openshift-ci-prow-agents) and new token key
(google-token) in that secret.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* Migrate hypershift-team-claude-prow jobs to openshift-ci-prow-agents GCP project

Update all step-registry refs that mount the hypershift-team-claude-prow
secret to use the new GCP project (openshift-ci-prow-agents) and new
token key (google-token) replacing the old claude-prow key.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* Move 10 non-hypershift steps from hypershift-team-claude-prow to sa-claude-openshift-ci

These steps only consume the google token for Vertex AI authentication
and get their GitHub/Jira/Slack credentials from separate secrets.
Moving them to sa-claude-openshift-ci narrows the scope of the
hypershift-team-claude-prow secret to actual hypershift jobs and
the jira-agent chain steps that need its additional keys.

Steps moved: openshift-edge-tooling-ci-monitor, openshift-api-review-run,
openshift-api-eval-run, openshift-api-eval-setup,
openshift-agentic-trt-{review-responder,jira-solver,eval-solve,init},
jira-agent-setup, jira-agent-claude-helpers.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants