Skip to content

setup assisted-installer version v2.55 - #82822

Open
danmanor wants to merge 1 commit into
openshift:mainfrom
danmanor:assisted-installer/setup-version-v2.55-eb300147-94ab-445a-8eba-0e76e5a2b950
Open

setup assisted-installer version v2.55#82822
danmanor wants to merge 1 commit into
openshift:mainfrom
danmanor:assisted-installer/setup-version-v2.55-eb300147-94ab-445a-8eba-0e76e5a2b950

Conversation

@danmanor

@danmanor danmanor commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

Updated Assisted Installer v2.55 CI configurations for the assisted-installer and assisted-installer-agent repositories.

  • Set always_run: false for the affected tests.
  • Replaced skip_if_only_changed with pipeline_skip_if_only_changed.
  • Applied the changes to subsystem-test and e2e-metal-assisted test definitions.

@coderabbitai

coderabbitai Bot commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: a5cd73af-b505-45d9-ac73-9940b90b81e2

📥 Commits

Reviewing files that changed from the base of the PR and between ab2a276 and 6e958b3.

⛔ Files ignored due to path filters (2)
  • ci-operator/jobs/openshift/assisted-installer-agent/openshift-assisted-installer-agent-v2.55-presubmits.yaml is excluded by !ci-operator/jobs/**
  • ci-operator/jobs/openshift/assisted-installer/openshift-assisted-installer-v2.55-presubmits.yaml is excluded by !ci-operator/jobs/**
📒 Files selected for processing (2)
  • ci-operator/config/openshift/assisted-installer-agent/openshift-assisted-installer-agent-v2.55.yaml
  • ci-operator/config/openshift/assisted-installer/openshift-assisted-installer-v2.55.yaml

Walkthrough

The PR updates Assisted Installer v2.55 CI test definitions. It sets always_run: false and replaces skip_if_only_changed with pipeline_skip_if_only_changed for the affected tests.

Changes

Assisted Installer CI configuration

Layer / File(s) Summary
Update test execution filtering
ci-operator/config/openshift/assisted-installer*/...v2.55.yaml
The subsystem-test and e2e-metal-assisted definitions disable unconditional execution. Their change-filtering fields now use pipeline_skip_if_only_changed.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the assisted-installer v2.55 setup changes in the pull request.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed The commit changes only static CI YAML and generated presubmit metadata; it adds no Ginkgo titles or dynamic test-name values.
Test Structure And Quality ✅ Passed The diff changes only CI YAML configuration and generated presubmit YAML; it adds no Ginkgo It blocks or cluster-test code for this check to assess.
Microshift Test Compatibility ✅ Passed The commit changes only four YAML CI configuration/job files and adds no Ginkgo tests or test declarations requiring MicroShift API compatibility review.
Single Node Openshift (Sno) Test Compatibility ✅ Passed The commit changes only four CI YAML files; it adds no Ginkgo tests, source files, or topology assumptions requiring SNO review.
Topology-Aware Scheduling Compatibility ✅ Passed The commit changes only ci-operator YAML test and presubmit definitions; it adds no deployment manifests, operator code, controllers, or scheduling constraints.
Ote Binary Stdout Contract ✅ Passed The PR changes only CI YAML and generated Prow job metadata; no OTE binary, main/suite setup, or stdout-writing source code changed or present in the affected paths.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed The commit changes only CI YAML and generated presubmit metadata; it adds no Ginkgo tests, IPv4 assumptions, or new external connectivity operations.
No-Weak-Crypto ✅ Passed The patch changes only four CI YAML files; the added-content scan found no MD5, SHA-1, DES, 3DES, RC4, Blowfish, ECB, crypto implementation, or secret-comparison terms.
Container-Privileges ✅ Passed The parent diff only changes CI scheduling keys. Both v2.55 YAML files contain no privileged, host namespace, SYS_ADMIN, root, or allowPrivilegeEscalation settings; capabilities are only intranet.
No-Sensitive-Data-In-Logs ✅ Passed The diff only changes CI scheduling fields and annotations; it adds no logging commands or sensitive values.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@openshift-ci
openshift-ci Bot requested review from jhernand and omertuc August 3, 2026 15:29
@openshift-ci

openshift-ci Bot commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danmanor

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 3, 2026
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@danmanor: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-assisted-installer-v2.55-e2e-metal-assisted openshift/assisted-installer presubmit Ci-operator config changed
pull-ci-openshift-assisted-installer-agent-v2.55-e2e-metal-assisted openshift/assisted-installer-agent presubmit Ci-operator config changed
pull-ci-openshift-assisted-installer-agent-v2.55-subsystem-test openshift/assisted-installer-agent presubmit Ci-operator config changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci

openshift-ci Bot commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

@danmanor: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants