Promote fips-scan to blocking for 5.0 nightly payloads

[redhat-chai-bot]

This PR removes optional: true from the fips-scan verify job entry in the 5.0 release controller configs, re-promoting it from informing to blocking (qualifying).\n\nThe job was temporarily demoted to informing in #80487 due to a known RHCOS 10 issue. This change restores it as a blocking job for 5.0 nightly payloads.\n\n## Changes\n\n- core-services/release-controller/_releases/release-ocp-5.0.json: removed \"optional\": true from fips-scan\n- core-services/release-controller/_releases/priv/release-ocp-5.0.json: removed \"optional\": true from fips-scan

---

AI-generated. Review for accuracy.

@neisw requested via Chai Bot

Summary by CodeRabbit

The PR makes the fips-scan verification job blocking for 5.0 nightly payloads in both release controller configurations. This restores the job’s qualifying status after its earlier demotion for the known RHCOS 10 issue. Its disabled status, retry limit, and Prow configuration remain unchanged.

[openshift-merge-bot]

[REHEARSALNOTIFIER]
@redhat-chai-bot: no rehearsable tests are affected by this change

Note: If this PR includes changes to step registry files (ci-operator/step-registry/) and you expected jobs to be found, try rebasing your PR onto the base branch. This helps pj-rehearse accurately detect changes when the base branch has moved forward.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: redhat-chai-bot
Once this PR has been reviewed and has the lgtm label, please assign smg247 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• core-services/release-controller/_releases/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: c2ad6744-77bd-4f45-873a-cf061d83ab9e

📥 Commits

Reviewing files that changed from the base of the PR and between 7e2cec1 and 9b11040.

📒 Files selected for processing (2)

• core-services/release-controller/_releases/priv/release-ocp-5.0.json
• core-services/release-controller/_releases/release-ocp-5.0.json

💤 Files with no reviewable changes (2)

• core-services/release-controller/_releases/priv/release-ocp-5.0.json
• core-services/release-controller/_releases/release-ocp-5.0.json

---

Walkthrough

The OCP 5.0 release configurations now require the fips-scan verification job. The job remains disabled, with its existing retry limit and Prow configuration.

Changes

FIPS scan requirement

Layer / File(s)	Summary
Update FIPS scan verification configuration core-services/release-controller/_releases/priv/release-ocp-5.0.json, core-services/release-controller/_releases/release-ocp-5.0.json	Removes optional: true from the fips-scan verification configuration in both release definitions. Other job settings remain unchanged.

Estimated code review effort: 1 (Trivial) | ~2 minutes

🚥 Pre-merge checks | ✅ 15

✅ Passed checks (15 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and concisely describes promoting fips-scan to a blocking job for 5.0 nightly payloads.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	The commit changes only two JSON release configurations and removes optional; no Ginkgo test titles or dynamic test-name values are introduced.
Test Structure And Quality	✅ Passed	The PR changes only two JSON release configurations; the parent diff contains no Ginkgo or test files, so these test-structure requirements do not apply.
Microshift Test Compatibility	✅ Passed	The commit changes only two JSON release configurations and adds no Ginkgo e2e tests, so MicroShift test compatibility checks do not apply.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	The commit changes only two release-controller JSON files and adds no Ginkgo tests, so the SNO test compatibility check is not applicable.
Topology-Aware Scheduling Compatibility	✅ Passed	The change only removes optional: true from two release-controller JSON job entries; it adds no manifests, controllers, or scheduling constraints.
Ote Binary Stdout Contract	✅ Passed	The PR changes only two release-controller JSON files, deleting optional from fips-scan; it changes no OTE binary or process-level Go code.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	The commit only deletes optional fields from two JSON release configs; it adds no Ginkgo tests or test networking code, so this check is not applicable.
No-Weak-Crypto	✅ Passed	The commit only removes optional: true from two fips-scan JSON entries; it adds no crypto code or weak-crypto usage.
Container-Privileges	✅ Passed	The PR deletes only optional: true from two release JSON entries; neither changed file contains privileged, hostPID, hostNetwork, hostIPC, SYS_ADMIN, or allowPrivilegeEscalation settings.
No-Sensitive-Data-In-Logs	✅ Passed	The commit only deletes optional: true from two JSON job entries. It adds no logging statements, credentials, tokens, PII, hostnames, or customer data.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}